Mugurell
8bf1cae2ca
For #10686 - Use the AC custom behavior for both the top and bottom toolbars
...
This comes to unify the experience (with improvements but also specific issues)
for the url toolbar irrespective of it being placed at the bottom or at the top
Going further this will ease development and ensure the best UX for users.
3 years ago
Gabriel Luong
a3d401a3b7
For #17418 - Add event ping telemetry for the Google Top Site click ( #17862 )
...
Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
jhugman
0b764fd3e4
Fixes #17833 - increment A/A experiment id ( #17835 ) r=christian
3 years ago
Christian Sadilek
50e66b469d
Remove SessionManager reference from FenixApplication
3 years ago
Oana Horvath
5cfd7cc388
For #17847 : disables editCustomSearchEngineTest
3 years ago
Oana Horvath
f0b7b3b987
For #17847 : disables editCustomSearchEngineTest
3 years ago
MickeyMoz
378e68f3a6
Update Android Components version to 73.0.20210204143136.
3 years ago
Andrei Joltan
936966596a
For #16020 Fix Intermittent tests caused by the Menu Button ( #17829 )
3 years ago
Oana Horvath
9783930ac5
For #16615 : UI smoke test customTrackingProtectionSettingsTest
3 years ago
AndiAJ
a4a2a59b7d
For #12895 Fix Intermittent test navigateBookmarksFoldersTest
3 years ago
hwinnemo
c488bb0e11
For #17724 : Wait for tab to be fully created before showing ETP Onboarding if ETP is active
3 years ago
Stefan Arentz
6518a60480
For #17655 : Do not pass threshold if showTopFrecentSites is false. ( #17657 ) ( #17813 )
...
* For #17655 : Do not pass threshold if showTopFrecentSites is false.
* For #17655 : Add unit tests for getTopSitesConfig.
(cherry picked from commit 8993a0acb2
)
Co-authored-by: Mihai Adrian Carare <48995920+mcarare@users.noreply.github.com>
3 years ago
Sebastian Kaspari
f4a7b4c066
Remove TabsUseCases methods that take a Session object.
3 years ago
Grisha Kruglov
3ce9bf93bc
Exclude separators from the bookmarks UI
3 years ago
Grisha Kruglov
ebca575e26
Reuse helper functions in bookmark tests
3 years ago
Mugurell
40fc9c1085
For #12414 - Support sharing images through ShareDownloadFeature
...
Register a ViewBoundFeatureWrapper<ShareDownloadFeature> that will respond to
"Share image" from the browser contextual menu
3 years ago
Michael Droettboom
fedc2e1187
Update bug numbers to URLs for activation ping
...
Earlier versions of Glean supported bug numbers of the metadata, but this causes
ambiguity, particularly for Fenix where issues exist in both Bugzilla and
Github. This just updates the Bugzilla numbers to full URLs.
We made the use of numbers an error sometime ago, but neglected to enforce this
on "pings" in addition to "metrics". A future version of `glean_parser` [1] will make
this an error and this will set Fenix up to be ready for that.
[1] https://github.com/mozilla/glean_parser/pull/262
3 years ago
mcarare
994ec4d55a
For #17364 : Make hint scrollable and do not overlap other elements.
3 years ago
mcarare
d7ad203544
For #17364 : Do not show search suggestion hint before starting to type.
3 years ago
rxu
542071a344
Add mozcn safebrowsing for release variant
3 years ago
Christian Sadilek
e76445b299
Refactor WebAppSiteControlsBuilder to use browser store
3 years ago
Mozilla L10n Automation Bot
dca0cb8c10
Import l10n.
3 years ago
Christian Sadilek
3dc638700f
Refactor tryReloadTabBy to use browser store
3 years ago
Sebastian Kaspari
28c105dcb3
Remove SessionManager dependency from CustomTabsIntegration.
3 years ago
Elise Richards
854a5e676f
Increase date on expired metrics ( #17766 )
3 years ago
Arturo Mejia
e3b6f060ae
For #12822 - Opt-in of scoped storage
3 years ago
Jonathan Almeida
824f3fd821
Issue #1340 : Forward Activity results to the fragment
3 years ago
Oana Horvath
f180d932c8
For #16959 : verify page url not content in swipeToSwitchTabTest
3 years ago
AndiAJ
c8c0131d00
Go Forward Test Fix
3 years ago
AndiAJ
5eb1a3d210
For #17641 Fix Intermittent test addPredefinedSearchEngineTest
3 years ago
AndiAJ
23e6f7aa91
For #16615 : UI Smoke Tests for Tab Crash Reporter
3 years ago
Adam Novak
8f9942196a
Give addons download IDs like new a-c does so we can look them up from links
3 years ago
Adam Novak
c384acf974
Welcome to Kotlin, we don't return things
3 years ago
Adam Novak
e85a366216
Bring back the interface import
3 years ago
Adam Novak
04d182fd20
Actually satisfy the linter after removing a bunch of Nimbus code
3 years ago
Adam Novak
a210d7529f
Satisfy linter and hardcode Nimbus off
3 years ago
Adam Novak
1b87a8b785
Let the link-driven add-on install logic build with our collection fetcher
3 years ago
Adam Novak
3d8b00f840
Drop our fixed version of the old removed search engine provider
3 years ago
Adam Novak
6d4a47921c
Merge tag 'v85.1.1' into upstream-sync
3 years ago
Mozilla L10n Automation Bot
4c2a4f4d2e
Import l10n.
3 years ago
jhugman
72f977771d
Re-enable Nimbus with Off the main thread I/O and non-blocking networking ( #17684 )
...
* Moved Nimbus setup from Analytics to its own file
* Change experiment identifiers to fit new run of the experiment
* Re-enable nimbus for debug and nightly builds
* ./gradlew ktlint && detekt
3 years ago
Christian Sadilek
5ca18a2ca3
Increase AMO collection cache timeout to 2 days
3 years ago
Michael Comella
498f49ba01
For #17553 : renew storage.stats metrics.
3 years ago
Christian Sadilek
d8085480ad
Increase AMO collection cache timeout to 2 days
3 years ago
Michael Comella
cdc008f6a3
For #17553 : renew storage.stats metrics.
3 years ago
Michael Comella
b6a503f0d6
Revert "For #17447 : add intentional delay to cold start up in debug and nightly."
...
This reverts commit 093470a8b3
. This
intentional regression was only intended to be temporary so now we're
removing it.
3 years ago
Christian Sadilek
89ad370eb2
Remove SessionManager references from UI tests
3 years ago
mawen7
1df656cd0e
Include selected session in session suggestions if opened from home fragment ( #17127 )
3 years ago
MickeyMoz
4bc6b85237
Update Android Components version to 73.0.20210129195412.
3 years ago
Mozilla L10n Automation Bot
4507560325
Import l10n.
3 years ago
Mozilla L10n Automation Bot
9afb78de3f
Import l10n.
3 years ago
Michael Comella
d48bb2a4cc
Revert "For #17447 : add intentional delay to cold start up in debug and nightly."
...
This reverts commit 093470a8b3
. This
intentional regression was only intended to be temporary so now we're
removing it.
3 years ago
Roger Yang
d434ff13a5
For #17092 : Dismiss toolbar menu when configuration change occurs ( #17682 )
3 years ago
Jonathan Almeida
66b94ced14
Close #1340 : Add support for WebAuthnFeature
3 years ago
rxu
be0382fca7
Pop out privacy notice in first launch in MozillaOnline builds
...
Add privacy notice related strings
Pop out privacy notice with onboarding
Using embeded geckoview to display details about privacy
Present or hide privacy pop window according to isMozillaOnline
Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
3 years ago
Codrut Topliceanu
e188185b15
For #16828 - Adds telemetry for open in app banner ( #17049 )
...
* For #16828 - Adds telemetry for open in app banner
Specifically: Banner displayed, Dismiss action, Go to Settings action.
3 years ago
Jonathan Almeida
81e08b2e7f
Close #15979 : Add MOZILLA_OFFICIAL flag for release builds
...
When we build release APKs on Mozilla infrastructure, we want a way to
know this in code for features that would only work on them.
3 years ago
Mozilla L10n Automation Bot
41e6c7247e
Import l10n.
3 years ago
Elise Richards
43b0b27819
Update metrics when an addon is installed or enabled ( #17669 )
3 years ago
Oana Horvath
d7b8af78c9
For #9188 : wait for page content to appear in Reader mode tests
3 years ago
Mozilla L10n Automation Bot
f3d332dd8b
Import l10n.
3 years ago
Mihai Adrian Carare
8993a0acb2
For #17655 : Do not pass threshold if showTopFrecentSites is false. ( #17657 )
...
* For #17655 : Do not pass threshold if showTopFrecentSites is false.
* For #17655 : Add unit tests for getTopSitesConfig.
3 years ago
Christian Sadilek
45c0ac85ec
Remove SessionManager from BrowserFragment/ToolbarGestureHandler
3 years ago
Roger Yang
124c2baf30
Closes #17531 : Use top sites count fact for top sites telemetry ( #17664 )
3 years ago
Oana Horvath
67ff4d460a
For #9188 : wait for page load in Reader mode
3 years ago
Roger Yang
eaef276345
Closes #17530 : Update has open tabs metrics when tabs are opened or closed ( #17557 )
3 years ago
mcarare
780e3362a5
For #17464 : Handle selected item background programmatically.
3 years ago
Mozilla L10n Automation Bot
4877b77073
Import l10n.
3 years ago
Christian Sadilek
ef8d07fadf
Fix breaking API change in FennecMigrator
3 years ago
Gabriel Luong
171c466ada
For #14302 - Skip one time pages visit from frecent top sites
3 years ago
ekager
1c363368de
Fix breaking change in migrateOpenTabs
3 years ago
ekager
ef4f9e1623
Fix breaking change with TopSiteConfig
3 years ago
mcarare
278ed658b6
For #17635 : Check if id corresponds to a custom tab before removing it.
3 years ago
Christian Sadilek
87d6f32374
Refactor HomeFragment to use browser store
3 years ago
Mozilla L10n Automation Bot
009bb89003
Import l10n.
3 years ago
Elise Richards
39f79778a2
For #17084 : Use in-app browser switching dialog ( #17628 )
...
Co-authored-by: hakkikaancaliskan <caliskanhkaan@gmail.com>
3 years ago
Elise Richards
f7b7b25213
For #16485 : Tabs tray grid view telemetry ( #17442 )
...
* Tabs tray CFR telemetry interactions
* Create CFR events and implementation
* Tests for tab tray controller
3 years ago
Sebastian Kaspari
023ddcc131
Refactor ExternalAppBrowserActivity and ExternalAppBrowserFragment to not use Session(Manager).
3 years ago
Arturo Mejia
b419ff82af
Remove external download manager FeatureFlags
3 years ago
Arturo Mejia
f99c175ceb
Remove autoplay indicator FeatureFlags
3 years ago
Oana Horvath
46487105d5
For #16615 & #11191 : re-enabled ReaderViewTest and added a UI smoke test
3 years ago
Mozilla L10n Automation Bot
c21b41c1b2
Import l10n.
3 years ago
Mozilla L10n Automation Bot
48419633be
Import l10n.
3 years ago
Mozilla L10n Automation Bot
ea7e8e4581
Import l10n.
3 years ago
Jonathan Almeida
65c69c6b9f
Fix breaking APIs in ActivityResultHandler
3 years ago
Christian Sadilek
7001fa1735
Closes #17473 : Intermittent failues of PwaOnboardingObserver
3 years ago
Gabriel Luong
70dc975299
For #17304 - Implement top site search engine attribution ( #17580 )
3 years ago
Sebastian Kaspari
0c41316c31
Revert "For #17044 : Explicitly set a new default engine when default is deleted."
...
This reverts commit 633bf384e2
.
3 years ago
Oana Horvath
d202daf47e
For #16615 : UI smoke test mainMenuInstallPWATest
3 years ago
Mozilla L10n Automation Bot
5f1b177bd7
Import l10n.
3 years ago
Michael Comella
d711874285
Closes #17451 : remove verbose logs with proguard.
3 years ago
ekager
083fe26f57
For #17542 - Removes flash on renaming top site and fixes title not being updated
3 years ago
William Durand
0537594810
Add new BuildConfig variables to support AMO non-production envs
3 years ago
fevziomurtekin
ddd49170d6
For issue: #16394 Fix UI for consider increasing some elements from ETP-Exceptions page
3 years ago
Jonathan Almeida
d32b3015c4
Use a smaller request code for WebAuthnFeature
...
We can't see the private API that we interact with on the OS, but after
some internal investigation it appears that there might be an upper
limit to the request code we can use.
For now, let's try a value similar to that use in the GVE code to see
our requests are failing because of that.
3 years ago
Christian Sadilek
c34d68d915
Closes #17548 : Remove SessionManager reference from TabTrayDialogFragment
3 years ago
Christian Sadilek
0de948e8ae
Issue #17548 : Remove SessionManager reference from TabHistoryDialog
3 years ago
Christian Sadilek
7358a313bf
Issue #17548 : Remove SessionManager reference from FenixTabsAdapter
3 years ago
Oana Horvath
7c56df41df
For #17309 , #13447 , #14534 UI tests: changed the way page Url is verified
3 years ago
Codrut Topliceanu
928ad21c51
For #17481 - Remove unused long_press_tapped metric ( #17544 )
3 years ago
Mozilla L10n Automation Bot
9f5838ecda
Import l10n.
3 years ago
AndiAJ
c8c19077ed
For #16615 : UI Smoke Tests for No history in PB and Add to home screen
3 years ago
mcarare
633bf384e2
For #17044 : Explicitly set a new default engine when default is deleted.
3 years ago
Codrut Topliceanu
20f2135578
For #17377 - Fix for empty awesomeBar on searchFragment open ( #17435 )
...
The awesomeBar was set to stay hidden for the first consumeFrom(store) if the SearchDialogFragment.kt. However, recent changes send an additional store update when the view is created. To work around it we can take a look at AwesomeBarView.update(), we see that the awesomeBar suggestions get provided only if the query != url. So we can use the same method to keep the awesomeBar hidden until the user changes anything in the url.
3 years ago
Mozilla L10n Automation Bot
959dcd2854
Import l10n.
3 years ago
Kate Glazko
ae528e5ab2
For #15181 : Remove All Downloads From Settings
3 years ago
Christian Sadilek
54da078bd3
Refactor QuickSettingsDialog to use browser store
3 years ago
Arturo Mejia
570383a54d
Add dot notification for autoplay blocked content
3 years ago
mcarare
af1af358a3
For #14011 : Remove new line character and spaces from string.
3 years ago
Jonathan Almeida
6dfd7ef757
Add experimental WebAuthn support for Nightly only
...
When testing out WebAuthn support with the privileged API,
we need our app to be signed by an allowed signing key.
We're seeing our tests fail with this error when testing locally:
```
[FidoApiImpl] updateTransaction is called for stop
[FidoApiImpl] finishSecurityKeyRequestController should not be called when SecurityKeyRequestController is null.
```
Our theory is that if we try this code on our signed APK, we should see
it work.
3 years ago
AndiAJ
f8ea4c5ca1
For #16615 : UI Smoke Tests for Tabs Tray
3 years ago
Christian Sadilek
d8c5f8887a
Refactor OpenSpecificTabIntentProcessor to use browser store
3 years ago
Christian Sadilek
be9b478906
Remove SessionManager from TrackingProtectionPanelDialogFragment
3 years ago
Christian Sadilek
f96fdc34eb
Refactor CrashReporterFragment to use browser store
3 years ago
Christian Sadilek
810200f2ab
Switch to use case when selecting tab for extensions
3 years ago
Christian Sadilek
c03e6377ae
Remove unused NotificationsIntentProcessor
3 years ago
Christian Sadilek
eb4beb252f
Remove unused SessionManager reference from RecentlyClosedController
3 years ago
Jonathan Almeida
d3dcf69064
A-C 71.0.20210118134928: Fix breaking API in TabCounterToolbarButton
3 years ago
Sebastian Kaspari
fb64c7c076
SearchDialogController: Pass tab ID instead of Session instance.
3 years ago
Christian Sadilek
f8359e72bf
Closes #17443 : IllegalStateException in startPostponedEnterTransition on HomeFragment
3 years ago
Mozilla L10n Automation Bot
d9ff67f330
Import l10n.
...
(cherry picked from commit 2a19967a32
)
3 years ago
Mozilla L10n Automation Bot
c76f1e5516
Import l10n.
...
(cherry picked from commit 837eaa3282
)
3 years ago
Mozilla L10n Automation Bot
48ba857dd6
Import l10n.
...
(cherry picked from commit 6a84eed552
)
3 years ago
Mozilla L10n Automation Bot
3a0d4837e2
Import l10n.
...
(cherry picked from commit 7fc0ef5379
)
3 years ago
isabelrios
e3dc851221
Changes to run tests on beta builds ( #16786 )
...
* Changes to run tests on beta builds
* remove dontoptime and fix bookmarks tests
* fix ktlint and smokeTest
* add variable for package name
* rebase and fix conflicts
* add yml files and modify script to run tests
* fix yml file indentation
* changes in kind file and add try_task
* fix error kind file
* fix error kind file 2
* fix error kind file 3
* fix reviewer comments
* remove mockwebserver implementation as per reviewer comment
* run beta tests only on releases branches
* reg exp for master branch
* reg exp for master branch2
* modify try_task with release branch
* remove try file
* let's start by running only one test
* address latest reviewers comments
* double check correct tasks for release branch
* remove try file after confirming beta build run
Co-authored-by: isabel rios <isabelrios@MBP-de-isabel-2.home>
3 years ago
MickeyMoz
d945cdc4c8
Update Android Components version to 71.0.20210117143132.
3 years ago
AndiAJ
eb910ff5e8
For #16615 : UI Smoke Tests for Bookmarks
...
For #16615 : UI Smoke Tests for Bookmarks
3 years ago
Oana Horvath
58cefbbb94
For #16615 : Collections UI smoke tests
3 years ago
Michael Comella
093470a8b3
For #17447 : add intentional delay to cold start up in debug and nightly.
...
I validated:
- that the log statement appeared in Nightly but not in Beta.
- that the local runtimes of our perftest increased (the median diff is 124ms)
3 years ago
Arturo Mejia
b9bdc288cb
For issue: #16846 Add ui for controlling exceptions for auto play
3 years ago
Sebastian Kaspari
0035417616
Add unit tests for FennecWebAppIntentProcessor.
3 years ago
Mugurell
d8dc1c4803
For #16519 : Add space above Delete History button ( #17492 )
...
add space above Delete History button
Co-authored-by: Jocelyne Abi Haidar <jocelyne.ah1@gmail.com>
3 years ago
Sebastian Kaspari
051988ecff
Migrate some "selected tab" reads from SessionManager to BrowserStore.
3 years ago
Arturo Mejia
a6495347fd
For issue #17457 : Prevent page refresh when tapping the security icon
3 years ago
codrut.topliceanu
90575e6dd7
For #16238 - Back button now dismisses Suggested Logins
...
By using PromptFeature's onBackPressed the user can now press back to dismiss the Suggested Logins prompt without inadvertently navigating back
3 years ago
Mozilla L10n Automation Bot
2a19967a32
Import l10n.
3 years ago
mcarare
8fa83a7bab
For #10417 : Improve reload collection tab testing.
3 years ago
mcarare
edcee71287
For #17400 : Select tab opened from collection.
3 years ago
mcarare
e110bb322f
For #16393 : Don't show divider above general category when not signed in
3 years ago
Christian Sadilek
978b555387
Closes #17443 : IllegalStateException in startPostponedEnterTransition on HomeFragment
3 years ago
isabelrios
d8584ed632
Changes to run tests on beta builds ( #16786 )
...
* Changes to run tests on beta builds
* remove dontoptime and fix bookmarks tests
* fix ktlint and smokeTest
* add variable for package name
* rebase and fix conflicts
* add yml files and modify script to run tests
* fix yml file indentation
* changes in kind file and add try_task
* fix error kind file
* fix error kind file 2
* fix error kind file 3
* fix reviewer comments
* remove mockwebserver implementation as per reviewer comment
* run beta tests only on releases branches
* reg exp for master branch
* reg exp for master branch2
* modify try_task with release branch
* remove try file
* let's start by running only one test
* address latest reviewers comments
* double check correct tasks for release branch
* remove try file after confirming beta build run
Co-authored-by: isabel rios <isabelrios@MBP-de-isabel-2.home>
3 years ago
Christian Sadilek
f0e10a7205
Closes #17441 : NPE when invalidating toolbar in response to reader changes
3 years ago
Christian Sadilek
53f77e422b
Closes #17441 : NPE when invalidating toolbar in response to reader changes
3 years ago
jhugman
44d9c303b7
SDK-158 Use disabled/no-op version of Nimbus object to eliminate unnecessary Rust call ( #17372 ) r=christian
3 years ago
jhugman
7a3524fae5
SDK-158 Use disabled/no-op version of Nimbus object to eliminate unnecessary Rust call ( #17372 ) r=christian
3 years ago
Arturo Mejia
00d971e9d3
For #16847 : Allow autoplay to controlled via the toolbar.
3 years ago
Sebastian Kaspari
0761f391fc
Update to latest feature-intent and feature-recentlyclosed APIs (and update Android Components).
3 years ago
Oana Horvath
7983a7fc89
For #16615 : UI smoke test editCustomSearchEngineTest
3 years ago
hakkikaancaliskan
542bc89284
For #12732 : Match notification accent color with app theme
3 years ago
Mihai Adrian Carare
3bb074b133
For #13522 : Also remove history entries from tab history. ( #17392 )
...
* For #13522 : Also remove history entries from tab history.
* For #13522 : Test that deleting history also removes it from tab history.
3 years ago
AndiAJ
fc964862e0
For #16615 : UI Smoke Tests for Recently Closed Tabs
3 years ago
Mozilla L10n Automation Bot
837eaa3282
Import l10n.
3 years ago
Oana Horvath
7ac4af46bc
For #10798 & #14526 : Apply auto-download test file fix for download UI tests
3 years ago
Oana Horvath
23789c86c4
For #16615 : UI smoke test manageDownloadsInDownloadsMenuTest
3 years ago
mcarare
4e736625bd
For #8716 : Authentication custom tab now considers browsing mode.
3 years ago
Mozilla L10n Automation Bot
6a84eed552
Import l10n.
3 years ago
Mozilla L10n Automation Bot
7fc0ef5379
Import l10n.
3 years ago
Christian Sadilek
cef56bef17
Update Android Components version to 71.0.20210108190105
3 years ago
Stefan Arentz
c0f1e25f79
String Uplifts for Firefox 85 ( #17371 )
...
* Import l10n.
(cherry picked from commit 7bf0f7595c
)
* Import l10n.
(cherry picked from commit 5445e61b6a
)
* Import l10n.
(cherry picked from commit 57d453dc7f
)
* Import l10n.
(cherry picked from commit 96b63485cc
)
* Import l10n.
(cherry picked from commit 33272d5447
)
* Import l10n.
(cherry picked from commit 16ab8bf1ab
)
* Import l10n.
(cherry picked from commit 96be55067d
)
* Import l10n.
(cherry picked from commit f8f677ce7f
)
* Import l10n.
(cherry picked from commit bad65b5017
)
* Import l10n.
(cherry picked from commit 9c776f1d7f
)
* Import l10n.
(cherry picked from commit f95547c271
)
* Import l10n.
(cherry picked from commit 9966a85bd5
)
* Import l10n.
(cherry picked from commit 1fbf227a61
)
Co-authored-by: Mozilla L10n Automation Bot <release+l10n-automation-bot@mozilla.com>
3 years ago
Suraj Shah
15f3743ca0
For #16271 - Fixes ripple being cut-off in Saved logins sort toolbar ( #16741 )
3 years ago
Mugurell
484f167714
For #16249 - ClipboardHandler cleans up returned text
3 years ago
mcarare
d110464a91
For #17117 : Use proper custom tab session for custom tab toolbar menu.
3 years ago
Mozilla L10n Automation Bot
1fbf227a61
Import l10n.
3 years ago
Arturo Mejia
0aa44c93cd
Closes issue #16945 Refactor TrackingProtectionOverlay to observe session via store.
3 years ago
Christian Sadilek
9a53054b28
Use new RestoreUseCase in A-C to handle tab timeouts
3 years ago
Mozilla L10n Automation Bot
9966a85bd5
Import l10n.
3 years ago
Arturo Mejia
743ba6918f
Closes issue #16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store.
3 years ago
mcarare
156dee29d8
For #15464 : Always dismiss search dialog on url committed.
3 years ago
Hakkı Kaan Çalışkan
e41cc5a414
For #17303 : Move ext fun runIfFragmentIsAttached to utils
...
move to ext
3 years ago
Gabriel Luong
d0fc086fc4
For #16790 - Allow top sites to have an empty name when renamed ( #17290 )
3 years ago
Roger Yang
afa0454f2b
Closes #16603 : Disable pull down when in fullscreen ( #17314 )
3 years ago
Marcello Galhardo
381f22449b
Closes #17118 : Fix font spacing when long pressing a URL ( #17164 )
3 years ago
Sebastian Kaspari
1b6cebf4d4
Switch to new SessionStorage / session restore API.
3 years ago
Oana Horvath
d7a35ed6bd
For #16966 : Remove unnecessary step from mainMenuAddToHomeScreenTest
3 years ago
ekager
d5f625c945
For #17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing
3 years ago
Mozilla L10n Automation Bot
f95547c271
Import l10n.
3 years ago
Roger Yang
7527851cf0
Closes #17298 : Turn on new MediaSession feature for all builds ( #17302 )
3 years ago
Marcello Galhardo
e3a77cb750
Closes #14009 : Fix onboarding 'Sign in to Firefox' ripple effect ( #17169 )
...
* Closes #14009 : Fix onboarding 'Sign in to Firefox' ripple effect
* For #14009 : Add 'onboarding_padded_background_color' instead of rely on OS theme/color
Both previous solution, '?android:attr/colorControlHighlight' and '@color/ripple_material_light' were using a OS theme attr or color, which caused problems. To fix it, we introduced a 'onboarding_padded_background_color' which manually define the ripple effect color of the onboarding manual sign in button.
3 years ago
MarcLeclair
24bce64e0b
16373 Count the # of inflations done on startup ( #16778 )
...
* For #16373 : Added performance Inflater to counter # of inflations
This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)
* For #16373 : Added test for PerformanceInflater
This test got quite awkward / complicated fast. I wanted to test the to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.
* For #16373 : Overrode getSystemService to return PerformanceInflater
This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.
* For #16373 : Added UI test for # of inflations
* For #16373 : Lint fix
* For #167373 : Changed the LayoutInflater cloneInContext to take this instead of inflater
The inflater parameter is set on the first call from the OS from the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.
* For #16373 : Fixed code issues for PR. No behavior change
* For #16373 : fixed some code nits
3 years ago
mcarare
251d652833
For #16027 : Allow elements to be selected separately by a11y services.
3 years ago
Gabriel Luong
487ba32441
For #17292 - Remove unused static_strings ( #17293 )
3 years ago
mcarare
2d1df018ff
For #15061 : Fix error text color in SyncedTabsFragment.
3 years ago
Codrut Topliceanu
c0f0c401f3
For #11580 - Tracks text selection context menu usage ( #16968 )
...
* For #11580 - Tracks text selection context menu usage
Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Marcello Galhardo
b34cc24f88
For #9778 - Site permission settings item height set to 48dp ( #17134 )
3 years ago
Mozilla L10n Automation Bot
9c776f1d7f
Import l10n.
3 years ago
Adam Novak
b707adb7f1
Satisfy the linter
3 years ago
Adam Novak
3b151c25a5
Cut more references to the tab picker onboarding
3 years ago
Adam Novak
847193edd5
Default to grid tab view
3 years ago
Adam Novak
c8b0326836
Rip out most other hooks into the tab tray customization code except the translations
3 years ago
Adam Novak
7b9eaa9304
Start ripping out the custom tab tray that I lack the resources to maintain
3 years ago
Adam Novak
39bb01f3c9
Merge tag 'v84.1.2' into beta-sync
3 years ago
Mozilla L10n Automation Bot
bad65b5017
Import l10n.
3 years ago
Mozilla L10n Automation Bot
f8f677ce7f
Import l10n.
3 years ago
Mozilla L10n Automation Bot
96be55067d
Import l10n.
3 years ago
Mozilla L10n Automation Bot
16ab8bf1ab
Import l10n.
3 years ago
Mozilla L10n Automation Bot
33272d5447
Import l10n.
3 years ago
Mozilla L10n Automation Bot
96b63485cc
Import l10n.
3 years ago
Mozilla L10n Automation Bot
57d453dc7f
Import l10n.
3 years ago
Christian Sadilek
801ce85898
For #17073 : Stop observers after test run
3 years ago
Mozilla L10n Automation Bot
5445e61b6a
Import l10n.
3 years ago