d2467f7541
For #13959 - post: ignore new StrictMode rule in tests.
4 years ago
3e96f6b385
For #13959 - review: add clarifying comments.
4 years ago
50959d997e
For #13959 : add marker when StrictMode is suppressed.
4 years ago
3b5d6d58d9
For #13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
66f220c22a
For #13959 : improve custom detekt violation output.
...
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
4 years ago
b222376cb0
For #13959 : add test to prevent increasing StrictMode suppression count.
4 years ago
c33aafb024
For #13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
4 years ago
4a4edeb184
For #13959 : count StrictMode suppressions on startup.
4 years ago
a5de2c0352
For #15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
5fed37cf45
Import l10n. ( #15712 )
4 years ago
ad2b99f9f9
Import l10n.
4 years ago
07748f69b7
For #15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
ec3595d4fc
For #15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
450caf1e42
Revert "No issue: remove * ac from codeowners." ( #15638 )
...
This reverts commit f3b7e294be
4 years ago
01d982d4b2
No issue: add custom lint guide to readme.
4 years ago
edcdac5402
Update Android Components version to 62.0.20201002143132.
4 years ago
01eedd159a
No issue: Update biometric, core, and recyclerview libraries
4 years ago
b696fc4c4b
For #13031 : Show size in KB for smaller downloaded files.
4 years ago
ee4a5283a4
Import l10n.
4 years ago
f3b7e294be
No issue: remove * ac from codeowners.
...
rocketsroger and I agreed this may be undesireable due to the increased
notifications. If we remove it and someone complains, we can re-add it.
4 years ago
0154c81f81
For #10107 : Show Today and Yesterday labels in History ( #15415 )
4 years ago
f690f8736d
No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
57805b82a8
No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
4 years ago
41a92a8d8b
For #15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
a19a63db19
Update Android Components version to 62.0.20201001194334.
4 years ago
a173749ad8
No issue: document list_compatible_dependency_versions script in README.
4 years ago
e74a12b442
For #15471 : Show Delete button in red in multi-select overflow menu ( #15576 )
4 years ago
97adee3bd9
Import l10n.
4 years ago
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
ced92d69d1
Issue #15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
67310061a3
For #15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
4a06e40e70
Closes #15555 : Intermittent failures in SettingsFragmentTest
4 years ago
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
4 years ago
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
cd6ab45119
Block github tagging on push-apk ( #15546 )
...
Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
4 years ago
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
4 years ago
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
4 years ago
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44#14982 .
4 years ago
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
e49cd9c558
For #15503 - Change recently closed max to 10
4 years ago
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
25f62f1c76
Extract locale settings initial state
4 years ago
acbad66f45
Add test for initial logins list state
4 years ago
f2a6aa4f25
Add tests for initial collection creation state
4 years ago
01fdb4ac3f
For #11561 - changed inactive heading and menu icon color in dark mode
4 years ago
863b135723
Import l10n.
4 years ago
3c22100b84
For #12565 : Pass bookmark storage to controller
4 years ago
bbaca06274
For #12565 : Pass metrics to share controller
4 years ago
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella
Jocelyne Abi Haidar
mozilla-l10n-automation-bot
Mozilla L10n Automation Bot
mcarare
ekager
Roger Yang
MickeyMoz
Jocelyne
Jeff Boek
Grisha Kruglov
Christian Sadilek
Stefan Arentz
Ben Hearsum
Sebastian Kaspari
Andrew Gaul
TrianguloY
Tiger Oakes
Sören Hentzschel