Commit Graph

580 Commits (48ea10cd9d62ae924757a528656265f5805019f1)

Author SHA1 Message Date
mcarare 4bebc56c50 For #9229: Remember options for delete browsing data. 4 years ago
Tiger Oakes c503798cd6 Replace PhoneFeature.getPreferenceKey 4 years ago
Tiger Oakes 596c579bbb Replace nullable findPreference 4 years ago
Tiger Oakes 45ef88f6b9 Replace requireNotNull(findPreference()) 4 years ago
Tiger Oakes 3e03439259 Add requirePreference helper 4 years ago
Sören Hentzschel 396cd61efa For #9712 - show "AC: " before AC version on "About" screen 4 years ago
Tiger Oakes 294f29768d Test logins settings 4 years ago
Sawyer Blatz 932a2f3703 For #11063: Update telemetry for etp settings 4 years ago
Elise Richards 137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
4 years ago
ValentinTimisica bc53296603 For #11365: Reorganizes 'SettingsFragment' items
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
4 years ago
ekager 6d4a673c6f For #8967 - Expose autofill logins setting in nightly 4 years ago
Tiger Oakes 1a19b06227
Simplify `PhoneFeature` code (#10810) 4 years ago
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
4 years ago
mcarare 2d24369362 For #7725: Increase info button touch target while keeping size.
Also removed unnecessary touch delegate.
4 years ago
Dennis Schubert d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
4 years ago
Tiger Oakes a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 4 years ago
Tiger Oakes 50441e28f1 Tests and cleanup for tracking protection 4 years ago
Vishwa Patel 4da22c605a For #10834 - Adding Sync Tabs Feature in Fenix 4 years ago
Sawyer Blatz 82facbfa00 For #1216: Remove feature flag for voice search 4 years ago
Jeff Boek d5c20bc0d0 For #10848 - Fixes menu background color 4 years ago
Mihai Eduard Badea 11df3aaca1 For issue#10727 - Logins auth redirect
Added an extension function that pops the backstack of the fragment so the user is redirected to the Logins and passwords screen.
This is done to force the user to re-authenticate if he wants to re-enter the saved logins flow.

Additionally, some UI elements are being hidden on each Fragment since they were remained visible on the Logins and passwords screen's UI.
4 years ago
ValentinTimisica 9f265fd62f Fixes #10064: Open help articles in normal tab instead of custom tab 4 years ago
apoorv9990 3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 4 years ago
apoorv9990 97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
4 years ago
ValentinTimisica 7974a5c77c Fixes #10815: Sort login items on initial load 4 years ago
Tiger Oakes 2397695fe5
For #10596 - Redirect moz://a URL (#10688) 4 years ago
mcarare 6e325d6242 For #6198: Update copy and position of pair QR code scan message. 4 years ago
Sawyer Blatz 535e020683 For #1216: Put voice search behind a nightly & debug flag 4 years ago
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 4 years ago
Elise Richards edc75c3ad0
Fixes #9504: Edit logins (#9693)
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe17166c3332b330229258b2e8982832672e3b.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
4 years ago
Sebastian Kaspari d58c022619 Integrate activity for showing past crashes. 4 years ago
ekager 7fe6f68e00 For #10485 - Restore block video/audio on cellular data radio button 4 years ago
ValentinTimisica 24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
4 years ago
Simon Chae a851b76ea3
Update Android Components version to 41.0.20200506130132 (#10443) 4 years ago
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
4 years ago
Arturo Mejia 56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 4 years ago
mcarare 4006501d41 For #9728: Add actionbar search for language list. 4 years ago
Falaye Iyanuoluwa c86209ff98 Closes #9694 Bug when user denies permission 4 years ago
mcarare 3c5d8d31ea For #10083: Adjust thumb offset to thumb circumference to avoid cutoff 4 years ago
ekager a9692d9bce For #10204 - Address viewLifecycleOwner IllegalStateException crashes 4 years ago
Arturo Mejia 956bf01cd5 For issue #9493: Reload after cleaning individual site permissions exceptions 4 years ago
Vlad Filippov e51e1c878b Add 'useEmail' and 'useEmailProblem' metrics event
Fixes #9834
4 years ago
mcarare 72fe52fcb8 For #9987: Set FLAG_SECURE to dialog when flag set in activity. 4 years ago
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
Arturo Mejia 0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 4 years ago
Arturo Mejia 995da59fa8 For issue #9493: Reload after cleaning all site permissions exceptions 4 years ago
ekager f3847d0d7c For #8735 - Adjust fontInflation engine setting when toggling useAutoSize 4 years ago
Mihai Adrian 72fe9fad0c
For #9987: Set FLAG_SECURE to dialog when flag set in activity. (#9998)
* For #9987: Add extension to secures dialog if parent activity is secured

* For #9987: Set FLAG_SECURE to dialog when flag set in activity
4 years ago
Mihai Branescu bded28a017
For #9420 - relaxed custom engine rules (#9967)
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
4 years ago
ekager aef827e607 For #9887 - Respect screenshot setting when resetting window flags in logins 4 years ago
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
4 years ago
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 4 years ago
ekager 5039546dc5 For #7208 For #7212 - Update parameterized strings 4 years ago
Michael Comella 4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
4 years ago
mcarare 413af92bc5 For #9797: Set min height of dialog edit text to 48dp. 4 years ago
Sawyer Blatz e94af334fc
No issue: Add more settings animations (#9750) 4 years ago
Mihai Eduard Badea d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
4 years ago
Jeff Boek c632b93ee7
For #220 - Removes feature flag for language picker (#9191)
* For #220 - Removes feature flag for language picker

* For #220 - Updates Android Components
4 years ago
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 4 years ago
Gabriel Luong dc6d479da3
For #6174 - Add telemetry for WebExtensions (#8318) 4 years ago
Grisha Kruglov 8d3d030feb Closes #9553: Only update account UI state once when creating SettingsFragment 4 years ago
Grisha Kruglov f76acc5db1 Closes #9530: Don't crash on failed avatar fetches 4 years ago
Edouard Oger 394f386ac3 Add secret debug menu to override FxA servers 4 years ago
mcarare 38a97cd1e0 For #9252: Add progress bar to saved logins view 4 years ago
mcarare f3bbcc4e17 For #9252: Update views visibility ony when list has finished loading 4 years ago
Arturo Mejia f9cc2ccfe2 For issue #8017 enable SitePermissionsWifiIntegration 4 years ago
Amaan Marfatia 3dcfed3761 AboutPageAdapter doesn't use notifyDataSetChanged()
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
4 years ago
Mihai Eduard Badea 91690d7b48 Replaced name field with search string field 4 years ago
Mihai Branescu 73a7330b2b For #9395 - Trimmed name for custom search engines 4 years ago
Arturo Mejia fa9dae0d72 For issue #9364 Crash when blocking app permissions and returning to
the app
4 years ago
Mihai Branescu ab04155222 For #8653 - changed menu strings 4 years ago
David Walsh 27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 4 years ago
Severin Rudie 35a132d7ff
8017 advanced autoplay controls. (#8978)
* For #8017: add advanced autoplay controls
4 years ago
Elise Richards 5d8a9bb4be
For #8592: Relocate device name in account preferences. Deactivate device name field while syncing. (#9255) 4 years ago
Sawyer Blatz b4e1360f59
For #3086: Adds settings animations (#9187) 4 years ago
ekager 709bf6f627 For #7087 - Add SearchView to Logins Fragment 4 years ago
ekager feb6215fae For #8296 - Adds user account avatar to Account Preference 4 years ago
ekager 667ebe3142 For #8967 - Remove ability to pref login autofilling by itself 4 years ago
Emily Kager 93cb3c2053
For #8423 - Adds delete login confirmation dialog (#9014) 4 years ago
Josh Vocal c15469595d For #7554: Add App Services Version to About Page 4 years ago
Grisha Kruglov e6e2dd94c7 Closes #7344: Login storage refactor
The a-c side of this work is in https://github.com/mozilla-mobile/android-components/pull/6128

This switches Fenix to use `SyncableLoginsStorage`, which caches a connection internally
on first access, and doesn't expose any lock/unlock APIs at the public boundary.
4 years ago
Harshal Lele e318cd7d15 fix #8135 - remove getColorFromAttr 4 years ago
Emily Kager a61502215b Revert "For #7603 - Temporarily do not show biometric prompt for OnePlus devices"
This reverts commit 17d7928cc9.
4 years ago
Mihai Adrian 9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 4 years ago
Grisha Kruglov 7275dd5269 Public API changes related to 0.52.0 A-S bump 4 years ago
Mihai Adrian beb323924b
For #8594: Show correct info in Etp settings info (#8687) 4 years ago
Severin Rudie 69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 4 years ago
Mihai Adrian 4be693255d
For #8565: Fix updating dropdown preferences in ETP settings! (#8573)
* For #8565: Create custom SharedPreferenceUpdater for String Preferences

* For #8565: Use custom updater to correctly update DropDownPreference

* For #8565: Set default values for dropDown preferences

* For 8565: add tests for findEntriesValue

* For 8565: clarified findEntryValue

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
4 years ago
Jeff Boek cbad832b19 For #8153 - Allow web-extensions to open tabs in correct browsing mode 4 years ago
Jeff Boek dfde37baf5 Reverts For #7559 - allows changing locale even after setting theme with 4 years ago
mcarare 2d72027cbd For #8534: Register preference update on first tap 4 years ago
Mihai Adrian 3486f30b6a
For #8529: Fix custom ETP preferences visibility update 4 years ago
ekager 57a02a10fc For #8514 - Use state list colors for default disabled states 4 years ago
Jeff Boek 5c6e6ddfb7 For #4807 - Always navigate to settings after deleting data 4 years ago
ekager bb85de5dca For #6737 - Set Logins checkbox default to true 4 years ago
ValentinTimisica 12ae46343e For #7957: Enable Login management preference for all users 4 years ago
mcarare 9d755a877a For #8354 Fix opening custom tabs and links directly in private mode 4 years ago
mcarare ae13f4b44f For #8354 Remove unsetting open links in private if not default browser 4 years ago
mcarare bba563b5f9 For #6479: Add granular ETP settings 4 years ago
ekager b72550c28a For #8126 - Adds default top sites 4 years ago
ekager 2e1202cbd1 For #8348 - Add small delay after biometric auth 4 years ago
Emily Kager 2264e6e1b1 For #6623 - Adds ability to delete a login 4 years ago
Jeff Boek a701988ae9 For #5905 - Creates private browsing settings fragment 4 years ago
Jeff Boek ef6913ec25 For #5905 - Combine theme and toolbar settings 4 years ago
Sebastian Kaspari f0af6d6f6e Update Mozilla Android Components to 32.0.0-SNAPSHOT. 4 years ago
Jeff Boek 952c48c8ce For #4674 - Adds ability to toggle metric services by type 4 years ago
Jeff Boek 9f3faa43fe For #4674 - Adds marketing data as a collection choice 4 years ago
Emily Kager 17d7928cc9 For #7603 - Temporarily do not show biometric prompt for OnePlus devices 4 years ago
Jeff Boek a42ad7603b For #5073 - Fixes visual alignment when certificate authority breaks into a new line 4 years ago
Jeff Boek 7a16192fd1 For #5073 - Use string parameter versus concatenating programatically 4 years ago
Kate Glazko 7c00a1ad6b For #5073: View Site Cert 4 years ago
Sawyer Blatz 0a6881d470
For #255: Removes autoplay media feature flag (#8198) 4 years ago
Jeff Boek 62d540257f For #7965 - removed unused strings, reverted changes to radiobutton widget 4 years ago
David Walsh 4b9f07c511 For #7965 - Remove CDATA strings 4 years ago
Kadeem f4f93e761e NOISSUE - Renamed a misspelled variable. 4 years ago
Tiger Oakes c0d7bc5bd5 Use navArgs helper in fragments 4 years ago
Gabriel Luong 64a4a7f422
Provide add-on support (#8064)
Closes #5630, #6069, #6092, #6091, #6124, and #6147.

Co-authored-by: Simon Chae <chaesmn@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
ValentinTimisica 0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 4 years ago
Kadeem 321251c49c Updates the hide and reveal password icons to use and tint the mozac version. 4 years ago
ValentinTimisica 2026c60136 For #6834: Adds telemetry for About page items
Didn't change the existing probe for 'whats new' item because we're already
collecting that info.
4 years ago
Mihai Branescu 2a876d5e0f For #7559 - fixes 2 issues:
- The same item now doesn't recreate the activity
- The app context now contains the right locale
4 years ago
David Walsh f728cdaf05
Bug 7189 - Provide page title in website information dialog (#7255)
* Bug 7189 - Provide page title in website information dialog

* Update QSFS test

* Fix Tiger's nits
4 years ago
Sawyer Blatz 94447657c4 No issue: Fixes strings for data migration 4 years ago
Mihai Branescu b3d99c6bba
For #7679 - Replaced comparison by reference with value, added check for default in order to avoid double checkmark (example: default + English) (#7729) 4 years ago
Sören Hentzschel 8a7c7fd06f For #7730 - always show "Add private browsing shortcut" in sett… (#7943) 4 years ago
ValentinTimisica 154e11841a Fixes #7881: Send telemetry event when custom search engine is deleted 4 years ago
Mihai Adrian 622fdadde8 For #7272: Show info when saved logins list is empty. (#7891)
* For #7272: Show info when saved logins list is empty

* For #7272: Updated unit tests
4 years ago
Emma Malysz 5e9b753acb For #7473, delay inflation of toolbar
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
4 years ago
ekager c556e819bd For #5586 - Add telemetry for save logins setting 4 years ago
Kaaira Gupta 08cce8cf58 for #7421 :removed collection from clear browsing history 4 years ago
Sebastian Kaspari 80eb19294b AboutFragment: Use SupportUtils.getWhatsNewUrl(). 4 years ago
ekager 053e5b8065 For #6396 For #6553 - Update sync engine checkboxes and send telemetry once 4 years ago
Sawyer Blatz 509fa112d0 For #6308: Remove unecessary telemetry & bump expiry date (#7793)
* For #6308: Remove unecessary telemetry

* For #6308: Bump expiry date on telemetry
4 years ago
Jeff Boek 6789df55a5 For #220 - Puts language picker behind a feature flag 4 years ago
ekager 0777fb3bbe For #5545 For #5542 Closes #6696 Integrate logins API, adds Settings for Autofilling/Saving Logins 4 years ago
ValentinTimisica 7c5c9355ce For #5884: Adds user-specified search engines telemetry
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
4 years ago
Sebastian Kaspari 6419d0cf13 Open "migration FAQ" when selecting "What's new" in a Fennec build. 4 years ago
mcarare a72620ae07 For #7522 Catch IllegalArgumentException when validating search string 4 years ago
Sawyer Blatz 718c211a86
For #1718: Sets accessibility users to top toolbar by default (#7486) 4 years ago
Rushab Kumar e6791b5c08 For #7154 - Fix crash when tapping on "Blocked" in the site info panel (#7404) 4 years ago
mcarare 2bdde48986 For #7522 Ensure correct protocol is used in search string 4 years ago
kglazko 8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings (#7478) 4 years ago
Will Hawkins 9c28cb632c Issue #7425 (et al): Cache the list of installed browsers
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
4 years ago
Mihai Branescu ea2411a88b Feature/#220 language menu (#7070)
* For #220
- Added advanced header + locale settings item in the settings fragment

* For #220
- Added locale selection page with lib state + handling of locale changes

* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For #220
- Added unit tests for locale settings page

* For #220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
4 years ago
Sawyer Blatz c7c4ad051a
For #6413: Adds more snackbar positioning logic (#7444)
* For #6413: Adds more snackbar positioning logic

* Refactor
4 years ago
Sawyer Blatz 3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415)
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
4 years ago
Emma Malysz 13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (#7246)
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
4 years ago
Josh 593981fa4b Fix parameterized message in search engine (#7302) 5 years ago
Tiger Oakes b85673acac Clean up settings fragments 5 years ago