For #5073 - Use string parameter versus concatenating programatically

4 years ago · 7a16192fd1
parent 7c00a1ad6b
commit 7a16192fd1
2 changed files with 4 additions and 3 deletions
--- a/app/src/main/java/org/mozilla/fenix/settings/quicksettings/WebsiteInfoView.kt
+++ b/app/src/main/java/org/mozilla/fenix/settings/quicksettings/WebsiteInfoView.kt
@ -51,7 +51,7 @@ class WebsiteInfoView(
    }

    private fun bindCertificateName(cert: String) {
-        val certificateLabel = view.context.getString(R.string.verified_by) + " " + cert
+        val certificateLabel = view.context.getString(R.string.certificate_info_verified_by, cert)
        view.certificateInfo.text = certificateLabel
    }

--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@ -1199,6 +1199,7 @@

    <!-- Bookmark deletion confirmation -->
    <string name="bookmark_deletion_confirmation">Are you sure you want to delete this bookmark?</string>
-    <!-- text shown before the issuer name to indicate who its verified by -->
-    <string name="verified_by">Verified By:</string>
+    <!-- text shown before the issuer name to indicate who its verified by, parameter is the name of
+     the certificate authority that verified the ticket-->
+    <string name="certificate_info_verified_by">Verified By: %1$s </string>
 </resources>