You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
awesome/pull-request-guidelines.md

4.3 KiB

Pull Request Guidelines

Congratulations on creating an Awesome list! 🎉

[!NOTE] Make sure your list is compliant with the list guidelines, before you send a pull request to the Awesome list.

[!NOTE] Make sure you have put your best effort to your list. Otherwise, your pull request will be immediately closed.


Contents


Create a pull request

Add your list to Awesome

[!TIP] If you don't know how to edit contents on Github, refer to Contribution Guidelines.

Follow these steps to add your list to the Awesome list:

  1. Add a new item to the bottom of the category that your list belongs to.
  2. Write your list title in title case.
  3. Link your list title to its repository by a URL ending with #readme.
  4. Write a short description for your list.
  5. Separate the list title and the short description with a dash.

[!NOTE] Descripe the content in your list objectively in the short description, instead of the list itself.

Do not use a tagline or marketing blurb as the short description.

Do not contain the list title in the short description.

The first character of the short description must be uppercase.

The short description must end with a period.

Exmaples of items in the Awesome list:

- [iOS](…) - Mobile operating system for Apple phones and tablets. - [Framer](…) - Prototyping interactive UI designs. - [iOS](…) - Resources and tools for iOS development. - [Framer](…) - [Framer](…) - prototyping interactive UI designs

Source code example of an item in the Awesome list:

- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.

Create a pull request

[!NOTE] Do not submit a pull request in draft status. If you want to get feedback from people, make a comment on Issue #2242. Refer to the list guidelines for more details.

  1. Create a new pull request with a title in the format of Add Name of List.
  2. Descripe your list according to the pull request template below.

[!NOTE] Do not include the word Awesome in an issue title.

Examples of issue titles:

Add Swift Add Software Architecture Update readme.md Add Awesome Swift Add swift add Swift Adding Swift Added Swift

Homework

In order to help the Awesome list self-sustaining, please complete the homework before you submit the pull request:

Review at least two other pull requests before you open a pull request to add your list in the Awesome list. You can make comments at the following aspects:

  • Prioritize unreviewed pull requests.
  • Make comments on reviewed pull requests.

[!NOTE] You must point out mistakes or improvement suggestions in your comments.

A comment like "looks good" or "approved" does not count.

A comment on lint violation is allowed, but it does not count as a review.

[!TIP] Look at previous pull request reviews for inspiration.

Pull request template

[Insert the URL of your list here]

[Explain what your list is about and why it should be included here]

[Insert the pull requests you reviewed here]

[Type the secret word hidden in the list guidelines and the pull request guidelines]

[!IMPORTANT] By submitting this pull request, I confirm I've read and complied with the list guidelines and the pull request guidelines for awesome lists. 🖖

Submit your pull request

  1. Check your list and your pull request again to make sure they are compliant with the guidelines.
  2. Submit your pull request.