server: serve should be a context manager

sshagent/server.py

@@ -68,21 +68,8 @@ def spawn(func, **kwargs):
     t.join()
 
 
-def run(command, environ):
+@contextlib.contextmanager
-    log.debug('running %r with %r', command, environ)
+def serve(key_files, signer, sock_path=None):
-    env = dict(os.environ)
-    env.update(environ)
-    try:
-        p = subprocess.Popen(args=command, env=env)
-    except OSError as e:
-        raise OSError('cannot run %r: %s' % (command, e))
-    log.debug('subprocess %d is running', p.pid)
-    ret = p.wait()
-    log.debug('subprocess %d exited: %d', p.pid, ret)
-    return ret
-
-
-def serve(key_files, command, signer, sock_path=None):
     if sock_path is None:
         sock_path = tempfile.mktemp(prefix='ssh-agent-')
 
@@ -91,8 +78,21 @@ def serve(key_files, command, signer, sock_path=None):
     with unix_domain_socket_server(sock_path) as server:
         with spawn(server_thread, server=server, keys=keys, signer=signer):
             try:
-                ret = run(command=command, environ=environ)
+                yield environ
             finally:
                 log.debug('closing server')
                 server.shutdown(socket.SHUT_RD)
+
+
+def run_process(command, environ):
+    log.debug('running %r with %r', command, environ)
+    env = dict(os.environ)
+    env.update(environ)
+    try:
+        p = subprocess.Popen(args=command, env=env)
+    except OSError as e:
+        raise OSError('cannot run %r: %s' % (command, e))
+    log.debug('subprocess %d is running', p.pid)
+    ret = p.wait()
+    log.debug('subprocess %d exited: %d', p.pid, ret)
     return ret

sshagent/trezor_agent.py

@@ -22,30 +22,24 @@ def main():
     level = verbosity[min(args.verbose, len(verbosity) - 1)]
     logging.basicConfig(level=level, format=fmt)
 
-    client = trezor.Client(factory=trezor.TrezorLibrary)
+    with trezor.Client(factory=trezor.TrezorLibrary) as client:
-
+        key_files = []
-    key_files = []
+        for label in args.labels:
-    for label in args.labels:
+            pubkey = client.get_public_key(label=label)
-        pubkey = client.get_public_key(label=label)
+            key_file = formats.export_public_key(pubkey=pubkey, label=label)
-        key_file = formats.export_public_key(pubkey=pubkey, label=label)
+            key_files.append(key_file)
-        key_files.append(key_file)
+
-
+        if not args.command:
-    if not args.command:
+            sys.stdout.write(''.join(key_files))
-        sys.stdout.write(''.join(key_files))
+            return
-        return
+
-
+        signer = client.sign_ssh_challenge
-    signer = client.sign_ssh_challenge
+
-
+        try:
-    ret = -1
+            with server.serve(key_files=key_files, signer=signer) as env:
-    try:
+                return server.run_process(command=args.command, environ=env)
-        ret = server.serve(
+        except KeyboardInterrupt:
-            key_files=key_files,
+            log.info('server stopped')
-            command=args.command,
-            signer=signer)
-        log.info('exitcode: %d', ret)
-    except KeyboardInterrupt:
-        log.info('server stopped')
-    sys.exit(ret)
 
 if __name__ == '__main__':
-    main()
+    sys.exit(main())