engineView.setDynamicToolbarMaxHeight(0) vs
engineView.setDynamicToolbarMaxHeight(toolbarHeight)
ensures webpage's bottom elements are aligned to the bottom of the browser.
We also need to make sure that when the toolbar is static it does not cover the
bottom of the page - something desired when the toolbar was dynamic.
For this the engineView will have a toolbarHeight bottom margin.
* Show dialog when permissions are denied
* Add qr permissions dialog to search dialog fragment
* Add qr permissions dialog to the pairing screen
* Show dialog after permissions have been denied
* Reset focus after denying permissions
* Show dialog after permissions denied in search frag and par frag
* Use shared preferences to store camera permission state
* Move dialog creation into the search controller and add tests
* Dialog controller implementation and test
* Route to intent with correct activity. Set focus when dismissing dialog
* Get preferences in old search
Three new settings and one for which this patch just pre-lands the strings.
The behavior for the "Swipe toolbar up to open tabs" is to be added as part of
a later ticket.
Following issues fixed in tabs tray:
* Place the tab indicator at the top for top tabs tray layout
* Disable reverse layout for compact tabs as it messes with the layout
* Make the new tab button visible in private mode in light theme
The third issue is a bug in upstream Fenix! They did not do sufficient
UI testing of the tabs tray!
Apply https://gitlab.com/relan/fennecbuild/-/blob/master/fenix-liberate.patch
at edac9bd4083644ae0b8ae04e6af719892f05ee3a
License sign-off from author "relan" in
https://gitlab.com/relan/fennecbuild/-/issues/4#note_404430753
"Note that fenix-liberate.patch is a copypaste from various projects under
Apache 2.0 and MPL 2.0. I've made only trivial changes and it makes sense to
distribute them under MPL 2.0 or Apache 2.0, not AGPL.
I think I need to add license headers to all new files added by the patch."
We can pick up additional license headers if and when they're added by relan.
Almost all the code is trivial, probably-uncopyrightable stubs.
We might be supposed to put more info in the licenses screen in the app, which
I'm keeping, for some of these, but I'm not sure how.
For "closeTabsAfterOneMonth", use the correct summary string of
"close_tabs_after_one_month" instead of "close_tabs_after_one_week".
This fixes the Settings page "Close tabs" summary showing the wrong
tab duration when "Close tabs" is set to "After one month".
Closes#14642
* Update Android Components version to 57.0.0.
* Remove feature flag for "View Downloads".
* Update search enginer list from changes by #13452
Co-authored-by: Chenxia Liu <liuche@mozilla.com>
Tweaked the layout of the tabs tray to be similar to Fennec.
Tweaks include:
* Tabs layout spans multiple columns instead of a list view
* Each tab's layout is similar to Fennec layout (large thumbnail, title on top)
* Layout adjusts on rotation of screen
* New tab (+) button is now on top, rather than using the FAB button
* Floating action button (FAB) is removed
Signed-off-by: Abhijit Valluri <avalluri2@bloomberg.net>
The two methods are serving the same purpose, with one calling the other.
This prepares the ground for adding a method to delete icons in only one place
and remove confusion about what that place should be.
Abhijit Valluri
Gabriel Luong
Mugurell
codrut.topliceanu
Elise Richards
Jeff Boek
ekager
ekager
Michael Debertol
Adam Novak
Sören Hentzschel
mcarare
Tiger Oakes
Sebastian Kaspari
bbigam
Shane Synan
Dennis Schubert
liuche
Arturo Mejia
Codrut Topliceanu
Kainalu Hagiwara