Commit Graph

1876 Commits (ab57bfd46fcca6d1b869a39da884fde1c7c18206)
 

Author SHA1 Message Date
Richard Pappalardo ab57bfd46f fix: dex error on UI test job 5 years ago
Mugurell bf5b0e5cda For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters 5 years ago
Mugurell e165868a53 For #4007 - Add ShareController for handling ShareFragment's business logic
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
5 years ago
Mugurell 16eba61b25 For #4007 - ShareFragment will set the contained Views' state
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
5 years ago
Mugurell 095870145f For #4007 - Refactor AppShareView in standalone Share Views
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
5 years ago
Mugurell 5e19741ddd For #4007 - Use camelCase for views referenced from code
As per #4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
5 years ago
Tiger Oakes fb907033bb Add comments to AuthCustomTabActivity 5 years ago
Sawyer Blatz cea18f31c4
For #3892: Fixes help link on nightly (#4956) 5 years ago
Mihai Adrian 9b911f3276 Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944)
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
5 years ago
Tiger Oakes f740d4382a Closes #773 - Add shortcuts to homescreen (#4925) 5 years ago
Colin Lee ca118033a2
Updated CODEOWNERS file to let A-C review Fenix PRs (#5013) 5 years ago
Colin Lee 66b2969077
For #4064: Old R8 & keep rules are inhibiting optimizations (#4930) 5 years ago
mihai-adrian 5e78420cce Fixes #3602:navigate to top of home screen after tapping "start browsing"
After onboarding.finish(), scrolled homeLayout to top
5 years ago
Jonathan Almeida f25a9660e8 Closes #4218: Remove forced registration renewal for push 5 years ago
Jonathan Almeida 18ca62b887 For #4063: Remove SendTab feature flags 5 years ago
Colin Lee 04f364a883
For #4631: Make sure reviewers can access a PR APK (#5004) 5 years ago
Yeon Taek Jeong d87b8a8a5c
For #4658: Add some private browsing mode telemetry (#4968) 5 years ago
Sawyer Blatz 09ed721015 For #4969: Removes erroneous FxA sign up ping (#4970) 5 years ago
Colin Lee 040a6ad7c6
For #4222: Fix another Nimbledroid upload path (#5000) 5 years ago
Yeon Taek Jeong cc5408d717
For #2053: Add persistent notification to close all private browsing tabs (#4913) 5 years ago
Johan Lorenzo de6dcd59f4 Restrict Taskcluster to collaborators on PR (#4996) 5 years ago
Michael Droettboom ad80317fc8 1577253: Remove writing dependencies to an artifact (#4999) 5 years ago
Sebastian Kaspari aa5069caca Closes #4215: CustomTabActivity: Remove attached session if activity is finishing. (#4985) 5 years ago
Emily Kager 7b5ed2673b For #4863 - Remove delay in HomeFragment onPreDraw 5 years ago
Suraj Shah 66a8c04967 Fixes #4488: Shows snackbar on bookmark deletion from edit fragment (#4792)
* Fixes #4488
Updates changelog

* Removes wildcard imports.

* Removes custom label in use, replaces with let
5 years ago
Sebastian Kaspari 8608375eac Use Mozilla Android Components 10.0.1. 5 years ago
Jonathan Almeida 681257bea7 For #4960: Initialize push only if available (#4964) 5 years ago
Mitchell Hentges 76761242f1 Fixes #4949 - raptor not being able to find APKs (#4952) 5 years ago
Afzal Najam bcabe422a6 Closes #4718 - Update site permissions layout (#4953) 5 years ago
Richard Pappalardo 60d3094410 fix: build task for UI tests (#4963) 5 years ago
Colin Lee eae97034e3
For #4897: Add back accidentally removed code coverage upload (#4958)
* For  #4897: Add back accidentally removed code coverage upload

* Make code coverage commands clearer

* Inline run_coverage as True

* Update arch label for codecov upload

* Remove variants from codecov, as they aren't used

* Remove unused format string
5 years ago
Richard Pappalardo eccd6a1bc5
fix: broken apk paths for UI test job (#4951) 5 years ago
Jeff Boek bfb2beabe7
For #4063 - Always enable the push service (#4932) 5 years ago
Tiger Oakes d1964d6536 Fixes #4771 - Add method for sessions of type (#4782)
Fixes share tabs to use the new method
5 years ago
Emily Kager 1cf8a40059 For #4295 - Adds Experiments Pref to Data Collection Settings (#4915) 5 years ago
Sebastian Kaspari c322343248 Closes #4431: Enable feature-media component for all builds. (#4898) 5 years ago
Mihai Adrian 594569164d Fixes #4211 changed SeekBar height to wrap_content to prevent misaligned dot (#4832)
Changed height from match_constrained to wrap_content.
5 years ago
Emily Kager a65f220b39 For #4921 - Adds WindowFeature to BaseBrowserFragment 5 years ago
Arturo Mejia 24f79b3263 Fix safe browsing API breaking change. (#4946) 5 years ago
Aaron Train 2bbb4c29ff
Closes #4926: Add basic UI test for regular/private tabs (#4928) 5 years ago
Sourabh 091778a4b9 For #4398 - add HistoryController (#4837) 5 years ago
Mihai Adrian 5d13c53706 Fixes #4440 changed padding for account_preference (#4830)
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
5 years ago
Amaan Marfatia dc9fdd9db3 Fixes #4067 besides snackbar (#4777)
* Fixes #4067 besides snackbar

Makes layout hierarchy more shallow to increase performance.

* Fix #4067 Feedback

Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
5 years ago
Axel Hecht 1621229a7f Import strings from android-l10n
State: mozilla-l10n/android-l10n@349efdbc8f
5 years ago
Colin Lee 86d26ce041
For #4222: Upload Fenix Nightly to Nimbledroid (#4927) 5 years ago
Colin Lee 153af588af For #4885: D8 Build failure on attempt to execute UI test (#4903)
* For #4885: D8 Build failure on attempt to execute UI test

* Disabled screengrab tests until AndroidX fix is available
5 years ago
Tiger Oakes 66e14959ba Add custom tab fragment 5 years ago
ekager ffbbe119f3 For #3967 - Invoke pending deletion on back pressed 5 years ago
ekager b07df9698a For #4868 - Update content description of tabs button with number of tabs 5 years ago
Grisha Kruglov 282c2dc182 No issue: only sync once on startup 5 years ago