There are three issues here that we have uncovered while investigating
this bug:
1. Settings.kt has a lazy block around `enabledTotalCookieProtection`
which ends up caching the first result it evaluates.
3. The `FeatureHolder` within FxNimbus caches the incorrectly
evaluated value and returns this value hence forth.
4. Nimbus is not ready to return a result for an engine experiment
when we need it early on in the dependency tree initialization.
There are multiple systems that require engine to be initialized for
them to work (e.g. Glean, Profiler, concept-fetch). In our TCP,
experiment, we need to apply these engine settings during the engine
initialization. So when we try and evaluate Nimbus that early on, it
has not had time to initialize itself correctly or even use the
engine's concept-fetch client to return the correct experiment result.
This bug is made worse because of the first two caching bugs where we
are always holding onto a cached value of the wrong result.
Our temporary solution is to:
1. Remove the `lazy` around `Settings.enabledTotalCookieProtection`.
2. Set the `FxNimbus.api` value right after we are done initializing
`FxNimbus` and `NimbusApi` so that all future queries to FxNimbus
will be made against a real instance of `NimbusApi`. This is a
short-term fix for the `FeatureHolder` caching bug.
3. Set a new TrackingProtectionPolicy that will evaluate Nimbus now
that it is in the correct state when receive the
`NimbusInterface.Observer.onUpdatesApplied`.
Co-authored-by: jhugman <jhugman@users.noreply.github.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
* Fix android:lineHeight
Change android:lineHeight to app:lineHeight for incompatibilities at API Level <= 27
* Fix android:lineHeight (Part 2)
Change android:lineHeight to app:lineHeight for fixing incompatibilities in custom_search_engine
* Change android:lineHeight (Part 3)
Change android:lineHeight to app:lineHeight in settings_https_only for incompatibilities at API Level <= 27
* cleanup lint-baseline.xml
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library
Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
This will allow for pinpoint accuracy when anchoring and resolve any color
disparities between the popup body and the indicator arrow by having everything
drawn programmatically as one shape.
Because of the async nature of the values for insets and screen rotation
immediately after an orientation change the popup will automatically get
dismissed to prevent any anchoring issues.
While not ideal the effect of this is better than accepting layout issues after
orientation changes and is the same approach used for other of our popups.
Charlie Humphreys
Mickey Moz
isabelrios
MatthewTighe
Jonathan Almeida
Roger Yang
Mozilla L10n Automation Bot
rxu
Noah Bond
MickeyMoz
rudmannn
Jan-Erik Rediger
Alexandru2909
Mugurell
indu
AndiAJ
KNS
Christian Sadilek
Arturo Mejia