Commit Graph

402 Commits (48ea10cd9d62ae924757a528656265f5805019f1)

Author SHA1 Message Date
Andrey Mukamolov ccfaa3826b For #2142: Added accessibility focus 5 years ago
Andrey Mukamolov d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 5 years ago
Sawyer Blatz 13198f56df For #969: Adds telemetry for collections (#3935) 5 years ago
Sebastian Kaspari f8ef0225e1 Use updated feature-tab-collections API. (#4056) 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 5 years ago
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 5 years ago
Colin Lee 5a204f0bbc
For #3818: Handle crashes accessing view after onDestroyView (#3942) 5 years ago
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 5 years ago
Colin Lee f375eac6bd
For #3732: Race Condition Crash in HomeFragment onPreDraw (#3737) 5 years ago
Sawyer Blatz 13df8d7ddd
For #3711: Fixes save to collection from browser crash (#3714) 5 years ago
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
5 years ago
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 5 years ago
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 5 years ago
Emily Kager ddebc98718 No issue: Follow up on optional filter style 5 years ago
Emily Kager 718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 5 years ago
Sawyer Blatz 07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 5 years ago
Mihai Tabara ccc5b91992 Import PR 3500 from ekager 5 years ago
Stefan Arentz 6e6e662c47 Update HomeFragment.kt 5 years ago
Jeff Boek 90bdbd04e0 No Issue - Capture session manager in scope before creating the delete operation 5 years ago
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 5 years ago
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 5 years ago
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 5 years ago
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 5 years ago
Sawyer Blatz 041eaa2a5c
For #3275: Cleans up feedback from James (#3398) 5 years ago
Emily Kager 1f1320920f For #3275 - Invoke pending single session delete job on close all (#3438) 5 years ago
Emily Kager 510b6f7373 For #2899 - Improve collections scroll and highlight animations 5 years ago
Emily Kager 186983b786 For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls (#3393) 5 years ago
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 5 years ago
Gabriel Luong f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 5 years ago
Emily Kager 82cf81242f For #3331 - Delay restoring layout while list restores (#3354) 5 years ago
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 5 years ago
Emily Kager e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
5 years ago
Sawyer Blatz ab000d2e51
For #3280: Revert "For #3215: Restores collections properly" (#3320)
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
5 years ago
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
5 years ago
Emily Kager 7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 5 years ago
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 5 years ago
Emily Kager acea0d5668 For #2785 - Adds back item animator session control (#3233) 5 years ago
Sawyer Blatz 8537ff10a8 For #3215: Restores collections properly (#3219) 5 years ago
Emily Kager 4954aadd84 For #3156 - If only one tab adding to collection make it selected (#3222) 5 years ago
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 5 years ago
Emily Kager 14c581c012 For #3004 - Do not restore motionlayout state in ReloadData 5 years ago
ekager 87f6268816 For #3101 - Do not show tab selection screen for 1 tab 5 years ago
ekager 388581f76f For #3056 - Filter sessions on invoke for pending delete all job 5 years ago
Emily Kager d5a9627273 For #2941 - Remove Delete Dialog, Theme Dialogs (#3052) 5 years ago
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 5 years ago
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 5 years ago
Emily Kager 4c970a545d For #2230 - Fix theme selection radio button for Android 6 (#3019) 5 years ago
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 5 years ago
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 5 years ago
Emily Kager caa36c31cd For #2979 - Prevent double navigation to Create Collection Fragment 5 years ago
Grisha Kruglov 5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
Emily Kager e61cebf38d No issue: Check search engine icon exists before setting drawable 5 years ago
Denys M 8bed44819d Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`. 5 years ago
Emily Kager d6c1f65d72 Start MotionLayout animation to end while navigating to search fragment 5 years ago
ekager dee3c059dc Adds Shared Transition between Home and Search 5 years ago
Sawyer Blatz 6a53127ef9 For #2948: Adds menu button add tab to collection 5 years ago
Jonathan Almeida 3da6cfd98a For #2886: Fix sending multiple tabs to another device (#2923)
* For #2886: Fix sending multiple tabs to another device

* Update share methods to use new API
5 years ago
Emily Kager 506f332b85 For #2919 - Invoke Pending Delete Jobs in onPause 5 years ago
Emily Kager 7d65e21b83 For #2941 - Creates delete dialog style 5 years ago
Emily Kager 250548a72f For #2823 - Invoke pending jobs with context on switch to private mode 5 years ago
Tiger Oakes 207a8d6772 Use a ListAdapter for SessionControl 5 years ago
Emily Kager 4e13de3ffd No issue: Register observers with owner view 5 years ago
Emily Kager f51e221a99 Remove unused import 5 years ago
Emily Kager 895ba021e7 Hide toolbar in activity and remove label from home fragment 5 years ago
Emily Kager c7af502db7 Restore progress 5 years ago
ekager 0e64ead75c Try to pop up to home if it exists on stack from browserfragment 5 years ago
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 5 years ago
Sawyer Blatz 832fd71afc For #2784: Removes undo from collection deletion (#2786) 5 years ago
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
5 years ago
Jeff Boek bf28462c47 For #2717 - Hides onboarding card when signed into a firefox account 5 years ago
Grisha Kruglov f4f35bdde0 Closes #2713: Weave in "onboarding state" and split adapter items accordingly
we're ensuring that it has been initialized.

I wonder if we could just make background services load eagerly (they're lazy init now), instead.
5 years ago
Sawyer Blatz a1d32127ab For #2655: Adds undo snackbar for closing all tabs 5 years ago
Jeff Boek 5ec783f6e5 For #2719 - Fixes crash by registering to observer with a lifecycle owner 5 years ago
Sawyer Blatz e7ecd49353 For #1578: Adds delete collection with undo 5 years ago
Emily Kager 394a207fea Revert "For #1578: Adds delete collection with undo"
This reverts commit 63a4567521.
5 years ago
Sawyer Blatz 63a4567521 For #1578: Adds delete collection with undo 5 years ago
Sawyer Blatz 93d0982a6f For #1576: Adds tab collection renaming 5 years ago
Emily Kager 0c022f6646 For #1826 - Create ViewModel for Restoring Home Scroll Position 5 years ago
Emily Kager 4b186eb86d No issue: Save/Restore State in HomeFragment 5 years ago
Sawyer Blatz 0080e7d701 For #2584: Adds opening a single tab from tab collection 5 years ago
Sawyer Blatz a3f25b9f77 For #2584: Adds opening tab collections 5 years ago
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 5 years ago
Sawyer Blatz 7e7edc8b7a For #2377: Adds share to tabs and tab collections 5 years ago
Jeff Boek 1cd50ba9cb No Issue - Fixes nits in #2669 5 years ago
Jeff Boek a041d9ef74 For #2391 - Dismiss tour when navigating to search or settings 5 years ago
Jeff Boek 479c00bc5f No Issue - Always complete motionLayout transition on restore 5 years ago
Jeff Boek 9a76c11dae For #2389 - Save state on homeview when switching themes 5 years ago
Emily Kager ba790c5dd3 No issue: remove unused restore state code 5 years ago
Sawyer Blatz 3619f1417d For #1574: Cleans up unused code and refactors 5 years ago
Sawyer Blatz 4e6f9b9ef1 For #1574: Displays previous tab collections when creating 5 years ago
Sawyer Blatz 30a643720f For #1574: Adds tab collection creation 5 years ago
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
5 years ago
Jeff Boek 95af2ddcc6 For #2390 - Adds the start browser button 5 years ago
Jeff Boek dfe14e1751 For #2390 - Adds the onboarding welcome message 5 years ago
Jeff Boek b14d0fa80c For #2390 - Applies onboarding mode on start 5 years ago
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
5 years ago
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
Colin Lee 917399d897
For #2436: TransactionTooLargeException saving many tabs (#2453) 5 years ago
Colin Lee 155353f0ee
For #2449: App crashes when switching themes (#2450) 5 years ago
Emily Kager 4070941657 No issue: Refactor dialogs to use nav graph 5 years ago
Colin Lee cfccb997fd For #1909: Tabs disappear intermittently (#2426) 5 years ago
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 5 years ago
Emily Kager eb4e159101 For #2329 , For #2332: Invoke pending delete session job on navigate (#2333) 5 years ago
Emily Kager 37bae3bb38 For #2289 - Null out pending job on undo (#2303) 5 years ago
Sawyer Blatz 7d577e5953
For #2205: Adds collections view to home fragment (#2249)
* For #1574: Adds collections to home view

* Adds colored icons and expansion

* Adds state change

* Adds more styling

* Adds ItsNotBrokenSnacks

* Adds chevron

* Improves styling of swipe to delete and adds delete action

* Fix nits

* Try to add real saving
5 years ago
Emily Kager 0000d6a782 For #2277 - Clean up threading for session control with undo (#2281) 5 years ago
Emily Kager e5e448ac8f For #1694 - Show Snackbar with Undo When Tab is Closed (#2246) 5 years ago
Emily Kager 73de0cd2e8 Closes #2239 - emit session changes in onstart (#2240) 5 years ago
Emily Kager 8fd937669b Closes #2182 - Do not invoke sessionmanager callbacks (#2236) 5 years ago
Emily Kager 2953b54a84 For #1573 - Polish Collections UI Component (#2212)
* Adds Keyboard resuming, Snackbar verification, layout edits to collections

Adds Keyboard resuming, Snackbar verification, layout edits to collections

* Adds new strings for collections/tabs management

* Adds constraintsets, hides checkboxes, adds scrim

* Update strings to plurals
5 years ago
Will Hawkins 0bcff089d6 Feature #2088: Async load the default search engine icon at startup (#2113) 5 years ago
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 5 years ago
Emily Kager 0e44921e08 For #1573 - Update tabs header menu (#2141) 5 years ago
Emily Kager 1041500869 For #1573 - Long pressing tab selects that tab in save collections 5 years ago
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 5 years ago
Jeff Boek d39c15402e For #1843 - Adds a better theme for the creation fragment 5 years ago
Jeff Boek ba90b58d32 For #1843 - Displays tabs on the tab selection screen 5 years ago
Jeff Boek 63574cc359 For #1843 - Adds a create collections fragment and navigates to it 5 years ago
Sawyer Blatz e2198f19ad
Fixes #1868: Corrects private browsing myths link (#1930) 5 years ago
Emily Kager 534d88f629 Closes #1894 - Fixes Help Page Navigation 5 years ago
Jeff Boek f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
For #1840 - Adds a save tab group button and puts it behind a feature  flag
5 years ago
Jeff Boek 4ea54252b0 For #1830 - Adds the ability to share a tab 5 years ago
Jeff Boek 774c5c0e0c For #1830 - Updates the tab visual style 5 years ago
Jeff Boek 5ca9040702 For #1696 - Removes sessions from session control 5 years ago
Jeff Boek 6183e82264 For #1696 - Removes sessions from the bottomsheetfragment 5 years ago
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 5 years ago
Colin Lee bc1b7e0b43 For #1539: Add bookmark multi-select features 5 years ago
Jeff Boek e98db8bfb8 For #1430 - Adds a changelog entry 5 years ago
Jeff Boek 5acd386ecd For #1430 - Handle more text in a more graceful way 5 years ago
Jeff Boek b306bc502a For #1430 - Adjust snackbar colors for darkmode 5 years ago
Jeff Boek 9434f01b42 Fixes #1204 - Fixes the home screen animation 5 years ago
Jeff Boek e34d163034 Combines the Tab and Session component 5 years ago
Jeff Boek 4a385068e0 Updates ConstraintLayout to alpha4 5 years ago
Jeff Boek 756634bc6c For #1181 - Use appName in string locations 5 years ago
Jeff Boek 786592e8d0 For #959 - Adds telemetry for when the search bar is tapped 5 years ago
Colin Lee df40ec970e Simplify ItsNotBrokenSnack() and make resilient
Co-authored by: Emily Kager <ekager@mozilla.com>
5 years ago
Emily Kager 4963f7ccdb Add Snackbar to link testers to Github issue for features 5 years ago
Emily Kager bb3ebbdbe2 Closes #932 - Home Page UI polish 5 years ago
Colin Lee 0ac3e5369d Fixes #1050: Fenix sessions save and close upon opening 5 years ago
Colin Lee 6e1655e935 Fix #1032: Crash altering sessions DB on main thread 5 years ago
Sawyer Blatz 463ab8bf79 No issue: Fixes compilation errors with a-c 47.0 5 years ago
Emily Kager 8d442c062d Closes #884 - Set and use default search engine 5 years ago
Jeff Boek 79395631d7 Fixes #870 - Fixes logic for the session bottom sheet fragment for private mode
Also fixes #871
5 years ago
Sawyer Blatz b1d0233b04 Closes #814: Scrolls to top after session restore 5 years ago
Sawyer Blatz d6ebd88186
Closes #804: Adds disable private browsing content description (#851) 5 years ago
Emily Kager d15e4bb3fa Closes #877 - Add Search Engine Settings 5 years ago
Sawyer Blatz a79134fdc3
Closes #823 & Closes #835: Refactors openToBrowserAndLoad to include fromFragment (#833) 5 years ago
Emily Kager 58b32e944b Revert "Closes #811 - Clear stack after switching to private browsing" (#876)
This reverts commit 8b793cd43e.
5 years ago
Emily Kager 8b793cd43e Closes #811 - Clear stack after switching to private browsing 5 years ago
Jeff Boek d413b7228f Fixes compiler error for new version of A-C 5 years ago
Colin Lee 9d3ef76929 For #747: Fix memory leak with HomeMenu 5 years ago
Jeff Boek 27c5570b43 For #673 - Dismiss bottom sheet on archive. Remove boolean logic 5 years ago
Jeff Boek e05f0894e8 For #673 - Modifies Session Bottom Sheet to work for current and archived sessions 5 years ago
Jeff Boek 22c915b5a4 For #673 - Trigger session overflow menu on session item menu 5 years ago
Jeff Boek 1aa3d7e1ad For #673 - Pulls out the session overflow action 5 years ago
Sawyer Blatz e9e74122b5 Closes #736 & Closes #722: Adds delete session button to private browsing 5 years ago
Jeff Boek 77189a00a0 Fixes #741 - Dont show the current session in the previous session list 5 years ago
Sawyer Blatz 84a2b24554 Closes #510: Adds private browsing myths SUMO link 5 years ago
Jeff Boek 1d4be1b665 For #633 - Remove only normal sessions, add a11y for glyphs 5 years ago
Jeff Boek 416382c3ad For #633 - Gives the user the ability to save their session 5 years ago
Jeff Boek 000d5a2e54 Fixes #672 - Moves private browsing description out of sessions 5 years ago
Sawyer Blatz 57a0d97114 Fixes #678: Hides sessionsComponent in private mode 5 years ago
Jeff Boek d5aeec417b For #636 - Allow a user to delete a session 5 years ago
Jeff Boek 2ac2f9a9da For #635 - Restores a session 5 years ago
Jeff Boek 8379c3d2cb For #631 - Puts tabs and sessions into a nested scrollview 5 years ago
Jeff Boek d62d41b46a For #631 - Passes data into the sessions component and render a list 5 years ago
Emily Kager 5b8d40e6e0 Closes #655 - Show/Hide toolbar in onResume 5 years ago
Sawyer Blatz 53f391de60
Closes #537: Refactors private sessions (#629) 5 years ago
Colin Lee 291f21aa8e Handle listener state bugs as onViewCreated isn't always called 5 years ago
Colin Lee b42a512b87 Fixes #557: Selected tab should appear with selected theme 5 years ago
Colin Lee 6d71faa44d Fixes #541: Crash on Home Screen
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
5 years ago
Sawyer Blatz e5fe80f928
Closes #347: Adds private browsing logic (#506)
* For #347: Adds private browsing logic

*  For #347: Adds private session explainer

* Adds persistence
5 years ago
Colin Lee ee229c9709 Fixes #354: Overflow menu for multitasking in current session 5 years ago
Jeff Boek 5addcca524 For #456 - Adds popover menu to menu button 5 years ago
Jeff Boek df3eaa2ca7 For #456 - Moves out KeyTrigger into its own file 5 years ago
Colin Lee 83f637e386 Fixes #431: Scroll-down on the home screen messes up everything 5 years ago
Sawyer Blatz d543d776b1 Closes #438: Adds dynamic nav bar color 5 years ago
Colin Lee f09dc2453f Fixes #351 Create home screen component for multitasking 5 years ago
Emily Kager 77883c0f30 Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity 5 years ago
Sawyer Blatz d09dc149ed
Closes #363 & Closes #364: Adds private browsing theme (#405)
* For #345 #346 - Adds private browsing theme

Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>

* Abstracts theme management

* Theme browser toolbar

* Remove unused imports

* Begin work on sharedPreferences

* fix lint

* #346 - Refactors ThemeManager to take a callback

* Adds clean status bar and nav bar

* lint

* Themes settings icons better

* Small clean up
5 years ago
Jeff Boek 88a54b7b30 Fixes #362 - Downgrade to ConstraintLayout 2.0.0-alpha2
There is currently an issue with visibility changes in ConstraintLayout 2.0.0-alpha3
https://issuetracker.google.com/issues/122090772
For now we're going to manually implement KeyTriggers.
5 years ago
Emily Kager 8368f4fbb2 Part of #288 - Set up basic settings menu 5 years ago
Colin Lee 273f33b244 Fixes #290: Integrate new Fenix architecture 5 years ago
Colin Lee b2b6a530d0 Make ktlint and detekt style changes 5 years ago
Colin Lee e7ebd712c6 Fix MotionLayout animation the proper way 5 years ago
Jeff Boek ebb5da7f4e For #141 - Cleans up search UI 5 years ago
Jeff Boek 0e9c77b036 Cleans up animation between search bar states 5 years ago
Jeff Boek 9e76498eed Cleans up the elevation transition for the search bar on the homescreen 5 years ago
Jeff Boek 3079af1d36 Adds search engine icon to searchbar 5 years ago
Colin Lee 69e9617272 Fixes #127: Add architecture classes 5 years ago
Jeff Boek 4179a8ff78 For #139 - Adds the sessions placeholder 5 years ago
Jeff Boek 38431dac41 Hides icons that arent currently used 5 years ago
Jeff Boek 480ae93a72 For #141 - Adds autocomplete ot the search screen
- Adds convenience extensions to Context and Fragment
- Imports more components from Android Components
5 years ago
Emily Kager 19572d474a Closes #134 - Collapse/show the toolbar based on browser scrolling 5 years ago
Jeff Boek 4c4f344a97 For #131 - Loads mozilla.org in the browser fragment 5 years ago
Emily Kager 4421adecbb Implement Navigation, Add Search Fragment, Add Browser Fragment 5 years ago
Jeff Boek cefa12224f Fixes nits in mozilla-mobile/fenix#158 5 years ago
Jeff Boek a800d33620 For #139 - Adds session placeholder with motionlayout 5 years ago
Jeff Boek da939bba50 For #150 - Adds more style to the urlbar 5 years ago
Jeff Boek 3378ee4209 For #150 - Adds the search bar 5 years ago
Jeff Boek c1500fe0bc For #150 - Adds a home fragment 5 years ago