Commit Graph

402 Commits (48ea10cd9d62ae924757a528656265f5805019f1)

Author SHA1 Message Date
Prat T 80a1e6dd2c Fixes #5351 - listen to onIconChanged in HomeFragment 5 years ago
Emily Kager 40e6284aef For #5442 - Show Delete Browsing Data on Quit option in home menu 5 years ago
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
5 years ago
Sawyer Blatz b6e6e36ccd For #561: Fix stutter of search icon & text when animating 5 years ago
Jeff Boek c592a69aad For #561 - Fixes snackbar placement on homeview 5 years ago
Jeff Boek 5c092c1ef1 For #561 - Adds shadow/highlightto the bottom bar 5 years ago
Jeff Boek 00d1be97ac For #561 - Wires up add tab button inside the bottom bar 5 years ago
Jeff Boek b16754d78a For #561 - Adds add tab and menu button to bottom bar
- Adds space between wordmark and session control component
5 years ago
Jeff Boek abbb310ce3 For #561 - Removes the toolbar from the home screen
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
5 years ago
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
5 years ago
Tiger Oakes cb7701584f No issue: Extract home fragment mode (#5343) 5 years ago
Mihai Adrian a1c8fc0698 For #3731 Improved UX for opening tabs from a Collection (#5427)
* For #3731 Changed order of items for a collection's overflow menu

* For #3731 Changed the order tabs open to keep same order from collections
5 years ago
Tiger Oakes 106458c2c9 For #3440 - Reduce HomeFragment require calls 5 years ago
Yeon Taek Jeong ddc1b2e648 For #4658: Add private browsing mode shortcut telemetry 5 years ago
Sawyer Blatz 999d3cb963 For #1114: Show playing tab 5 years ago
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 5 years ago
Sawyer Blatz 53b3f105ca For #4155: Sets pastedText default value 5 years ago
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 5 years ago
Sawyer Blatz f7dde41b3b For #5021: Adds telemetry for what's new button 5 years ago
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 5 years ago
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
5 years ago
Petru Lingurar f7087e46e3 Fix #5067 - Refactor ShareController to use SendTabUseCases
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
5 years ago
Christian Sadilek 4cf03be236 For #2088: Use new async API to load default search engine in HomeFragment 5 years ago
mihai-adrian 5e78420cce Fixes #3602:navigate to top of home screen after tapping "start browsing"
After onboarding.finish(), scrolled homeLayout to top
5 years ago
Yeon Taek Jeong d87b8a8a5c
For #4658: Add some private browsing mode telemetry (#4968) 5 years ago
Tiger Oakes d1964d6536 Fixes #4771 - Add method for sessions of type (#4782)
Fixes share tabs to use the new method
5 years ago
Emily Kager 84b0693fd2 For #4652 : Use workaround for HomeScreenViewModel (#4887) 5 years ago
Jeff Boek 68f5d211d3 For #4326 - Updates codebase to support latest version of detekt 5 years ago
Yeon Taek Jeong 6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 5 years ago
(´⌣`ʃƪ) c076cc85f9 For #4436: Dismiss onboarding before navigating away from home (#4801) 5 years ago
Tiger Oakes ac6c1ec2ee Closes #2690 - Clean up CreateCollection viewmodel (#4731) 5 years ago
Tiger Oakes ad98b2f3ea For #4744 - Extract private browsing button (#4813) 5 years ago
Mugurell ab6e7dc52b Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.

`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
5 years ago
Tiger Oakes b8c93107c0 For #4744 - Extract TransitionPreDrawListener (#4812) 5 years ago
Tiger Oakes a632d8f1dc For #4744 - Move search bar icon padding to dimens (#4814) 5 years ago
Yeon Taek Jeong d4c83f9668 For #4736: Display search shortcuts only from home or search widget 5 years ago
Sourabh 42e3b2771e fix #4633: show toast only on first login (#4676)
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
(´⌣`ʃƪ) 5aac05859d Fix #4436: hide onboarding before navigating to settings (#4675)
* Fix #4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
Colin Lee 0c8bcd39be For #4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 5 years ago
Tiger Oakes 52542708aa Consodilate private browsing code 5 years ago
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz 4566bd6fba Fixes feedback 5 years ago
Sawyer Blatz 9d65e665e5 No issue: Removes deprecated usage of ViewModelProviders 5 years ago
Sawyer Blatz 969d17b4a9
For #969: Adds more telemetry for collections (#4539) 5 years ago
ekager d0071d0177 For #4495 - Clean up homescreen toolbar focus and content descriptions 5 years ago
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 5 years ago
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 5 years ago
Sawyer Blatz 2e7a61860a For #969: Adds more telemetry for collections (#4358) 5 years ago
Tiger Oakes 87d8f3b037 Remove redundant super calls 5 years ago
Andrey Mukamolov ccfaa3826b For #2142: Added accessibility focus 5 years ago
Andrey Mukamolov d5eeadda66 Closes #2142: Enable private browsing button is focused instead of Search or address 5 years ago
Sawyer Blatz 13198f56df For #969: Adds telemetry for collections (#3935) 5 years ago
Sebastian Kaspari f8ef0225e1 Use updated feature-tab-collections API. (#4056) 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 5 years ago
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 5 years ago
Colin Lee 5a204f0bbc
For #3818: Handle crashes accessing view after onDestroyView (#3942) 5 years ago
Sawyer Blatz 7e46e71d00 For #3005: Closes tabs when saving to collection (#3723) 5 years ago
Colin Lee f375eac6bd
For #3732: Race Condition Crash in HomeFragment onPreDraw (#3737) 5 years ago
Sawyer Blatz 13df8d7ddd
For #3711: Fixes save to collection from browser crash (#3714) 5 years ago
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
5 years ago
Tiger Oakes 4994554576 No issue: Adds lint exception for when statement (#3685) 5 years ago
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 5 years ago
Emily Kager ddebc98718 No issue: Follow up on optional filter style 5 years ago
Emily Kager 718ac5612c For #3593 For #3581 - Pass sessions to delete to delete all with undo (#3594) 5 years ago
Sawyer Blatz 07516f47c3
For #3215: Adds collection restoration with unique IDs (#3635) 5 years ago
Mihai Tabara ccc5b91992 Import PR 3500 from ekager 5 years ago
Stefan Arentz 6e6e662c47 Update HomeFragment.kt 5 years ago
Jeff Boek 90bdbd04e0 No Issue - Capture session manager in scope before creating the delete operation 5 years ago
Jeff Boek 7ebdfcc87b For #1116 - Uses alias link for help 5 years ago
Jeff Boek 5540230e3d For #1116 - Changes help link (#3491) 5 years ago
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 5 years ago
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 5 years ago
Sawyer Blatz 041eaa2a5c
For #3275: Cleans up feedback from James (#3398) 5 years ago
Emily Kager 1f1320920f For #3275 - Invoke pending single session delete job on close all (#3438) 5 years ago
Emily Kager 510b6f7373 For #2899 - Improve collections scroll and highlight animations 5 years ago
Emily Kager 186983b786 For #3275 - Adds PendingSessionDeletion data class to handle multiple emit session calls (#3393) 5 years ago
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 5 years ago
Gabriel Luong f05eb032d4 For #2684: Add an extension function Session.toTab to map Session to Tab and clean up their usage 5 years ago
Emily Kager 82cf81242f For #3331 - Delay restoring layout while list restores (#3354) 5 years ago
Sawyer Blatz decacbfc97 For #3323 Runs PublicSuffixList synchronously 5 years ago
Emily Kager e57e7b50ee For #2899 - Scroll to Collections on change, animate new collections (#3279)
* For #2899 - Scroll to Collections on change, animate new collections

* For #2899 - Scroll to tabs when tabs opened from collection
5 years ago
Sawyer Blatz ab000d2e51
For #3280: Revert "For #3215: Restores collections properly" (#3320)
This reverts commit 3e9ee79c00f4a6b34af74ce7c179e0cbe37decf5.
5 years ago
Sawyer Blatz 45c509fbce
For #2648: Updates trimming of url hostname (#3191)
* For #2648: Updates trimming of url hostname

* For #2648: Fix nits
5 years ago
Emily Kager 7368a95d29 No issue: Sets up observers for tab collection changes (#3248) 5 years ago
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 5 years ago
Emily Kager acea0d5668 For #2785 - Adds back item animator session control (#3233) 5 years ago
Sawyer Blatz 8537ff10a8 For #3215: Restores collections properly (#3219) 5 years ago
Emily Kager 4954aadd84 For #3156 - If only one tab adding to collection make it selected (#3222) 5 years ago
Emily Kager 704f1e6a3d For #3004 - Restore MotionLayout on Home View only in onCreateView 5 years ago
Emily Kager 14c581c012 For #3004 - Do not restore motionlayout state in ReloadData 5 years ago
ekager 87f6268816 For #3101 - Do not show tab selection screen for 1 tab 5 years ago
ekager 388581f76f For #3056 - Filter sessions on invoke for pending delete all job 5 years ago
Emily Kager d5a9627273 For #2941 - Remove Delete Dialog, Theme Dialogs (#3052) 5 years ago
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 5 years ago
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 5 years ago
Emily Kager 4c970a545d For #2230 - Fix theme selection radio button for Android 6 (#3019) 5 years ago
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 5 years ago
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 5 years ago
Emily Kager caa36c31cd For #2979 - Prevent double navigation to Create Collection Fragment 5 years ago
Grisha Kruglov 5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
Emily Kager e61cebf38d No issue: Check search engine icon exists before setting drawable 5 years ago
Denys M 8bed44819d Fixes #2254/#2709. Observe browser sessions changes on `HomeFragment`. 5 years ago
Emily Kager d6c1f65d72 Start MotionLayout animation to end while navigating to search fragment 5 years ago
ekager dee3c059dc Adds Shared Transition between Home and Search 5 years ago
Sawyer Blatz 6a53127ef9 For #2948: Adds menu button add tab to collection 5 years ago
Jonathan Almeida 3da6cfd98a For #2886: Fix sending multiple tabs to another device (#2923)
* For #2886: Fix sending multiple tabs to another device

* Update share methods to use new API
5 years ago
Emily Kager 506f332b85 For #2919 - Invoke Pending Delete Jobs in onPause 5 years ago
Emily Kager 7d65e21b83 For #2941 - Creates delete dialog style 5 years ago
Emily Kager 250548a72f For #2823 - Invoke pending jobs with context on switch to private mode 5 years ago
Tiger Oakes 207a8d6772 Use a ListAdapter for SessionControl 5 years ago
Emily Kager 4e13de3ffd No issue: Register observers with owner view 5 years ago
Emily Kager f51e221a99 Remove unused import 5 years ago
Emily Kager 895ba021e7 Hide toolbar in activity and remove label from home fragment 5 years ago
Emily Kager c7af502db7 Restore progress 5 years ago
ekager 0e64ead75c Try to pop up to home if it exists on stack from browserfragment 5 years ago
Emily Kager 40f2fe5166 For #1287 - Create animation for opening and closing tab from home 5 years ago
Sawyer Blatz 832fd71afc For #2784: Removes undo from collection deletion (#2786) 5 years ago
Jonathan Almeida eb7646f073 Add custom share sheet and send tab support (#2757)
* Closes #2751: Add custom app share sheet

* Closes #2753: Add send tab devices to share sheet

* Closes #2752: Add build flag for send tab

* Replace Context.share with ShareFragment
5 years ago
Jeff Boek bf28462c47 For #2717 - Hides onboarding card when signed into a firefox account 5 years ago
Grisha Kruglov f4f35bdde0 Closes #2713: Weave in "onboarding state" and split adapter items accordingly
we're ensuring that it has been initialized.

I wonder if we could just make background services load eagerly (they're lazy init now), instead.
5 years ago
Sawyer Blatz a1d32127ab For #2655: Adds undo snackbar for closing all tabs 5 years ago
Jeff Boek 5ec783f6e5 For #2719 - Fixes crash by registering to observer with a lifecycle owner 5 years ago
Sawyer Blatz e7ecd49353 For #1578: Adds delete collection with undo 5 years ago
Emily Kager 394a207fea Revert "For #1578: Adds delete collection with undo"
This reverts commit 63a4567521.
5 years ago
Sawyer Blatz 63a4567521 For #1578: Adds delete collection with undo 5 years ago
Sawyer Blatz 93d0982a6f For #1576: Adds tab collection renaming 5 years ago
Emily Kager 0c022f6646 For #1826 - Create ViewModel for Restoring Home Scroll Position 5 years ago
Emily Kager 4b186eb86d No issue: Save/Restore State in HomeFragment 5 years ago
Sawyer Blatz 0080e7d701 For #2584: Adds opening a single tab from tab collection 5 years ago
Sawyer Blatz a3f25b9f77 For #2584: Adds opening tab collections 5 years ago
Sawyer Blatz afbe397f94 For #1575: Enables adding tabs to existing collection 5 years ago
Sawyer Blatz 7e7edc8b7a For #2377: Adds share to tabs and tab collections 5 years ago
Jeff Boek 1cd50ba9cb No Issue - Fixes nits in #2669 5 years ago
Jeff Boek a041d9ef74 For #2391 - Dismiss tour when navigating to search or settings 5 years ago
Jeff Boek 479c00bc5f No Issue - Always complete motionLayout transition on restore 5 years ago
Jeff Boek 9a76c11dae For #2389 - Save state on homeview when switching themes 5 years ago
Emily Kager ba790c5dd3 No issue: remove unused restore state code 5 years ago
Sawyer Blatz 3619f1417d For #1574: Cleans up unused code and refactors 5 years ago
Sawyer Blatz 4e6f9b9ef1 For #1574: Displays previous tab collections when creating 5 years ago
Sawyer Blatz 30a643720f For #1574: Adds tab collection creation 5 years ago
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
5 years ago
Jeff Boek 95af2ddcc6 For #2390 - Adds the start browser button 5 years ago
Jeff Boek dfe14e1751 For #2390 - Adds the onboarding welcome message 5 years ago
Jeff Boek b14d0fa80c For #2390 - Applies onboarding mode on start 5 years ago
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
5 years ago
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
Colin Lee 917399d897
For #2436: TransactionTooLargeException saving many tabs (#2453) 5 years ago
Colin Lee 155353f0ee
For #2449: App crashes when switching themes (#2450) 5 years ago
Emily Kager 4070941657 No issue: Refactor dialogs to use nav graph 5 years ago
Colin Lee cfccb997fd For #1909: Tabs disappear intermittently (#2426) 5 years ago
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 5 years ago
Emily Kager eb4e159101 For #2329 , For #2332: Invoke pending delete session job on navigate (#2333) 5 years ago
Emily Kager 37bae3bb38 For #2289 - Null out pending job on undo (#2303) 5 years ago
Sawyer Blatz 7d577e5953
For #2205: Adds collections view to home fragment (#2249)
* For #1574: Adds collections to home view

* Adds colored icons and expansion

* Adds state change

* Adds more styling

* Adds ItsNotBrokenSnacks

* Adds chevron

* Improves styling of swipe to delete and adds delete action

* Fix nits

* Try to add real saving
5 years ago
Emily Kager 0000d6a782 For #2277 - Clean up threading for session control with undo (#2281) 5 years ago
Emily Kager e5e448ac8f For #1694 - Show Snackbar with Undo When Tab is Closed (#2246) 5 years ago
Emily Kager 73de0cd2e8 Closes #2239 - emit session changes in onstart (#2240) 5 years ago
Emily Kager 8fd937669b Closes #2182 - Do not invoke sessionmanager callbacks (#2236) 5 years ago
Emily Kager 2953b54a84 For #1573 - Polish Collections UI Component (#2212)
* Adds Keyboard resuming, Snackbar verification, layout edits to collections

Adds Keyboard resuming, Snackbar verification, layout edits to collections

* Adds new strings for collections/tabs management

* Adds constraintsets, hides checkboxes, adds scrim

* Update strings to plurals
5 years ago
Will Hawkins 0bcff089d6 Feature #2088: Async load the default search engine icon at startup (#2113) 5 years ago
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 5 years ago
Emily Kager 0e44921e08 For #1573 - Update tabs header menu (#2141) 5 years ago
Emily Kager 1041500869 For #1573 - Long pressing tab selects that tab in save collections 5 years ago
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 5 years ago
Jeff Boek d39c15402e For #1843 - Adds a better theme for the creation fragment 5 years ago
Jeff Boek ba90b58d32 For #1843 - Displays tabs on the tab selection screen 5 years ago
Jeff Boek 63574cc359 For #1843 - Adds a create collections fragment and navigates to it 5 years ago
Sawyer Blatz e2198f19ad
Fixes #1868: Corrects private browsing myths link (#1930) 5 years ago
Emily Kager 534d88f629 Closes #1894 - Fixes Help Page Navigation 5 years ago
Jeff Boek f19a773ab9
Merge pull request #1842 from boek/i1840-collections_featureflag
For #1840 - Adds a save tab group button and puts it behind a feature  flag
5 years ago
Jeff Boek 4ea54252b0 For #1830 - Adds the ability to share a tab 5 years ago
Jeff Boek 774c5c0e0c For #1830 - Updates the tab visual style 5 years ago
Jeff Boek 5ca9040702 For #1696 - Removes sessions from session control 5 years ago
Jeff Boek 6183e82264 For #1696 - Removes sessions from the bottomsheetfragment 5 years ago
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 5 years ago
Colin Lee bc1b7e0b43 For #1539: Add bookmark multi-select features 5 years ago
Jeff Boek e98db8bfb8 For #1430 - Adds a changelog entry 5 years ago
Jeff Boek 5acd386ecd For #1430 - Handle more text in a more graceful way 5 years ago
Jeff Boek b306bc502a For #1430 - Adjust snackbar colors for darkmode 5 years ago
Jeff Boek 9434f01b42 Fixes #1204 - Fixes the home screen animation 5 years ago
Jeff Boek e34d163034 Combines the Tab and Session component 5 years ago
Jeff Boek 4a385068e0 Updates ConstraintLayout to alpha4 5 years ago
Jeff Boek 756634bc6c For #1181 - Use appName in string locations 5 years ago
Jeff Boek 786592e8d0 For #959 - Adds telemetry for when the search bar is tapped 5 years ago
Colin Lee df40ec970e Simplify ItsNotBrokenSnack() and make resilient
Co-authored by: Emily Kager <ekager@mozilla.com>
5 years ago
Emily Kager 4963f7ccdb Add Snackbar to link testers to Github issue for features 5 years ago
Emily Kager bb3ebbdbe2 Closes #932 - Home Page UI polish 5 years ago
Colin Lee 0ac3e5369d Fixes #1050: Fenix sessions save and close upon opening 5 years ago
Colin Lee 6e1655e935 Fix #1032: Crash altering sessions DB on main thread 5 years ago
Sawyer Blatz 463ab8bf79 No issue: Fixes compilation errors with a-c 47.0 5 years ago
Emily Kager 8d442c062d Closes #884 - Set and use default search engine 5 years ago
Jeff Boek 79395631d7 Fixes #870 - Fixes logic for the session bottom sheet fragment for private mode
Also fixes #871
5 years ago
Sawyer Blatz b1d0233b04 Closes #814: Scrolls to top after session restore 5 years ago
Sawyer Blatz d6ebd88186
Closes #804: Adds disable private browsing content description (#851) 5 years ago
Emily Kager d15e4bb3fa Closes #877 - Add Search Engine Settings 5 years ago
Sawyer Blatz a79134fdc3
Closes #823 & Closes #835: Refactors openToBrowserAndLoad to include fromFragment (#833) 5 years ago
Emily Kager 58b32e944b Revert "Closes #811 - Clear stack after switching to private browsing" (#876)
This reverts commit 8b793cd43e.
5 years ago
Emily Kager 8b793cd43e Closes #811 - Clear stack after switching to private browsing 5 years ago