For #15150: Do not show open banner if open in app is ON in settings.

4 years ago · cc9667f722
parent 80a573a62c
commit cc9667f722
1 changed files with 2 additions and 0 deletions
--- a/app/src/main/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserver.kt
+++ b/app/src/main/java/org/mozilla/fenix/browser/OpenInAppOnboardingObserver.kt
@ -36,10 +36,12 @@ class OpenInAppOnboardingObserver(
        }
    }

+    @Suppress("ComplexCondition")
    override fun onLoadingStateChanged(session: Session, loading: Boolean) {
        val appLink = appLinksUseCases.appLinkRedirect

        if (!loading &&
+            !settings.openLinksInExternalApp &&
            settings.shouldShowOpenInAppBanner &&
            appLink(session.url).hasExternalApp()
        ) {