No issue: add gve to setup-startup-profiling.py.

upstream-sync
Michael Comella 3 years ago committed by mergify[bot]
parent 0201120c61
commit aaa14a8208

@ -16,6 +16,10 @@ from subprocess import run
PATH_PREFIX = '/data/local/tmp' PATH_PREFIX = '/data/local/tmp'
PROD_FENIX = 'fenix'
PROD_GVE = 'geckoview_example'
PRODUCTS = [PROD_FENIX, PROD_GVE]
GV_CONFIG = b'''env: GV_CONFIG = b'''env:
MOZ_PROFILER_STARTUP: 1 MOZ_PROFILER_STARTUP: 1
MOZ_PROFILER_STARTUP_INTERVAL: 5 MOZ_PROFILER_STARTUP_INTERVAL: 5
@ -34,6 +38,8 @@ def parse_args():
"profiling for the given release channel")) "profiling for the given release channel"))
p.add_argument('release_channel', choices=['nightly', 'beta', 'release', 'debug'], help=("the release channel to " p.add_argument('release_channel', choices=['nightly', 'beta', 'release', 'debug'], help=("the release channel to "
"change the startup profiling state of the command on")) "change the startup profiling state of the command on"))
p.add_argument('-p', '--product', choices=PRODUCTS, default=PROD_FENIX, help="which product to work on")
return p.parse_args() return p.parse_args()
@ -61,22 +67,23 @@ def remove(filename):
run(['adb', 'shell', 'am', 'clear-debug-app']) run(['adb', 'shell', 'am', 'clear-debug-app'])
def convert_channel_to_id(channel): def convert_channel_to_id(product, channel):
# Users might want to use custom app IDs in the future if product == PROD_FENIX:
# but we don't know that's a need yet: let's add it if it is. mapping = {
mapping = { 'release': 'org.mozilla.firefox',
'release': 'org.mozilla.firefox', 'beta': 'org.mozilla.firefox_beta',
'beta': 'org.mozilla.firefox_beta', 'nightly': 'org.mozilla.fenix',
'nightly': 'org.mozilla.fenix', 'debug': 'org.mozilla.fenix.debug'
'debug': 'org.mozilla.fenix.debug' }
} return mapping[channel]
return mapping[channel] elif product == PROD_GVE:
return 'org.mozilla.geckoview_example'
def main(): def main():
args = parse_args() args = parse_args()
id = convert_channel_to_id(args.release_channel) id = convert_channel_to_id(args.product, args.release_channel)
filename = id + '-geckoview-config.yaml' filename = id + '-geckoview-config.yaml'
if args.command == 'activate': if args.command == 'activate':

Loading…
Cancel
Save