No issue: Re-use existing usecases for addons

fennec/production
Christian Sadilek 4 years ago
parent 56eb2ec1d7
commit 7f1ef17d8b

@ -348,16 +348,16 @@ open class FenixApplication : LocaleAwareApplication() {
session.id session.id
}, },
onCloseTabOverride = { onCloseTabOverride = {
_, sessionId -> components.tabsUseCases.removeTab(sessionId) _, sessionId -> components.useCases.tabsUseCases.removeTab(sessionId)
}, },
onSelectTabOverride = { onSelectTabOverride = {
_, sessionId -> _, sessionId ->
val selected = components.core.sessionManager.findSessionById(sessionId) val selected = components.core.sessionManager.findSessionById(sessionId)
selected?.let { components.tabsUseCases.selectTab(it) } selected?.let { components.useCases.tabsUseCases.selectTab(it) }
}, },
onExtensionsLoaded = { extensions -> onExtensionsLoaded = { extensions ->
components.addonUpdater.registerForFutureUpdates(extensions) components.addonUpdater.registerForFutureUpdates(extensions)
components.supportedAddChecker.registerForChecks() components.supportedAddonsChecker.registerForChecks()
}, },
onUpdatePermissionRequest = components.addonUpdater::onUpdatePermissionRequest onUpdatePermissionRequest = components.addonUpdater::onUpdatePermissionRequest
) )

@ -177,9 +177,9 @@ class InstalledAddonDetailsFragment : Fragment() {
?: false ?: false
if (shouldCreatePrivateSession) { if (shouldCreatePrivateSession) {
components.tabsUseCases.addPrivateTab(settingUrl) components.useCases.tabsUseCases.addPrivateTab(settingUrl)
} else { } else {
components.tabsUseCases.addTab(settingUrl) components.useCases.tabsUseCases.addTab(settingUrl)
} }
InstalledAddonDetailsFragmentDirections InstalledAddonDetailsFragmentDirections

@ -14,7 +14,6 @@ import mozilla.components.feature.addons.update.AddonUpdater
import mozilla.components.feature.addons.update.DefaultAddonUpdater import mozilla.components.feature.addons.update.DefaultAddonUpdater
import mozilla.components.feature.addons.migration.SupportedAddonsChecker import mozilla.components.feature.addons.migration.SupportedAddonsChecker
import mozilla.components.feature.addons.migration.DefaultSupportedAddonsChecker import mozilla.components.feature.addons.migration.DefaultSupportedAddonsChecker
import mozilla.components.feature.tabs.TabsUseCases
import mozilla.components.lib.publicsuffixlist.PublicSuffixList import mozilla.components.lib.publicsuffixlist.PublicSuffixList
import mozilla.components.support.migration.state.MigrationStore import mozilla.components.support.migration.state.MigrationStore
import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.BuildConfig
@ -86,7 +85,7 @@ class Components(private val context: Context) {
} }
@Suppress("MagicNumber") @Suppress("MagicNumber")
val supportedAddChecker by lazy { val supportedAddonsChecker by lazy {
DefaultSupportedAddonsChecker(context, SupportedAddonsChecker.Frequency(16, TimeUnit.MINUTES), DefaultSupportedAddonsChecker(context, SupportedAddonsChecker.Frequency(16, TimeUnit.MINUTES),
onNotificationClickIntent = Intent(context, HomeActivity::class.java).apply { onNotificationClickIntent = Intent(context, HomeActivity::class.java).apply {
action = Intent.ACTION_VIEW action = Intent.ACTION_VIEW
@ -100,8 +99,6 @@ class Components(private val context: Context) {
AddonManager(core.store, core.engine, addonCollectionProvider, addonUpdater) AddonManager(core.store, core.engine, addonCollectionProvider, addonUpdater)
} }
val tabsUseCases: TabsUseCases by lazy { TabsUseCases(core.sessionManager) }
val analytics by lazy { Analytics(context) } val analytics by lazy { Analytics(context) }
val publicSuffixList by lazy { PublicSuffixList(context) } val publicSuffixList by lazy { PublicSuffixList(context) }
val clipboardHandler by lazy { ClipboardHandler(context) } val clipboardHandler by lazy { ClipboardHandler(context) }

Loading…
Cancel
Save