Bug 1854065 - Use default prefix for implementations

fenix/119.0
rahulsainani 9 months ago committed by mergify[bot]
parent 72c16d0880
commit 611d809d19

@ -7,12 +7,12 @@ package org.mozilla.fenix.shopping.di
import android.content.Context import android.content.Context
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import mozilla.components.browser.state.store.BrowserStore import mozilla.components.browser.state.store.BrowserStore
import org.mozilla.fenix.shopping.middleware.NetworkCheckerImpl import org.mozilla.fenix.shopping.middleware.DefaultNetworkChecker
import org.mozilla.fenix.shopping.middleware.DefaultReviewQualityCheckPreferences
import org.mozilla.fenix.shopping.middleware.DefaultReviewQualityCheckService
import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckNavigationMiddleware import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckNavigationMiddleware
import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckNetworkMiddleware import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckNetworkMiddleware
import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckPreferencesImpl
import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckPreferencesMiddleware import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckPreferencesMiddleware
import org.mozilla.fenix.shopping.middleware.ReviewQualityCheckServiceImpl
import org.mozilla.fenix.shopping.store.ReviewQualityCheckMiddleware import org.mozilla.fenix.shopping.store.ReviewQualityCheckMiddleware
import org.mozilla.fenix.utils.Settings import org.mozilla.fenix.utils.Settings
@ -48,7 +48,7 @@ object ReviewQualityCheckMiddlewareProvider {
settings: Settings, settings: Settings,
scope: CoroutineScope, scope: CoroutineScope,
) = ReviewQualityCheckPreferencesMiddleware( ) = ReviewQualityCheckPreferencesMiddleware(
reviewQualityCheckPreferences = ReviewQualityCheckPreferencesImpl(settings), reviewQualityCheckPreferences = DefaultReviewQualityCheckPreferences(settings),
scope = scope, scope = scope,
) )
@ -57,8 +57,8 @@ object ReviewQualityCheckMiddlewareProvider {
context: Context, context: Context,
scope: CoroutineScope, scope: CoroutineScope,
) = ReviewQualityCheckNetworkMiddleware( ) = ReviewQualityCheckNetworkMiddleware(
reviewQualityCheckService = ReviewQualityCheckServiceImpl(browserStore), reviewQualityCheckService = DefaultReviewQualityCheckService(browserStore),
networkChecker = NetworkCheckerImpl(context), networkChecker = DefaultNetworkChecker(context),
scope = scope, scope = scope,
) )

@ -23,7 +23,7 @@ interface NetworkChecker {
/** /**
* @see [NetworkChecker]. * @see [NetworkChecker].
*/ */
class NetworkCheckerImpl(private val context: Context) : NetworkChecker { class DefaultNetworkChecker(private val context: Context) : NetworkChecker {
private val connectivityManager by lazy { context.getSystemService<ConnectivityManager>() } private val connectivityManager by lazy { context.getSystemService<ConnectivityManager>() }

@ -46,7 +46,7 @@ interface ReviewQualityCheckPreferences {
* *
* @param settings The [Settings] instance to use. * @param settings The [Settings] instance to use.
*/ */
class ReviewQualityCheckPreferencesImpl( class DefaultReviewQualityCheckPreferences(
private val settings: Settings, private val settings: Settings,
) : ReviewQualityCheckPreferences { ) : ReviewQualityCheckPreferences {

@ -30,7 +30,7 @@ interface ReviewQualityCheckService {
* *
* @property browserStore Reference to the application's [BrowserStore] to access state. * @property browserStore Reference to the application's [BrowserStore] to access state.
*/ */
class ReviewQualityCheckServiceImpl( class DefaultReviewQualityCheckService(
private val browserStore: BrowserStore, private val browserStore: BrowserStore,
) : ReviewQualityCheckService { ) : ReviewQualityCheckService {

@ -19,7 +19,7 @@ import org.junit.Rule
import org.junit.Test import org.junit.Test
import org.mockito.Mockito.doAnswer import org.mockito.Mockito.doAnswer
class ReviewQualityCheckServiceImplTest { class DefaultReviewQualityCheckServiceTest {
@get:Rule @get:Rule
val coroutinesTestRule = MainCoroutineRule() val coroutinesTestRule = MainCoroutineRule()
@ -45,7 +45,7 @@ class ReviewQualityCheckServiceImplTest {
selectedTabId = tab.id, selectedTabId = tab.id,
) )
val tested = ReviewQualityCheckServiceImpl(BrowserStore(browserState)) val tested = DefaultReviewQualityCheckService(BrowserStore(browserState))
val actual = tested.fetchProductReview() val actual = tested.fetchProductReview()
@ -72,7 +72,7 @@ class ReviewQualityCheckServiceImplTest {
selectedTabId = tab.id, selectedTabId = tab.id,
) )
val tested = ReviewQualityCheckServiceImpl(BrowserStore(browserState)) val tested = DefaultReviewQualityCheckService(BrowserStore(browserState))
assertNull(tested.fetchProductReview()) assertNull(tested.fetchProductReview())
} }
@ -101,7 +101,7 @@ class ReviewQualityCheckServiceImplTest {
selectedTabId = tab2.id, selectedTabId = tab2.id,
) )
val tested = ReviewQualityCheckServiceImpl(BrowserStore(browserState)) val tested = DefaultReviewQualityCheckService(BrowserStore(browserState))
val actual = tested.fetchProductReview() val actual = tested.fetchProductReview()
Loading…
Cancel
Save