For #15286: Don't crash when separators are long-touched

4 years ago · 5691088787
parent c326be9fd3
commit 5691088787
1 changed files with 5 additions and 1 deletions
--- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkTouchHelper.kt
+++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkTouchHelper.kt
@ -30,8 +30,12 @@ class BookmarkTouchCallback(
        recyclerView: RecyclerView,
        viewHolder: RecyclerView.ViewHolder
    ): Int {
+        // Swiping separators is currently not supported.
+        if (viewHolder is BookmarkSeparatorViewHolder) {
+            return 0
+        }
        val item = (viewHolder as BookmarkNodeViewHolder).item
-        return if (viewHolder is BookmarkSeparatorViewHolder || item?.inRoots() == true) {
+        return if (item?.inRoots() == true) {
            0
        } else {
            super.getSwipeDirs(recyclerView, viewHolder)