Bug 1846229 - Fix flaky ReviewQualityCheckStoreTest unit test

(cherry picked from commit a9c557c927aac5d43aa2a9dffcca8133d89c485c)

app/src/test/java/org/mozilla/fenix/shopping/state/ReviewQualityCheckStoreTest.kt

@@ -28,6 +28,7 @@ class ReviewQualityCheckStoreTest {
                 ),
                 scope = scope,
             )
+            tested.waitUntilIdle()
             dispatcher.scheduler.advanceUntilIdle()
             tested.waitUntilIdle()
 
@@ -45,11 +46,11 @@ class ReviewQualityCheckStoreTest {
                 ),
                 scope = scope,
             )
-            dispatcher.scheduler.advanceUntilIdle()
             tested.waitUntilIdle()
-            tested.dispatch(ReviewQualityCheckAction.OptIn).joinBlocking()
             dispatcher.scheduler.advanceUntilIdle()
+            tested.dispatch(ReviewQualityCheckAction.OptIn).joinBlocking()
             tested.waitUntilIdle()
+            dispatcher.scheduler.advanceUntilIdle()
 
             val expected = ReviewQualityCheckState.OptedIn(productRecommendationsPreference = false)
             assertEquals(expected, tested.state)
@@ -65,11 +66,11 @@ class ReviewQualityCheckStoreTest {
                 ),
                 scope = scope,
             )
-            dispatcher.scheduler.advanceUntilIdle()
             tested.waitUntilIdle()
-            tested.dispatch(ReviewQualityCheckAction.OptOut).joinBlocking()
             dispatcher.scheduler.advanceUntilIdle()
+            tested.dispatch(ReviewQualityCheckAction.OptOut).joinBlocking()
             tested.waitUntilIdle()
+            dispatcher.scheduler.advanceUntilIdle()
 
             val expected = ReviewQualityCheckState.NotOptedIn
             assertEquals(expected, tested.state)
@@ -85,11 +86,11 @@ class ReviewQualityCheckStoreTest {
                 ),
                 scope = scope,
             )
-            dispatcher.scheduler.advanceUntilIdle()
             tested.waitUntilIdle()
-            tested.dispatch(ReviewQualityCheckAction.ToggleProductRecommendation).joinBlocking()
             dispatcher.scheduler.advanceUntilIdle()
+            tested.dispatch(ReviewQualityCheckAction.ToggleProductRecommendation).joinBlocking()
             tested.waitUntilIdle()
+            dispatcher.scheduler.advanceUntilIdle()
 
             val expected = ReviewQualityCheckState.OptedIn(productRecommendationsPreference = true)
             assertEquals(expected, tested.state)
@@ -105,11 +106,11 @@ class ReviewQualityCheckStoreTest {
                 ),
                 scope = scope,
             )
-            dispatcher.scheduler.advanceUntilIdle()
             tested.waitUntilIdle()
-            tested.dispatch(ReviewQualityCheckAction.ToggleProductRecommendation).joinBlocking()
             dispatcher.scheduler.advanceUntilIdle()
+            tested.dispatch(ReviewQualityCheckAction.ToggleProductRecommendation).joinBlocking()
             tested.waitUntilIdle()
+            dispatcher.scheduler.advanceUntilIdle()
 
             val expected = ReviewQualityCheckState.OptedIn(productRecommendationsPreference = false)
             assertEquals(expected, tested.state)