Run 'become' only when the command template is properly evaluated

src/terminal.go

@@ -2863,19 +2863,21 @@ func (t *Terminal) Loop() {
 			switch a.t {
 			case actIgnore:
 			case actBecome:
-				_, list := t.buildPlusList(a.a, false)
+				valid, list := t.buildPlusList(a.a, false)
-				command := t.replacePlaceholder(a.a, false, string(t.input), list)
+				if valid {
-				shell := os.Getenv("SHELL")
+					command := t.replacePlaceholder(a.a, false, string(t.input), list)
-				if len(shell) == 0 {
+					shell := os.Getenv("SHELL")
-					shell = "sh"
+					if len(shell) == 0 {
-				}
+						shell = "sh"
-				shellPath, err := exec.LookPath(shell)
+					}
-				if err == nil {
+					shellPath, err := exec.LookPath(shell)
-					t.tui.Close()
+					if err == nil {
-					if t.history != nil {
+						t.tui.Close()
-						t.history.append(string(t.input))
+						if t.history != nil {
+							t.history.append(string(t.input))
+						}
+						syscall.Exec(shellPath, []string{shell, "-c", command}, os.Environ())
 					}
-					syscall.Exec(shellPath, []string{shell, "-c", command}, os.Environ())
 				}
 			case actExecute, actExecuteSilent:
 				t.executeCommand(a.a, false, a.t == actExecuteSilent, false)

test/test_go.rb

@@ -2645,10 +2645,16 @@ class TestGoFZF < TestBase
   end
 
   def test_become
-    tmux.send_keys "seq 10 | #{FZF} --bind 'enter:become:seq 100 | #{FZF}'", :Enter
+    tmux.send_keys "seq 100 | #{FZF} --bind 'enter:become:seq {} | #{FZF}'", :Enter
-    tmux.until { |lines| assert_equal 10, lines.item_count }
-    tmux.send_keys :Enter
     tmux.until { |lines| assert_equal 100, lines.item_count }
+    tmux.send_keys 999
+    tmux.until { |lines| assert_equal 0, lines.match_count }
+    tmux.send_keys :Enter
+    tmux.until { |lines| assert_equal 0, lines.match_count }
+    tmux.send_keys :BSpace
+    tmux.until { |lines| assert_equal 1, lines.match_count }
+    tmux.send_keys :Enter
+    tmux.until { |lines| assert_equal 99, lines.item_count }
   end
 end