Merge namecoin/ncdns#168: Move ncdt and ncdumpzone commands to cmd/ folder

80a7755d70 Move ncdt and ncdumpzone commands to cmd/ folder (Jeremy Rand)

Pull request description:

  This is more idiomatic Go.

Top commit has no ACKs.

Tree-SHA512: 4a37c4eaf54df78fe033615daf66e8750dfea4e5e99b5cc0be6a9dd52da47d5ea66a27ceb4954c795841c58099f8d31b135a03faa24fd0c4a7addfc3ee1f9eaf

.cirrus.yml

@@ -52,15 +52,17 @@ task:
         - go mod tidy
   lint_script:
     - cd $(go env GOPATH)/src/github.com/$CIRRUS_REPO_FULL_NAME/
-    - golangci-lint run --enable-all --disable execinquery,exhaustruct,gochecknoglobals,gomnd,interfacer $GOLANGCI_ARGS $GOLANGCI_MODULES_ARGS -v --timeout 5m --out-format json > $CIRRUS_WORKING_DIR/lint-report.json
+    # nosnakecase complains about stdlib API's that we can't change.
+    - golangci-lint run --enable-all --disable execinquery,exhaustruct,gochecknoglobals,gomnd,interfacer,nosnakecase $GOLANGCI_ARGS $GOLANGCI_MODULES_ARGS -v --timeout 5m --out-format json > $CIRRUS_WORKING_DIR/lint-report.json
   matrix:
     - name: "Go Lint $GOOS New$MODULES_NAME"
       env:
         GOLANGCI_ARGS: "--new-from-rev=HEAD~"
     - name: "Go Lint $GOOS Mandatory$MODULES_NAME"
       env:
+        # TODO: Re-enable dupword after ncdns issue #166 is fixed.
         # TODO: Re-enable varnamelen after golangci-lint v1.44 is released.
-        GOLANGCI_ARGS: "--disable=cyclop,deadcode,errorlint,exhaustivestruct,forbidigo,forcetypeassert,funlen,gci,gocognit,gocritic,godot,godox,goerr113,gofumpt,goimports,golint,gosec,gosimple,govet,ineffassign,lll,maligned,nakedret,nestif,nilerr,nlreturn,nonamedreturns,paralleltest,revive,scopelint,staticcheck,stylecheck,thelper,unconvert,unparam,unused,varnamelen,wastedassign,whitespace,wrapcheck,wsl"
+        GOLANGCI_ARGS: "--disable=cyclop,deadcode,dupword,errorlint,exhaustivestruct,forbidigo,forcetypeassert,funlen,gci,gocognit,gocritic,godot,godox,goerr113,gofumpt,goimports,golint,gosec,gosimple,govet,ineffassign,lll,maligned,nakedret,nestif,nilerr,nlreturn,nonamedreturns,paralleltest,revive,scopelint,staticcheck,stylecheck,thelper,unconvert,unparam,unused,varnamelen,wastedassign,whitespace,wrapcheck,wsl"
     - name: "Go Lint $GOOS$MODULES_NAME"
       env:
         GOLANGCI_ARGS: ""

server/server.go

@@ -9,13 +9,14 @@ import (
 	"strings"
 	"sync"
 
+	"github.com/btcsuite/btcd/rpcclient"
 	"github.com/hlandau/buildinfo"
 	"github.com/hlandau/xlog"
 	"github.com/miekg/dns"
-	"github.com/btcsuite/btcd/rpcclient"
+	madns "gopkg.in/hlandau/madns.v2"
+
 	"github.com/namecoin/ncdns/backend"
 	"github.com/namecoin/ncdns/namecoin"
-	madns "gopkg.in/hlandau/madns.v2"
 )
 
 var log, Log = xlog.New("ncdns.server")

util/util.go

@@ -47,14 +47,15 @@ func SplitDomainTail(name string) (tail, rest string) {
 // If ANCHOR is the first label, basename is an empty string.
 //
 // Examples, where anchor="bit":
-//   "a.b.c.d."           -> merr.ErrNotInZone
-//   "a.b.c.d.bit."       -> subname="a.b.c", basename="d", rootname="bit"
-//   "d.bit."             -> subname="",      basename="d", rootname="bit"
-//   "bit."               -> subname="",      basename="",  rootname="bit"
-//   "bit.x.y.z."         -> subname="",      basename="",  rootname="bit.x.y.z"
-//   "d.bit.x.y.z."       -> subname="",      basename="d", rootname="bit.x.y.z"
-//   "c.d.bit.x.y.z."     -> subname="c",     basename="d", rootname="bit.x.y.z"
-//   "a.b.c.d.bit.x.y.z." -> subname="a.b.c",     basename="d", rootname="bit.x.y.z"
+//
+//	"a.b.c.d."           -> merr.ErrNotInZone
+//	"a.b.c.d.bit."       -> subname="a.b.c", basename="d", rootname="bit"
+//	"d.bit."             -> subname="",      basename="d", rootname="bit"
+//	"bit."               -> subname="",      basename="",  rootname="bit"
+//	"bit.x.y.z."         -> subname="",      basename="",  rootname="bit.x.y.z"
+//	"d.bit.x.y.z."       -> subname="",      basename="d", rootname="bit.x.y.z"
+//	"c.d.bit.x.y.z."     -> subname="c",     basename="d", rootname="bit.x.y.z"
+//	"a.b.c.d.bit.x.y.z." -> subname="a.b.c",     basename="d", rootname="bit.x.y.z"
 func SplitDomainByFloatingAnchor(qname, anchor string) (subname, basename, rootname string, err error) {
 	qname = strings.TrimRight(qname, ".")
 	parts := strings.Split(qname, ".")