Merge #137: Disable ASLR/PIE on Windows

7dd7a76d3a Disable ASLR/PIE on Windows (Jeremy Rand)

Pull request description:

  Refs https://github.com/hlandau/service/issues/14

Top commit has no ACKs.

Tree-SHA512: 6794db9358ceec05870763412e7685b2c7b3261f40ead6ed2d7f35e0b3e391d1f96d329f2d83a79be507052fb1380a8abace6a508a8d7c0fc20f757164acba3a

.cirrus.yml

@@ -130,7 +130,12 @@ task:
     - dpkg --add-architecture ppc64el
     - apt-get update
     - apt-get install -y gcc-multilib libcap-dev libc6-dev:i386 libcap-dev:i386 libc6-dev:armhf libcap-dev:armhf libc6-dev:arm64 libcap-dev:arm64 libc6-dev:ppc64el libcap-dev:ppc64el
-    - go get github.com/mitchellh/gox
+    # Upstream mitchellh/gox seems abandoned; we apply a pending PR.
+    - cd /tmp/
+    - git clone https://github.com/aslakhellesoy/gox
+    - cd gox
+    - git checkout db6184738b77fbd5089e5fa1112177f391c91b24
+    - GO111MODULE=on go install .
   path_script:
     - source testdata/move_to_gopath.bash
   matrix:
@@ -161,7 +166,10 @@ task:
     - rm -rf idist
     - cd $(go env GOPATH)/src/github.com/"$CIRRUS_REPO_FULL_NAME"
     - CGO_ENABLED=1 gox -tags="$GOX_TAGS" -parallel=8 -osarch 'linux/386 linux/amd64 linux/arm linux/arm64 linux/ppc64le' -output "$GOPATH/releasing/idist/$CIRRUS_REPO_NAME-$CIRRUS_TAG-{{.OS}}_{{.Arch}}/bin/{{.Dir}}" ./...
-    - CGO_ENABLED=0 gox -tags="$GOX_TAGS" -parallel=8 -osarch 'darwin/amd64 freebsd/386 freebsd/amd64 freebsd/arm linux/ppc64 openbsd/386 openbsd/amd64 netbsd/386 netbsd/amd64 netbsd/arm dragonfly/amd64 solaris/amd64 windows/386 windows/amd64' -output "$GOPATH/releasing/idist/$CIRRUS_REPO_NAME-$CIRRUS_TAG-{{.OS}}_{{.Arch}}/bin/{{.Dir}}" ./...
+    - CGO_ENABLED=0 gox -tags="$GOX_TAGS" -parallel=8 -osarch 'darwin/amd64 freebsd/386 freebsd/amd64 freebsd/arm linux/ppc64 openbsd/386 openbsd/amd64 netbsd/386 netbsd/amd64 netbsd/arm dragonfly/amd64 solaris/amd64' -output "$GOPATH/releasing/idist/$CIRRUS_REPO_NAME-$CIRRUS_TAG-{{.OS}}_{{.Arch}}/bin/{{.Dir}}" ./...
+    # Disable ASLR/PIE to work around upstream bug in btcd's Windows service
+    # library, see https://github.com/hlandau/service/issues/14
+    - CGO_ENABLED=0 gox -buildmode=exe -tags="$GOX_TAGS" -parallel=8 -osarch 'windows/386 windows/amd64' -output "$GOPATH/releasing/idist/$CIRRUS_REPO_NAME-$CIRRUS_TAG-{{.OS}}_{{.Arch}}/bin/{{.Dir}}" ./...
   dist_script:
     - mv $GOPATH/releasing/idist ./idist
     - bash "testdata/dist.bash"

README.md

@@ -103,7 +103,7 @@ Option A: Using Go build commands without Go modules (works on any platform with
 
 4. Run `go generate github.com/namecoin/x509-compressed/...`.  The compressed public key patch will be applied.
 
-5. Run `go get -t -u github.com/namecoin/ncdns/...`.  ncdns will be built. The binaries will be at `$GOPATH/bin/ncdns`.
+5. Run `go get -t -u github.com/namecoin/ncdns/...`.  ncdns will be built.  If you're building for a Windows target, you need to add the `-buildmode=exe` flag, which disables ASLR/PIE to work around an upstream bug.  The binaries will be at `$GOPATH/bin/ncdns`.
 
 Option B: Using Go build commands with Go modules (works on any platform with Bash; Go 1.15+:
 
@@ -118,7 +118,7 @@ Option B: Using Go build commands with Go modules (works on any platform with Ba
    go mod tidy
    ~~~
 
-3. Run `go install ./...`.  ncdns will be built. The binaries will be at `$GOPATH/bin/ncdns`.
+3. Run `go install ./...`.  If you're building for a Windows target, you need to add the `-buildmode=exe` flag, which disables ASLR/PIE to work around an upstream bug.  ncdns will be built. The binaries will be at `$GOPATH/bin/ncdns`.
 
 Option C: Using Makefile (non-Windows platforms):