mpick: fix off-by-one in parse_string (expression parsing)

5 years ago · cfba3e1c3b
parent 820c07b7e4
commit cfba3e1c3b
2 changed files with 2 additions and 1 deletions
--- a/NEWS.md
+++ b/NEWS.md
@ -14,6 +14,7 @@
 * mscan: new flag -v for statistics
 * magrep: add -h, which is like -p but doesn't print the file name
 * mscan: prioritize displaying trashed mail over other markers
+* mpick: fix off-by-one in expression parsing
 * Many bug fixes

 ## 0.4 (2018-08-15)
--- a/mpick.c
+++ b/mpick.c
@ -284,7 +284,7 @@ parse_string(char **s)
 		pos++;
 		while (*pos &&
 		    (*pos != '"' || (*pos == '"' && *(pos+1) == '"'))) {
-			if (len >= bufsiz) {
+			if (len+1 >= bufsiz) {
 				bufsiz = 2*bufsiz + 16;
 				buf = realloc(buf, bufsiz);
 				if (!buf)