From 4e45c2908ac2e0cdd10a95ec95048888ced5301d Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Tue, 13 Jul 2021 22:04:28 +0200 Subject: [PATCH 1/2] loopd: fix ALPN issue with Python There is an open issue for Python gRPC clients that is currently being debugged grpc/grpc#23172 It can be mitigated server-side by specifying h2 in the metadata header. --- loopd/config.go | 1 + 1 file changed, 1 insertion(+) diff --git a/loopd/config.go b/loopd/config.go index e6b0572..a54a2bb 100644 --- a/loopd/config.go +++ b/loopd/config.go @@ -319,6 +319,7 @@ func getTLSConfig(cfg *Config) (*tls.Config, *credentials.TransportCredentials, } tlsCfg := cert.TLSConfFromCert(certData) + tlsCfg.NextProtos = []string{"h2"} restCreds, err := credentials.NewClientTLSFromFile( cfg.TLSCertPath, "", ) From 5178cd11589cae6cbcba6f426ec39dd23425127b Mon Sep 17 00:00:00 2001 From: Oliver Gugger Date: Tue, 13 Jul 2021 22:10:22 +0200 Subject: [PATCH 2/2] release_notes: update with Python ALPN fix --- release_notes.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/release_notes.md b/release_notes.md index 9a87269..4d33df2 100644 --- a/release_notes.md +++ b/release_notes.md @@ -19,3 +19,7 @@ This file tracks release notes for the loop client. #### Breaking Changes #### Bug Fixes +- Certain versions of the Python gRPC library + [weren't able to connect](https://github.com/grpc/grpc/issues/23172) to + `loopd`'s gRPC interface, getting the `missing selected ALPN property` error. + A server side fix was introduced to get rid of that error message.