x

.github/workflows/_dependencies.yml

@@ -4,7 +4,7 @@
 # testing compatibility with different versions of pydantic.
 # This code has some duplication with the _test action due to the need to
 # do extra logic if pydantic version 2 is installed; i.e., maybe run
-# with LC_PYDANTIC_V2_UNSAFE=True
+# with LC_PYDANTIC_V2_EXPERIMENTAL=True
 # The extra logic may not be worth refactoring as it'll be deleted once
 # migration to pydantic v2 proper is complete.
 name: dependencies
@@ -112,12 +112,12 @@ jobs:
         if: ${{ !startsWith(inputs.working-directory, 'libs/partners/airbyte') }}
         shell: bash
         run: make test
-      - name: Maybe run unit tests with LC_PYDANTIC_V2_UNSAFE=True
+      - name: Maybe run unit tests with LC_PYDANTIC_V2_EXPERIMENTAL=True
         # This step will run unit tests if pydantic>=2.0.0 is installed
-        # It will run unit tests with the environment variable LC_PYDANTIC_V2_UNSAFE=True
+        # It will run unit tests with the environment variable LC_PYDANTIC_V2_EXPERIMENTAL=True
         # libraries that support the flag, will attempt to run unit tests
         # using pydantic proper rather than via the pydantic.v1 namespace.
-        # TODO: Refactor how code is tested with LC_PYDANTIC_V2_UNSAFE=True
+        # TODO: Refactor how code is tested with LC_PYDANTIC_V2_EXPERIMENTAL=True
         # We should probably have a JSON file that lists which code paths
         # that support the flag
         if: ${{ !startsWith(inputs.working-directory, 'libs/core/') }}
@@ -125,13 +125,13 @@ jobs:
         run: |
           # Determine the major part of pydantic version
           REGULAR_VERSION=$(poetry run python -c "import pydantic; print(pydantic.__version__)" | cut -d. -f1)
-          # If version 2 then we run tests with LC_PYDANTIC_V2_UNSAFE=True
+          # If version 2 then we run tests with LC_PYDANTIC_V2_EXPERIMENTAL=True
           # Otherwise echo that there's nothing to do since the version is 1
           if [[ "$REGULAR_VERSION" == "2" ]]; then
-            LC_PYDANTIC_V2_UNSAFE=True make test 
-            echo "Finished running unit tests with LC_PYDANTIC_V2_UNSAFE=True"
+            LC_PYDANTIC_V2_EXPERIMENTAL=True make test 
+            echo "Finished running unit tests with LC_PYDANTIC_V2_EXPERIMENTAL=True"
           else
-            echo "No running tests with LC_PYDANTIC_V2_UNSAFE=True since pydantic version is 1"
+            echo "No running tests with LC_PYDANTIC_V2_EXPERIMENTAL=True since pydantic version is 1"
           fi
       - name: Ensure the tests did not create any additional files
         shell: bash

.github/workflows/_test.yml

@@ -57,12 +57,12 @@ jobs:
         run: |
           make test
 
-      - name: Maybe run unit tests with LC_PYDANTIC_V2_UNSAFE=True
+      - name: Maybe run unit tests with LC_PYDANTIC_V2_EXPERIMENTAL=True
         # This step will run unit tests if pydantic>=2.0.0 is installed
-        # It will run unit tests with the environment variable LC_PYDANTIC_V2_UNSAFE=True
+        # It will run unit tests with the environment variable LC_PYDANTIC_V2_EXPERIMENTAL=True
         # libraries that support the flag, will attempt to run unit tests
         # using pydantic proper rather than via the pydantic.v1 namespace.
-        # TODO: Refactor how code is tested with LC_PYDANTIC_V2_UNSAFE=True
+        # TODO: Refactor how code is tested with LC_PYDANTIC_V2_EXPERIMENTAL=True
         # We should probably have a JSON file that lists which code paths
         # that support the flag
         if: ${{ !startsWith(inputs.working-directory, 'libs/core/') }}
@@ -70,13 +70,13 @@ jobs:
         run: |
           # Determine the major part of pydantic version
           REGULAR_VERSION=$(poetry run python -c "import pydantic; print(pydantic.__version__)" | cut -d. -f1)
-          # If version 2 then we run tests with LC_PYDANTIC_V2_UNSAFE=True
+          # If version 2 then we run tests with LC_PYDANTIC_V2_EXPERIMENTAL=True
           # Otherwise echo that there's nothing to do since the version is 1
           if [[ "$REGULAR_VERSION" == "2" ]]; then
-            LC_PYDANTIC_V2_UNSAFE=True make test 
-            echo "Finished running unit tests with LC_PYDANTIC_V2_UNSAFE=True"
+            LC_PYDANTIC_V2_EXPERIMENTAL=True make test 
+            echo "Finished running unit tests with LC_PYDANTIC_V2_EXPERIMENTAL=True"
           else
-            echo "No running tests with LC_PYDANTIC_V2_UNSAFE=True since pydantic version is 1"
+            echo "No running tests with LC_PYDANTIC_V2_EXPERIMENTAL=True since pydantic version is 1"
           fi
       - name: Ensure the tests did not create any additional files
         shell: bash