From 7926cc1929be2356360e4909744cb16b7f3690c3 Mon Sep 17 00:00:00 2001 From: Mateusz Szewczyk <139469471+MateuszOssGit@users.noreply.github.com> Date: Wed, 8 May 2024 19:23:14 +0200 Subject: [PATCH] ibm: Fix llm and embeddings "verify" attribute default value (#21429) Thank you for contributing to LangChain! - [x] **PR title**: "langchain-ibm: Fix llm and embeddings 'verify' attribute default value" - [x] **PR message**: - **Description:** fix default value of "verify" attribute - **Dependencies:** `ibm_watsonx_ai` - [x] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Co-authored-by: Erick Friis --- libs/partners/ibm/langchain_ibm/embeddings.py | 2 +- libs/partners/ibm/langchain_ibm/llms.py | 2 +- libs/partners/ibm/poetry.lock | 19 ++++++++++--------- libs/partners/ibm/pyproject.toml | 2 +- 4 files changed, 13 insertions(+), 12 deletions(-) diff --git a/libs/partners/ibm/langchain_ibm/embeddings.py b/libs/partners/ibm/langchain_ibm/embeddings.py index 55a1b9b441..4abe9f542c 100644 --- a/libs/partners/ibm/langchain_ibm/embeddings.py +++ b/libs/partners/ibm/langchain_ibm/embeddings.py @@ -48,7 +48,7 @@ class WatsonxEmbeddings(BaseModel, LangChainEmbeddings): params: Optional[dict] = None """Model parameters to use during generate requests.""" - verify: Union[str, bool] = "" + verify: Union[str, bool, None] = None """User can pass as verify one of following: the path to a CA_BUNDLE file the path of directory with certificates of trusted CAs diff --git a/libs/partners/ibm/langchain_ibm/llms.py b/libs/partners/ibm/langchain_ibm/llms.py index 1837199549..962ff0cb11 100644 --- a/libs/partners/ibm/langchain_ibm/llms.py +++ b/libs/partners/ibm/langchain_ibm/llms.py @@ -81,7 +81,7 @@ class WatsonxLLM(BaseLLM): params: Optional[dict] = None """Model parameters to use during generate requests.""" - verify: Union[str, bool] = "" + verify: Union[str, bool, None] = None """User can pass as verify one of following: the path to a CA_BUNDLE file the path of directory with certificates of trusted CAs diff --git a/libs/partners/ibm/poetry.lock b/libs/partners/ibm/poetry.lock index 3720d12ba1..6050974181 100644 --- a/libs/partners/ibm/poetry.lock +++ b/libs/partners/ibm/poetry.lock @@ -327,7 +327,7 @@ files = [ [[package]] name = "langchain-core" -version = "0.1.50" +version = "0.1.52" description = "Building applications with LLMs through composability" optional = false python-versions = ">=3.8.1,<4.0" @@ -351,13 +351,13 @@ url = "../../core" [[package]] name = "langsmith" -version = "0.1.54" +version = "0.1.55" description = "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform." optional = false python-versions = "<4.0,>=3.8.1" files = [ - {file = "langsmith-0.1.54-py3-none-any.whl", hash = "sha256:e8ba2758dbdff0fccb35337c28a5ab641dd980b22e178d390b72a15c9ae9caff"}, - {file = "langsmith-0.1.54.tar.gz", hash = "sha256:86f5a90e48303de897f37a893f8bb635eabdaf23e674099e8bc0f2e9ca2f8faf"}, + {file = "langsmith-0.1.55-py3-none-any.whl", hash = "sha256:c198b4019d0e0948fa2c94efcafa0312bd5e7ce36aae8d62a38af2d6b16584fc"}, + {file = "langsmith-0.1.55.tar.gz", hash = "sha256:08b75046471e3c32cb6b526e48ca4570bfe3911d6b0a3f8575ee062da940324c"}, ] [package.dependencies] @@ -988,17 +988,18 @@ widechars = ["wcwidth"] [[package]] name = "tenacity" -version = "8.2.3" +version = "8.3.0" description = "Retry code until it succeeds" optional = false -python-versions = ">=3.7" +python-versions = ">=3.8" files = [ - {file = "tenacity-8.2.3-py3-none-any.whl", hash = "sha256:ce510e327a630c9e1beaf17d42e6ffacc88185044ad85cf74c0a8887c6a0f88c"}, - {file = "tenacity-8.2.3.tar.gz", hash = "sha256:5398ef0d78e63f40007c1fb4c0bff96e1911394d2fa8d194f77619c05ff6cc8a"}, + {file = "tenacity-8.3.0-py3-none-any.whl", hash = "sha256:3649f6443dbc0d9b01b9d8020a9c4ec7a1ff5f6f3c6c8a036ef371f573fe9185"}, + {file = "tenacity-8.3.0.tar.gz", hash = "sha256:953d4e6ad24357bceffbc9707bc74349aca9d245f68eb65419cf0c249a1949a2"}, ] [package.extras] -doc = ["reno", "sphinx", "tornado (>=4.5)"] +doc = ["reno", "sphinx"] +test = ["pytest", "tornado (>=4.5)", "typeguard"] [[package]] name = "tomli" diff --git a/libs/partners/ibm/pyproject.toml b/libs/partners/ibm/pyproject.toml index bef871725f..4cb9bd193c 100644 --- a/libs/partners/ibm/pyproject.toml +++ b/libs/partners/ibm/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "langchain-ibm" -version = "0.1.5" +version = "0.1.6" description = "An integration package connecting IBM watsonx.ai and LangChain" authors = ["IBM"] readme = "README.md"