0dad707e2e
[fix, Kobo] Don't crash trying to sync frontlight with Nickel. ( #5361 )
...
When reasonably possible, the program should only crash in debug mode.
Adds a couple of extra unit tests to prevent regressions and adds docs.
Fixes <https://github.com/koreader/koreader/issues/5356 >.
5 years ago
deaa5d98e6
Disable show chapter markers when progress bar is hidden in footer ( #5345 )
5 years ago
6c93415f67
[fix] Filesearcher crash on empty file attributes ( #5351 )
...
Fixes <https://github.com/koreader/koreader/issues/5343 >.
5 years ago
ed4396821f
[fix] ReadSettings Inverse reading order ( #5350 )
...
`self.inverse_reading_order == nil and G_reader_settings:has("inverse_reading_order")` could easily be false, which would then incorrectly turn the setting off.
Fixes <https://github.com/koreader/koreader/issues/5346 >.
5 years ago
07116b9898
[fix] Add keyboard layout to filemanager menu ( #5338 )
...
Overlooked in <https://github.com/koreader/koreader/pull/5318 >.
5 years ago
59355200dc
[fix] PdfDocument: Hash collision ( #5337 )
...
A typo introduced in <https://github.com/koreader/koreader/pull/5282 >.
This might resolve <https://github.com/koreader/koreader/issues/5323 >, <https://github.com/koreader/koreader/issues/5327 >.
5 years ago
a3acc667d6
[Kobo] Restart KOReader after a crash ( #5328 )
...
* Restart KOReader after a crash, after showing a fancy crash recap screen (our very own Gray Screen of Death!).
Kobo only, because it's possibly the platform where getting booted out
of KOReader is the most annoying.
Keeps track of crashes, to be able to give up after a while, in order to
avoid boot loops in the unlikely event of a crash loop on startup.
Adds a dev option to *always* exit KOReader after the crash screen.
5 years ago
872c145f3a
[fix] ReaderGesture: Use getCurrentNetwork().ssid ( #5334 )
...
Otherwise ffi/util.template crashes on a table.
5 years ago
17e437dbd0
[UX] Allow keyboard layout selection ( #5318 )
...
Fixes <https://github.com/koreader/koreader/issues/3998 >.
This isn't quite what I want but I've been letting this slip for
too long due to fancier keyboard interaction concepts.
5 years ago
20ebb55703
[Cervantes] Disable wifi before returning to QT, improved sysfs read ( #5326 )
5 years ago
5f189beba9
You have failed this city! ( #5321 )
...
Switch two finger swipe icons to double arrows
5 years ago
7019ff15bd
[chore] Drop SDL 1.2 ( #5324 )
...
Depends on https://github.com/koreader/koreader-base/pull/963 .
Also includes Initial import of <linux/rtc.h> related stuff https://github.com/koreader/koreader-base/pull/965
5 years ago
2d95a09e93
[UX] Option to show horizontal line separator in footer ( #5309 )
...
The separator is hidden by default.
5 years ago
cb2a3d9e72
Cervantes: Add back to stock reader ( #5316 )
5 years ago
ae50569055
Frontlight - Add checkbox use system settings ( #5307 )
...
See: https://github.com/koreader/koreader/issues/5205#issuecomment-526935357
Devices with `hasLightLevelFallback = true` (for now Android) has extra checkbutton `Use system settings`. Default unchecked.
5 years ago
2cd9b50137
[Android] Don't ship Noto ( #5310 )
...
Follow-up to <https://github.com/koreader/koreader/pull/5252 >. This greatly reduces the Android package size.
See discussion in <https://github.com/koreader/koreader/pull/5264#issuecomment-525517001 >.
5 years ago
d66cf7ab61
[fix] Allow setting a fine-tuned font size as default ( #5306 )
...
And a couple bugfix this unearthed:
* Always set the default as the *current* value, no matter what (by chance, this was not an issue for margins).
* Don't crash on the hold gesture in the -/+ buttons for the horizontal margins (regression since #5303 ).
5 years ago
b2554ba5da
[fix] Prevent crash when no page boxes ( #5289 )
...
Can occur with invalid page numbers, for example by changing the font size in a reflowable MuPDF document.
Discussion in <https://github.com/koreader/koreader/pull/5282#issuecomment-526842921 >.
5 years ago
49589901b1
[fix] Let UIManager handle suspend logic ( #5304 )
...
See <https://github.com/koreader/koreader/issues/2431#issuecomment-526925910 >.
Supersedes <https://github.com/koreader/koreader/pull/5302 >.
5 years ago
4cdc3ab99b
[feat, plugin] Add AutoTurn ( #5295 )
...
Fixes <https://github.com/koreader/koreader/issues/3019 >.
5 years ago
b038fa3046
[UX] Add fine tune buttons to horizontal margins ( #5303 )
...
Similar to top and bottom margins I add fine tune buttons to L/R margins.
5 years ago
1b17ce8ba0
[fix, Kobo] Save frontlight state on shutdown after suspend ( #5305 )
...
Fixes <https://github.com/koreader/koreader/issues/5292 >.
5 years ago
621f36b4a9
[fix] GetText: guard against empty strings in translation ( #5301 )
...
Fixes <https://github.com/koreader/koreader/issues/5293 >.
5 years ago
d7d99d8b8b
New memory icon for footer ( #5300 )
...
See: https://github.com/koreader/koreader/pull/5203#issuecomment-525849264
Old memory icon: ⌨
New: ≡
5 years ago
0b62fc56ee
[doc] Add NumberPickerWidget developer docs ( #5298 )
5 years ago
3f3443b2e2
[UX] Reorganize tap corner menu in Gesture Manager ( #5294 )
...
Reorganize submenu tap corner like other submenus
Settings -> Tap and gestures -> Gesture manager -> Tap corner
5 years ago
bc2412a67a
[doc] Convert koptinterface comments to LDoc format ( #5290 )
5 years ago
37bab4fe89
[fix] Pass plain link to link:onGotoLink ( #5286 )
...
Internal links carry more baggage than external ones.
See <https://github.com/koreader/koreader/pull/5282#issuecomment-526813719 >.
5 years ago
258b13d344
[fix] Fallback in case of missing HOME variable
5 years ago
860759cd48
Support loading GUI fonts from any known folder
5 years ago
418aa1e5d6
Cache fontlist
5 years ago
a47b3b1a5b
[doc] Add internal documentation references ( #5285 )
...
Also some minor grammatical fixes.
5 years ago
f1f6eebce0
[feat] Add MuPDF EPUB/FB2 dynamic font size ( #5282 )
...
Closes #4368 .
5 years ago
f6270278aa
[feat] Implement fulltext search direction ( #5283 )
...
Closes <https://github.com/koreader/koreader/issues/5054 >.
5 years ago
ac16c8d547
[UX] Treat inverse_reading_order as a proper setting ( #5284 )
...
This is supported by ReaderPaging and ReaderRolling, but the menu entry was only shown in ReaderPaging.
Hold now sets the global default.
Fixes <https://github.com/koreader/koreader/issues/4983 >.
Fixes <https://github.com/koreader/koreader/issues/4089 >.
5 years ago
cfa73be940
[feat, Kobo] Implement shutdown from suspend ( #5280 )
...
This allows to shutdown straight from suspend just like Nickel.
Fixes <https://github.com/koreader/koreader/issues/2431 >.
5 years ago
dd4bfb0a45
[UX] Ignore page flipping toggle while bookmark flipping ( #5276 )
...
See https://github.com/koreader/koreader/issues/5265#issuecomment-525626930
5 years ago
2104bb6f98
[fix] Distinguish bookmark/page flipping in menu ( #5266 )
...
Fixes <https://github.com/koreader/koreader/issues/5265 >.
5 years ago
cddca1a5b5
[fix] Remove gettext util dependency ( #5270 )
...
A simple `string.gmatch()` should do the trick here, which avoids the need for refactoring.
Fixes <https://github.com/koreader/koreader/issues/5269 >.
5 years ago
be87fb27a0
[chore] Convert a couple more todos ( #5267 )
...
Cf. <https://github.com/koreader/koreader/pull/5244 >.
Also update check.
5 years ago
f3c3989b7f
[chore] readertypeset: normalize string indentation
...
Same as <ece884a368/frontend/ui/widget/configdialog.lua (L1015-L1019)
5 years ago
3ab51b1f85
[spec] Test all gettext codepaths & support language with no plurals ( #5260 )
5 years ago
06d26ed13e
[doc] gettext developer docs
5 years ago
9cd8e4a53a
[chore] Work around weird LDoc bug
...
Using two `@fixme` tags directly following each other can result in a crash.
See <https://github.com/stevedonovan/LDoc/issues/314 > for the upstream issue.
5 years ago
59bb3ac8ea
[chore] Remove executable bit on device/input.lua ( #5258 )
...
I've got no idea why that might be there.
5 years ago
2c555830f9
[feat, i18n] Implement ngettext ( #5257 )
...
Fixes <https://github.com/koreader/koreader/issues/5249 >.
See https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html and https://www.gnu.org/software/gettext/manual/html_node/Translating-plural-forms.html for more information.
Usage:
```lua
local T = ffiUtil.template
local _ = require("gettext")
local N_ = _.ngettext
local items_string = T(N_("1 item", "%1 items", num_items), num_items)
```
5 years ago
45a0f285f1
[fix, i18n] Make two strings translatable ( #5256 )
...
Fixes <https://github.com/koreader/koreader/issues/5255 >.
5 years ago
6ed58346a1
[i18n] Add translator notes ( #5250 )
...
Thanks to <https://github.com/koreader/koreader/pull/5237 > we can now extract the knowledge currently embedded in Transifex and put it directly in our source. This positively affects <https://github.com/koreader/koreader/issues/3754 >.
Translation instructions and knowledge that comes out of localization-related questions should be preserved in the source, because Transifex is too ephemeral. For example, the links from <https://github.com/koreader/koreader/pull/2290 > are no longer accessible. Even when they are, it's quite useful to have this information around while dealing with the code as well, and I also hope it'll be informative to contributors who seldom visit Transifex.
This commit also makes a few minor changes to obviate the need for comments where possible.
5 years ago
a2dcfe9aec
[doc] Tag @todo, @fixme and @warning ( #5244 )
...
This commit standardizes the various todos around the code a bit in a manner recognized by LDoc.
Besides drawing more attention by being displayed in the developer docs, they're also extractable with LDoc on the command line:
```sh
ldoc --tags todo,fixme *.lua
```
However, whether that particular usage offers any advantage over other search tools is questionable at best.
* and some random beautification
5 years ago
dc6d4085ea
Fix: Unable to hold top right corner in FileManager ( #5248 )
...
Close : #5247
5 years ago
Frans de Jonge
Robert
NiLuJe
Martín Fernández