Autocomplete "disable" (#634)

inputremapper/gui/autocompletion.py

@@ -29,7 +29,7 @@ from gi.repository import Gdk, Gtk, GLib, GObject
 
 from inputremapper.gui.controller import Controller
 from inputremapper.configs.mapping import MappingData
-from inputremapper.configs.system_mapping import system_mapping
+from inputremapper.configs.system_mapping import system_mapping, DISABLE_NAME
 from inputremapper.gui.components.editor import CodeEditor
 from inputremapper.gui.messages.message_broker import MessageBroker, MessageType
 from inputremapper.gui.messages.message_data import UInputsData
@@ -93,7 +93,7 @@ def get_incomplete_parameter(iter_: Gtk.TextIter) -> Optional[str]:
     #  foo
     #  bar + foo
     match = re.match(rf"(?:{PARAMETER}|^)(\w+)$", left_text)
-    logger.debug("get_incomplete_parameter text: %s match: %s", left_text, match)
+    logger.debug('get_incomplete_parameter text: "%s" match: %s', left_text, match)
 
     if match is None:
         return None
@@ -110,9 +110,11 @@ def propose_symbols(text_iter: Gtk.TextIter, codes: List[int]) -> List[Tuple[str
 
     incomplete_name = incomplete_name.lower()
 
+    names = list(system_mapping.list_names(codes=codes)) + [DISABLE_NAME]
+
     return [
         (name, name)
-        for name in list(system_mapping.list_names(codes=codes))
+        for name in names
         if incomplete_name in name.lower() and incomplete_name != name.lower()
     ]
 

tests/integration/test_gui.py

@@ -24,10 +24,12 @@ import asyncio
 from contextlib import contextmanager
 from typing import Tuple, List, Optional, Iterable
 
+from inputremapper.gui.autocompletion import get_incomplete_parameter, _get_left_text
+
 from inputremapper.injection.global_uinputs import global_uinputs
 from tests.lib.global_uinputs import reset_global_uinputs_for_service
 from tests.test import get_project_root
-from tests.lib.cleanup import cleanup
+from tests.lib.cleanup import cleanup, quick_cleanup
 from tests.lib.stuff import spy
 from tests.lib.constants import EVENT_READ_TIMEOUT
 from tests.lib.fixtures import prepare_presets
@@ -2025,6 +2027,44 @@ class TestAutocompletion(GuiTestBase):
         event.keyval = keyval
         self.user_interface.autocompletion.navigate(None, event)
 
+    def get_suggestions(self, autocompletion):
+        return [
+            row.get_children()[0].get_text()
+            for row in autocompletion.list_box.get_children()
+        ]
+
+    def test_get_incomplete_parameter(self):
+        def test(text, expected):
+            text_view = Gtk.TextView()
+            Gtk.TextView.do_insert_at_cursor(text_view, text)
+            text_iter = text_view.get_iter_at_location(0, 0)[1]
+            text_iter.set_offset(len(text))
+            self.assertEqual(get_incomplete_parameter(text_iter), expected)
+
+        test("bar(foo", "foo")
+        test("bar(a=foo", "foo")
+        test("bar(qux, foo", "foo")
+        test("foo", "foo")
+        test("bar + foo", "foo")
+
+    def test_autocomplete_names(self):
+        autocompletion = self.user_interface.autocompletion
+
+        def setup(text):
+            self.set_focus(self.code_editor)
+            Gtk.TextView.do_insert_at_cursor(self.code_editor, text)
+            self.throttle(200)
+            text_iter = self.code_editor.get_iter_at_location(0, 0)[1]
+            text_iter.set_offset(len(text))
+
+        setup("disa")
+        self.assertNotIn("KEY_A", self.get_suggestions(autocompletion))
+        self.assertIn("disable", self.get_suggestions(autocompletion))
+
+        setup(" + _A")
+        self.assertIn("KEY_A", self.get_suggestions(autocompletion))
+        self.assertNotIn("disable", self.get_suggestions(autocompletion))
+
     def test_autocomplete_key(self):
         self.controller.update_mapping(output_symbol="")
         gtk_iteration()