You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
aa8642f534
* For #4596: move code from CollectionCreationComponent to CollectionCreationStore Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable. * For 4596: update CollectionCreateStore to libstate * For 4596: copied CollectionCreationUIView into CollectionCreationView Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable. * For 4596: update CollectionCreationView to LibState Note that the minimal changes possible to enable migration were made. Refactoring will happen in a later commit. * For 4596: updated CollectionCreationTabListAdapter to work with the new View * For 4596: updated SaveCollectionListAdapter to work with the new View * For 4596: implemented CollectionCreationController For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer * For 4596: copied over previous reducer code No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer * For 4596: update reducer code param names Otherwise, no changes at this time * For 4596: add arguments to CreateCollectionFragment in nav_graph These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture. * For 4596: pass arguments to collection via transaction instead of VM The VM will be removed in a later commit * For 4596: update BrowserToolbarController to share state to collection via its Direction * For 4596: removed CreateCollectionViewModel * For 4596: test tab retrieval in CreateCollectionFragment * For 4596: fix crashing CreateCollectionFragmentTest * For 4596: removed classes create collection classes used by old architecture * For 4596: collection interactor rename + kdoc * For 4596: moved collection interactor interface * For 4596: renamed CreateCollectionFragment All related classes followed the pattern of CollectionCreationX * For 4596: kdoc CollectionCreationController There's no effective difference between these calls and their interactor equivalent, so I linked to them * For 4596: fix bug that caused rename to not work * For 4596: removed unused collection actions These were unused before the LibState refactor * For 4596: kdoc StepChanged * For 4596: removed todos about moving logic to the reducer saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here stepBack: called by handleBackPress. See above * For 4596: wrote tests for CollectionCreationController#stepback * For 4596: fixed tests broken by changes to collections * For 4596: small readability refactor for CollectionController#stepBack No change to functionality (see tests) * For 4596: broke apart CollectionView#update There's probably a lot more that could be done here, but smaller changes were made to reduce scope * For 4596: remove unnecessary todos It looks like we don't follow the suggested pattern in this project * For 4596: test CollectionCreationController#normalSessionSize * For 4596: updated naming in CollectionCreationController per review |
5 years ago | |
|---|---|---|
| .. | ||
| account_auth_error_preference.xml | 5 years ago | |
| account_preference.xml | 5 years ago | |
| account_share_list_item.xml | 5 years ago | |
| activity_home.xml | 5 years ago | |
| app_share_list_item.xml | 5 years ago | |
| browser_toolbar_popup_window.xml | 5 years ago | |
| checkbox_left_preference.xml | 5 years ago | |
| collection_header.xml | 5 years ago | |
| collection_home_list_row.xml | 5 years ago | |
| collection_tab_list_row.xml | 5 years ago | |
| collections_list_item.xml | 5 years ago | |
| component_awesomebar.xml | 5 years ago | |
| component_bookmark.xml | 5 years ago | |
| component_collection_creation.xml | 5 years ago | |
| component_collection_creation_name_collection.xml | 5 years ago | |
| component_collection_creation_select_collection.xml | 5 years ago | |
| component_exceptions.xml | 5 years ago | |
| component_history.xml | 5 years ago | |
| component_permissions_blocked_by_android.xml | 5 years ago | |
| component_quick_action_sheet.xml | 5 years ago | |
| component_search.xml | 5 years ago | |
| component_session_control.xml | 5 years ago | |
| component_sign_in.xml | 5 years ago | |
| component_tracking_protection_panel.xml | 5 years ago | |
| delete_browsing_category_checkbox.xml | 5 years ago | |
| delete_browsing_data_item.xml | 5 years ago | |
| delete_exceptions_button.xml | 5 years ago | |
| exception_item.xml | 5 years ago | |
| exceptions_description.xml | 5 years ago | |
| fenix_snackbar.xml | 5 years ago | |
| fragment_about.xml | 5 years ago | |
| fragment_add_new_device.xml | 5 years ago | |
| fragment_bookmark.xml | 5 years ago | |
| fragment_browser.xml | 5 years ago | |
| fragment_crash_reporter.xml | 5 years ago | |
| fragment_create_collection.xml | 5 years ago | |
| fragment_create_shortcut.xml | 5 years ago | |
| fragment_delete_browsing_data.xml | 5 years ago | |
| fragment_edit_bookmark.xml | 5 years ago | |
| fragment_exceptions.xml | 5 years ago | |
| fragment_history.xml | 5 years ago | |
| fragment_home.xml | 5 years ago | |
| fragment_library.xml | 5 years ago | |
| fragment_manage_site_permissions_exceptions_feature_phone.xml | 5 years ago | |
| fragment_manage_site_permissions_feature_phone.xml | 5 years ago | |
| fragment_pair.xml | 5 years ago | |
| fragment_quick_settings_dialog_sheet.xml | 5 years ago | |
| fragment_search.xml | 5 years ago | |
| fragment_select_bookmark_folder.xml | 5 years ago | |
| fragment_share.xml | 5 years ago | |
| fragment_sign_out.xml | 5 years ago | |
| fragment_site_permissions_exceptions.xml | 5 years ago | |
| fragment_site_permissions_exceptions_item.xml | 5 years ago | |
| fragment_tracking_protection.xml | 5 years ago | |
| fragment_tracking_protection_blocking.xml | 5 years ago | |
| fragment_turn_on_sync.xml | 5 years ago | |
| history_list_item.xml | 5 years ago | |
| layout_clear_permission_button.xml | 5 years ago | |
| layout_percentage_seek_bar.xml | 5 years ago | |
| layout_quick_action_sheet.xml | 5 years ago | |
| layout_url_background.xml | 5 years ago | |
| library_list_item.xml | 5 years ago | |
| library_site_item.xml | 5 years ago | |
| mozac_browser_menu_item_switch.xml | 5 years ago | |
| mozac_ui_tabcounter_layout.xml | 5 years ago | |
| no_content_message.xml | 5 years ago | |
| onboarding_automatic_signin.xml | 5 years ago | |
| onboarding_finish.xml | 5 years ago | |
| onboarding_header.xml | 5 years ago | |
| onboarding_manual_signin.xml | 5 years ago | |
| onboarding_privacy_notice.xml | 5 years ago | |
| onboarding_private_browsing.xml | 5 years ago | |
| onboarding_section_header.xml | 5 years ago | |
| onboarding_theme_picker.xml | 5 years ago | |
| onboarding_tracking_protection.xml | 5 years ago | |
| pbm_shortcut_popup.xml | 5 years ago | |
| preference_default_browser.xml | 5 years ago | |
| preference_search_engine_chooser.xml | 5 years ago | |
| preference_widget_radiobutton.xml | 5 years ago | |
| preference_widget_radiobutton_with_info.xml | 5 years ago | |
| private_browsing_description.xml | 5 years ago | |
| save_tab_group_button.xml | 5 years ago | |
| search_engine_radio_button.xml | 5 years ago | |
| search_widget_extra_small_v1.xml | 5 years ago | |
| search_widget_extra_small_v2.xml | 5 years ago | |
| search_widget_large.xml | 5 years ago | |
| search_widget_medium.xml | 5 years ago | |
| search_widget_small.xml | 5 years ago | |
| search_widget_small_no_mic.xml | 5 years ago | |
| share_close.xml | 5 years ago | |
| share_tab_item.xml | 5 years ago | |
| share_to_account_devices.xml | 5 years ago | |
| share_to_apps.xml | 5 years ago | |
| sign_in_preference.xml | 5 years ago | |
| stub_find_in_page.xml | 5 years ago | |
| switch_with_description.xml | 5 years ago | |
| tab_header.xml | 5 years ago | |
| tab_in_collection.xml | 5 years ago | |
| tab_list_row.xml | 5 years ago | |
| tracking_protection_category.xml | 5 years ago | |
| tracking_protection_learn_more_preference.xml | 5 years ago | |
| tracking_protection_onboarding_popup.xml | 5 years ago | |