You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
iceraven-browser/app/src/main/res/layout
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
4 years ago
..
about_list_item.xml For #4776: Redesign and refactor the About Page 5 years ago
account_auth_error_preference.xml Use tools:text to avoid inflating strings twice (#3619) 5 years ago
account_preference.xml For #12107: Follow ux mock on Settings --> Account screen 4 years ago
account_share_list_item.xml For #4007 - Use camelCase for views referenced from code 5 years ago
activity_addons.xml Provide add-on support (#8064) 4 years ago
activity_home.xml For #7473, delay inflation of toolbar 4 years ago
activity_migration.xml For #11154: Fix button color on migration UI 4 years ago
app_share_list_item.xml For #4007 - Use camelCase for views referenced from code 5 years ago
browser_toolbar_popup_window.xml For #10577 - Adds elevation for the browser toolbar popup 4 years ago
button_tip_item.xml For #9208: Make slight modifications to tip layout 4 years ago
checkbox_left_preference.xml For #11665: Adjust visual design for delete browsing data screens. 4 years ago
checkbox_left_preference_etp.xml For #10656: Adjust etp checkbox dimensions for a11y. 4 years ago
checkbox_left_sub_preference.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 4 years ago
collection_header.xml Polish homescreen (#11065) 4 years ago
collection_home_list_row.xml For #9496: Vertically align collection name and icons to collection icon 4 years ago
collection_tab_list_row.xml For #11139:Constrain title to start of checkbox and ellipsize. 4 years ago
collections_list_item.xml For issue #11835 - Update text fonts 4 years ago
component_bookmark.xml For #2165 - Add swipe to refresh gesture to bookmarks view. 4 years ago
component_bottom_browser_toolbar.xml For #5694 & #6054: Allows users to change toolbar position (#6608) 5 years ago
component_browser_top_toolbar.xml For #6940: Fixes top dynamic toolbar behavior (#9900) 4 years ago
component_collection_creation.xml For issue #11835 - Update text fonts 4 years ago
component_collection_creation_name_collection.xml Issue 5366 Vector Drawable Compat (#6904) 5 years ago
component_collection_creation_select_collection.xml For issue #11835 - Update text fonts 4 years ago
component_exceptions.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 4 years ago
component_history.xml For #2165 - Implement pull-to-refresh gesture to sync history. 4 years ago
component_locale_settings.xml For #12078: Follow ux mock on Settings --> Language screen 4 years ago
component_permissions_blocked_by_android.xml For #9857: Create button style (#9858) 4 years ago
component_saved_logins.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 4 years ago
component_session_control.xml For #3574 Allow all screen readers to read onboarding items one-by one (#7292) 4 years ago
component_sync_tabs.xml For #11641: Update synced tabs view 4 years ago
component_tabstray.xml Closes #11873 - Add scrollbar in tabs tray 4 years ago
component_tabstray_fab.xml Implement tab tray design improvements and fix close functionality. 4 years ago
component_top_sites.xml For #10281: Change margin with padding to allow flexbox to stretch. 4 years ago
component_tracking_protection_panel.xml Tests and cleanup for tracking protection 4 years ago
custom_search_engine.xml For #9775: Increase touch target of elements in add search engine screen 4 years ago
custom_search_engine_radio_button.xml For #12007: Fix add search engine items using wrap content for height 4 years ago
delete_browsing_data_item.xml For #11665: Adjust visual design for delete browsing data screens. 4 years ago
delete_exceptions_button.xml For #9857: Create button style (#9858) 4 years ago
delete_logins_exceptions_button.xml For #7094 - Adds save login exceptions 4 years ago
download_dialog_layout.xml For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 4 years ago
dropdown_preference_etp.xml For #6479: Add granular ETP settings 4 years ago
etp_dropdown_item.xml For #6479: Add granular ETP settings 4 years ago
exception_item.xml Fixes #9504: Edit logins (#9693) 4 years ago
exceptions_description.xml Add Tracking Protection Info Panel 5 years ago
fenix_snackbar.xml For #9594: Increase touch target for snackbar action button button. 4 years ago
fragment_about.xml For #9712 - show "AC: " before AC version on "About" screen 4 years ago
fragment_add_new_device.xml For #9857: Create button style (#9858) 4 years ago
fragment_add_on_details.xml For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 4 years ago
fragment_add_on_internal_settings.xml Provide add-on support (#8064) 4 years ago
fragment_add_on_permissions.xml For issue #8520: Polish Add-on manager UIs 4 years ago
fragment_add_ons_management.xml For issue #8520: Improve add-ons UI 4 years ago
fragment_add_search_engine.xml Adds custom search engines (#6551) 5 years ago
fragment_bookmark.xml For #8649: No bookmarks here strings are close to the top 4 years ago
fragment_browser.xml For #9044 - Replace DownloadNotificationBottomSheetDialog with unobtrusive view 4 years ago
fragment_crash_reporter.xml For #7752, #7753: Adjust touch targets for elements in crash reporter. 4 years ago
fragment_create_collection.xml #4596 migrate collections (#5911) 5 years ago
fragment_create_shortcut.xml For #9435: Adjust margins and paddings to mirror correctly in RTL 4 years ago
fragment_delete_browsing_data.xml For #10706: Update copy of deleting open tabs preference. 4 years ago
fragment_edit_bookmark.xml Fix: Set correct height for EditText (#10014) 4 years ago
fragment_edit_custom_search_engine.xml Adds custom search engines (#6551) 5 years ago
fragment_edit_login.xml For #10173: login duplicates and save (#11208) 4 years ago
fragment_exceptions.xml For #7094 - Adds save login exceptions 4 years ago
fragment_history.xml For #8651 - Ensure FenixSnackbar has a proper root for inflating into 4 years ago
fragment_home.xml For #10281: Reduce logo margin to compensate top site padding increase. 4 years ago
fragment_installed_add_on_details.xml For #10552: Set initial add-on details fragment visibility to false (#10565) 4 years ago
fragment_locale_settings.xml For #12078: Follow ux mock on Settings --> Language screen 4 years ago
fragment_login_detail.xml For #11303 - Change copy login origin to open in browser 4 years ago
fragment_manage_site_permissions_exceptions_feature_phone.xml Issue 5366 Vector Drawable Compat (#6904) 5 years ago
fragment_manage_site_permissions_feature_phone.xml 8017 advanced autoplay controls. (#8978) 4 years ago
fragment_not_yet_supported_addons.xml Update NotYetSupported add-ons copy 4 years ago
fragment_pair.xml For #6198: Update copy and position of pair QR code scan message. 4 years ago
fragment_pwa_first_time.xml For #768: Add first time PWA dialog (#9308) 4 years ago
fragment_quick_settings_dialog_sheet.xml For #8591: Allow items in quick_action_sheet to be read by a11y services 4 years ago
fragment_saved_logins.xml For #10173: login duplicates and save (#11208) 4 years ago
fragment_search.xml For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014) 4 years ago
fragment_select_bookmark_folder.xml Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 5 years ago
fragment_share.xml For #2754 Add tab cards to share sheet (#5493) 5 years ago
fragment_sign_out.xml For #10851: Add end constraint for text view. 4 years ago
fragment_site_permissions_exceptions.xml For #9857: Create button style (#9858) 4 years ago
fragment_site_permissions_exceptions_item.xml Issue 5366 Vector Drawable Compat (#6904) 5 years ago
fragment_synced_tabs.xml For #10834 - Adding Sync Tabs Feature in Fenix 4 years ago
fragment_tab_tray_dialog.xml For #11342 - Fixes missing space for the FAB 4 years ago
fragment_tracking_protection.xml Add Tracking Protection Info Panel 5 years ago
fragment_tracking_protection_blocking.xml No issue: Move dp's to dimens.xml 4 years ago
fragment_turn_on_sync.xml For #9857: Create button style (#9858) 4 years ago
history_list_item.xml For issue #11835 - Update text fonts 4 years ago
layout_clear_permission_button.xml For #9857: Create button style (#9858) 4 years ago
layout_percentage_seek_bar.xml For #12105: Follow ux mock on Settings --> Accessibility screen 4 years ago
layout_url_background.xml Closes #6236: Fix padding lint issues (#6240) 5 years ago
library_site_item.xml For #8972 Replaced purple colors to match the rest of the app 4 years ago
list_element.xml Fixes #11134: Removes margin to allow collection title to expand 4 years ago
locale_settings_item.xml No issue: Move dp's to dimens.xml 4 years ago
logins_item.xml No issue: Move dp's to dimens.xml 4 years ago
migration_list_item.xml For #11004: Fix invisible text on migration UI 4 years ago
mozac_browser_menu_item_switch.xml For #1716 - Consolidate Switch Styles 5 years ago
mozac_ui_tabcounter_layout.xml For #5346 & For #8859: Fixes textSize & animation on TabCounter 4 years ago
navigation_toolbar.xml For #9505: Adds possibility to sort saved logins 4 years ago
no_collections_message.xml For issue #11835 - Update text fonts 4 years ago
onboarding_automatic_signin.xml Modified onboarding card colors according to design 4 years ago
onboarding_finish.xml For #9583: Increase touch targets for onboarding elements. 4 years ago
onboarding_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 5 years ago
onboarding_manual_signin.xml For #9583: Increase touch targets for onboarding elements. 4 years ago
onboarding_privacy_notice.xml For #9583: Increase touch targets for onboarding elements. 4 years ago
onboarding_private_browsing.xml For #8643 and #7606 - Changed styles for most onboarding cards 4 years ago
onboarding_section_header.xml No issue: Use ImageView rather than rebuilding drawable (#3616) 5 years ago
onboarding_theme_picker.xml For #10501 - use theme instead of tint to support older APIs 4 years ago
onboarding_toolbar_position_picker.xml For #10501 - use theme instead of tint to support older APIs 4 years ago
onboarding_tracking_protection.xml For issue #10764 - Onboarding toggle color 4 years ago
onboarding_whats_new.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 4 years ago
overlay_add_on_progress.xml Wire up UI to make add-on installation cancelable 4 years ago
pbm_shortcut_popup.xml For #10188: Fix layout constraints. 4 years ago
preference_cat_style.xml No issue: Move dp's to dimens.xml 4 years ago
preference_category_empty.xml For #11665: Adjust visual design for delete browsing data screens. 4 years ago
preference_default_browser.xml Close #420 - Default Browser Preference reacts to default browser status 5 years ago
preference_search_add_engine.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 4 years ago
preference_search_engine_chooser.xml Closes #877 - Add Search Engine Settings 5 years ago
preference_widget_radiobutton.xml No issue: Move dp's to dimens.xml 4 years ago
preference_widget_radiobutton_with_info.xml For #6180 - Set textAlignment to viewStart to fix RTL layouts. 4 years ago
private_browsing_description.xml For #10285: Swap TextView for a LinkTextView to improve a11y. 4 years ago
quicksettings_permissions.xml Closes #9529: changed styling for permissions dialog to set proper padding 4 years ago
quicksettings_tracking_protection.xml Bug 1643132 - Remove native "Report site issue" functionality. 4 years ago
quicksettings_website_info.xml For #6317 - Applies 3dot menuItem look to quickSettings and tracking panel 4 years ago
save_to_collection_button.xml For #9857: Create button style (#9858) 4 years ago
saved_logins_sort_items_toolbar_child.xml For #9505: Adds possibility to sort saved logins 4 years ago
search_engine_radio_button.xml For #12007: Follow ux mock on Settings --> Search screen (#12177) 4 years ago
search_suggestions_onboarding.xml For #10285: Swap TextView for a LinkTextView to improve links a11y 4 years ago
search_widget_cfr.xml For #9488: Add search widget CFR 4 years ago
search_widget_extra_small_v1.xml Issue #8277: Reuse app icon in widget layout. 4 years ago
search_widget_extra_small_v2.xml Issue #8277: Reuse app icon in widget layout. 4 years ago
search_widget_large.xml Fix ignored XML lint issues (#12094) 4 years ago
search_widget_medium.xml Fix ignored XML lint issues (#12094) 4 years ago
search_widget_small.xml For #8641 - Update addon text selector to use attr colors 4 years ago
search_widget_small_no_mic.xml Fixes #4894: added workaround for SDK<24 vector drawable with gradient color (#4944) 5 years ago
share_close.xml For #9545: Split button to allow distinct focus for a11y services. 4 years ago
share_tab_item.xml For #2754 Add tab cards to share sheet (#5493) 5 years ago
share_to_account_devices.xml For #4007 - Refactor AppShareView in standalone Share Views 5 years ago
share_to_apps.xml For #11177 - Load all share targets in the horizontal share menu 4 years ago
sign_in_preference.xml For #5497 Improve sync title/summary settings to support RTL 5 years ago
stub_find_in_page.xml For #4066: Provide lazy inflation of Find In Page View 5 years ago
switch_with_description.xml For #9805: Increase touch target for etp panel switch. 4 years ago
sync_tabs_list_item.xml For #11641: Update synced tabs view 4 years ago
tab_header.xml Issue 5366 Vector Drawable Compat (#6904) 5 years ago
tab_list_row.xml No issue - Add content descriptions when missing 4 years ago
tab_tray_item.xml For #12002: Show default tab background when thumbnail not available (#12041) 4 years ago
top_site_item.xml For #11666: TopSites layout from Constraint to Linear (#11669) 4 years ago
top_sites_header.xml For #9525 - Add bottom margin to top sites header 4 years ago
tracking_protection_category.xml No issue: Move dp's to dimens.xml 4 years ago
tracking_protection_learn_more_preference.xml For #6180 - Set textAlignment to viewStart to fix RTL layouts. 4 years ago
tracking_protection_onboarding_popup.xml For #11229: Update ETP cfr string and behaviour. 4 years ago
view_synced_tabs_group.xml For #12263 - Adds end margin to synced tabs header 4 years ago