Commit Graph

18 Commits (fad6417c16a5533d57140f8786fd7071ca5766c7)

Author SHA1 Message Date
Michael Comella 99600247bb No issue: move relevant files in :mozilla-lint-rules to perf pkg. 4 years ago
Michael Comella 5ba5ab9e6f For #15707: add ConstraintLayoutPerfDetectorTest.
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
4 years ago
Michael Comella 4b94215f59 For #15707: remove super.visitElement for ConstraintLayout lint.
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
4 years ago
Michael Comella 0a63362f95 For #15707: clean up lint rules dependencies.
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.

mozilla-lint-rules worked but they were not clean.
4 years ago
ekager f1cc9faed0 No issue - Update lint detector tests to run 4 years ago
Juan C. Goncalves eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 4 years ago
Sebastian Kaspari 2da24cd91d
Update Android Components, Kotlin, Gradle plugin (#16021)
* Closes #13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Juan C. Goncalves 6d699105ad
For #8947 - Lint check for licenses in Kotlin/Java source files (#15639) 4 years ago
ekager 4d348dd26a Fixes existing lint errors 4 years ago
Michael Comella aeb0205ea5 For #15644: update Android Gradle Plugin version.
This ensures our custom lint rules are running on the command line.
4 years ago
Michael Comella 8893468102 For #15280: add ConstraintLayoutPerfDetector custom lint rule. 4 years ago
Michael Comella 1cc2ecdc7c No issue: minimize Button...Detector violation location.
This changes the error highlighting from being the entire contents of
<Button ...> to just the first line of <Button>.
4 years ago
TangHuaiZhe 76f240bad0 Update mozilla-lint-rules/src/main/java/org/mozilla/fenix/lintrules/TextViewAndroidSrcXmlDetector.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Tang HuaiZhe 16b3b7a1b5 Fix the comment of TextViewAndroidSrcXmlDetector. 4 years ago
Elise Richards 4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Mihai Branescu 048d22dbcf For #8643 and #7606 - added styles and new colors 4 years ago
Sawyer Blatz 8185ba793e
For #9857: Create button style (#9858)
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
4 years ago
ekager 414e905b76 Closes #8944 - Adds custom lint checks 4 years ago