Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
Some improvements to the Homescreen!
* Do not show collections placeholder in home screen on a clean install and subsequently as well.
* Increase the limit for top sites to 160
* Show 20 top sites on the screen at a time, before pagination occurs.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
Enabling release automation!! We can now create releases automatically by simply pushing a tag to the repo. Instructions in the README. Updated README to have some emojis that will make some important instructions pop out!
Plus minor fix to the PR template file that creates the boilerplate below.
* Update screenshot for comment with one non-members will see
* Update PR template with instructions suitable for our fork
* Allow users to skip CI checks if necessary
Stefan Arentz
mcarare
Ben Hearsum
Abhijit Valluri
Michael Comella
Abhijit Kiran Valluri
Nikita Epifanov
Sebastian Kaspari
Andrew Gaul
ekager
TrianguloY
Tiger Oakes
Sören Hentzschel
Mozilla L10n Automation Bot
Christian Sadilek
Johan Lorenzo
interfect