The shopping.surface_reanalyze_clicked event was sent everytime
the review checker sheet was opened while a product was being
reanalyzed. This patch fixes it by sending a separate telemetry
action for the button.
(cherry picked from commit 5149fb715af82a1c79e47fe7e0d8ea8be8ff8dc5)
Added `surface_powered_by_fakespot_link_clicked` telemetry probe
that is sent when the user taps the "Powered by Fakespot by Mozilla"
footer link in Review Checker Sheet.
(cherry picked from commit 07c669052ac15cf7aa968f9a23584fac0ec3538d)
Rather than tracking that the CFR was shown to the user when the
user explicitly interacts with it (dismiss or action tap),
we will track it when the CFR was shown, not considering how the
user dismissed it.
(cherry picked from commit 1803de59619a12c68e20c582d74ca25b971ba402)
Using `.inc()` was wrong due to it returning the incremented
value and not incrementing the already existing one. This
patch aims to fix that, therefore showing the CFR correctly
for max 3 times.
(cherry picked from commit 67b68c948b76ea86294c91d520ee0b58d3b31fdf)
The current onboarding CFR is set to show the first time someone
lands on a product detail page. If the user dismisses the CFR and
does not opt-in, we show it on the next product detail page after at
least 24 hours have elapsed.
This patch changes this to showing the CFR up to 3X (instead of 2)
with at least 12 hrs in-between (instead of 24).
(cherry picked from commit dddeecc082a9be8dcc53caddc5bec79753fff9bb)
This commit:
* Adds new facts, `wikipedia_suggestion_clicked` and
`wikipedia_suggestion_impressed`, to the `feature-fxsuggest`
component.
* Emits `fx-suggest` Glean pings for those facts in Fenix's
`MetricController`.
(cherry picked from commit a98251ffdfdb3d945927706dc859feff9694a4f4)
We recently made a change to the shopping CFRs that made them harder
to dismiss. They can only be dismissed by clicking the close X or
by clicking the link that opens the bottom sheet. The issue is that
this results in the page and the UI being unresponsive. So we want
to revert back to the original behavior where they were
dismissible by clicking outside. This change currently only affects
the shopping CFR
(cherry picked from commit 511b2824339d4297c493bfc80d8b383ffe9d4f15)
In Firefox Desktop, sponsored and non-sponsored suggestions aren't
shown in private windows, even when the "Show search suggestions in
Private Windows" option is checked. This commit makes Fenix's behavior
match Desktop's.
(cherry picked from commit 1258f6cb2fc1acf0804365b87fd9145e7309b6f5)
This commit adds the following measurements:
* A new value for the `fx_suggest.ping_type` metric,
`fxsuggest-impression`.
* An `fx_suggest.position` metric to capture the position of the
Firefox Suggest search suggestion in the awesomebar, for impressions
and clicks.
* An `fx_suggest.is_clicked` metric, to capture whether an
`fxsuggest-impression` ping is for a clicked suggestion.
This commit also:
* Mounts `FxSuggestFactsMiddleware` to collect facts for impressions
and clicks.
* Dispatches `AwesomeBarAction`s from the `SearchDialogController` in
response to user interactions with the awesomebar and toolbar.
(cherry picked from commit ca5cb4bdbdff0bf67bb763497e53ceeef43a69fd)
This commit builds on bug 1857092 to record impressions for sponsored
Firefox Suggest search suggestions, and moves the logic for recording
clicks to the same middleware.
An impression means, "did the user see a suggestion when they finished
engaging with the awesomebar?" A "finished engagement" means the user
navigated to a URL, a search results page, or a shown suggestion.
We don't record impressions for:
* Suggestions that the user sees as they're typing.
* Abandoned engagements, when the user dismisses the awesomebar without
navigating to a destination.
If the user taps on a Firefox Suggest suggestion, we record an
impression _and_ a click for that suggestion. If they tap on any other
suggestion, or navigate to a URL or search results page, we record an
impression only.
The new `FxSuggestFactsMiddleware` in this commit observes the
`EngagementFinished` action added in the last commit, and emits facts
for impressions and clicks.
(cherry picked from commit 196e46c25beba770227dde1594034b1275a450e5)
* In Nightly and debug builds, the secret setting is shown
(via `FeatureFlags.fxSuggest`), and the feature is enabled by default
via the `fx-suggest.enabled` Nimbus variable.
* In Beta and Release, we still want to show the secret setting, but
disable the feature by default.
(cherry picked from commit d89724e922a836be24a58ee0c9d66af088d7f393)
Added a new probe `product_page_visits` which counts the number of
visits to a supported retailer product page.
(cherry picked from commit fbd860cb37334374806b835ad548b82e050c820a)
In order to eliminate the "jumping"/"spring" animation that reveals
views under bottom sheet, we will wrap the scaffold in a surface.
This way we will be able to keep the animation.
DreVla
Harrison Oglesby
Lina Butler
Noah Bond
Arturo Mejia
mike a
rahulsainani
jackyzy823
AndiAJ
Jeff Boek
Gabriel Luong
Tif Tran
Zac McKenney
William Durand
Sammy Khamis
Alexandru Putanu
sarah541