Commit Graph

41 Commits (ebfc9edc79545dfa8f647cef6c5d24303e4f5fa8)

Author SHA1 Message Date
mike a ebfc9edc79 Bug 1879648 - Disable menu toolbar when nav bar is enabled 3 months ago
Ryan VanderMeulen 71c3287f1c Bug 1862658 - Fix OutdatedDocumentation errors
Behavior change from https://github.com/detekt/detekt/pull/6372.
7 months ago
Gabriel Luong 978871c859 Bug 1848527 - Part 1: Enable OutdatedDocumentation detekt rule in Fenix 8 months ago
Gabriel Luong 8e5c1b6de8 Bug 1840210 - Rename mozac_ic_search to mozac_ic_search_24 11 months ago
Gabriel Luong 6a6c73b86a Bug 1840210 - Rename mozac_ic_refresh to mozac_ic_arrow_clockwise_24 11 months ago
Gabriel Luong 804e589262 Bug 1840210 - Rename mozac_ic_forward to mozac_ic_forward_24 11 months ago
Gabriel Luong 082104417a Bug 1840210 - Rename mozac_ic_back to mozac_ic_back_24 11 months ago
t-p-white 45a45e567b Bug 1823892 - Added option to not show 'Open in Firefox' and 'POWERED BY FIREFOX' menu items in Custom tab 1 year ago
mcarare 932823c871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26844: Fix ktlint issues and remove them from baseline. 2 years ago
Gabriel Luong bd6c1cadda [fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename disabled attribute to textDisabled 2 years ago
Gabriel Luong 53dc0a74c4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24252 - Rename primaryText attribute to textPrimary 2 years ago
Gabriel Luong 98a540b81d [fenix] For https://github.com/mozilla-mobile/fenix/issues/23350 - Revert changes from removing duplicate icons that already exists in ui-icons (https://github.com/mozilla-mobile/fenix/pull/23527)
* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Override @color/mozac_ui_icons_fill with ?primaryText attribute"

This reverts commit 4c630eba96182254daa4cdd2bbfeac23ab04690d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_share with @drawable/mozac_ic_share"

This reverts commit 072d3a3c9f87b77ed6381c36af7d9c812b8b371d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_storage_enabled with @drawable/mozac_ic_storage"

This reverts commit 10dde2baa6fd320443690a49dd6551938a2d83db.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_notifications_enabled with @drawable/mozac_ic_notification"

This reverts commit 90943cfda427fd06d5e77b1e4fd0463bbe21e449.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_microphone_enabled with @drawable/mozac_ic_microphone"

This reverts commit 200fd14d288b4b21c1711995f63d548f58fb1dc8.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_location_enabled with @drawable/mozac_ic_location"

This reverts commit e85998bdc24dcdd17585581bd99aab35d5147f93.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_autoplay_disabled with @drawable/mozac_ic_autoplay_blocked"

This reverts commit 0e408dc26e069719c895ae5279d3c11df6677699.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_camera_enabled with @drawable/mozac_ic_video"

This reverts commit ceab2d77490b9b9b545ebbc14ee2a7b3811d3064.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/mozac_ic_extensions_black with @drawable/mozac_ic_extensions"

This reverts commit 7bc005927acee0481c8936d000737ba7f738e2ba.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_top_sites with @drawable/mozac_ic_pin"

This reverts commit f4d58ff722baa5dc9f7f811a758de75699bb8ccb.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_search with @drawable/mozac_ic_search"

This reverts commit ac8f8632557ac07c32d040fbb0ddfa3cf1a0e5f6.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_readermode with @drawable/mozac_ic_reader_mode"

This reverts commit d1953045b062a5b6fbedd990252834e9e1a6ca4f.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_menu with @drawable/mozac_ic_menu"

This reverts commit 682b02101aa7e5ce82868de81d9b034701629976.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_login with @drawable/mozac_ic_login"

This reverts commit 982c695260aaa10fc1f0ee7e6d2e271e9a214ce3.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_internet with @drawable/mozac_ic_globe"

This reverts commit d248bfc21fff644bdc2141c4e24ae5bc125a41d2.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_download with @drawable/mozac_ic_download"

This reverts commit 4cdceb393ac411a7b59d9c0e1164fddfb62bc494.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_lock with @drawable/mozac_ic_lock"

This reverts commit 3878a83e30f318293b099bc49c690f953c2f3def.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop"

This reverts commit 8c4e6e23e0bf1ed762d9c3ab8566aff4df0a8eb1.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_close with @drawable/mozac_ic_close"

This reverts commit 7f61c95923600eeabb8046380a31c1eaa4968525.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_delete with @drawable/mozac_ic_delete"

This reverts commit b8814f62bffde0c192f078f8cd5e808d0f07af9d.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_up with @drawable/mozac_ic_arrowhead_up"

This reverts commit 265b0a47cae6bed39ce9e8cc9af465705d1a2363.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_chevron_down with @drawable/mozac_ic_arrowhead_down"

This reverts commit fe8a0b604941bbbb9dacff176cd17ce0485431ed.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_back_button with @drawable/mozac_ic_back"

This reverts commit fb236b1c6175c1f8b5e6b1bf6d9f02c6a7fff9b9.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_arrowhead_right with @drawable/mozac_ic_arrowhead_right"

This reverts commit ae2f768ac02aa6b161b0bcbba7922f5f12e31e80.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_new with @drawable/mozac_ic_new"

This reverts commit ce5bb35a7cdbd189bb177900ec19bc6cb5a9bfa7.

* Revert "For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawable/ic_addons_extensions with @drawable/mozac_ic_extensions"

This reverts commit 1006637673965ebf70ad5e18e9a3598cf736347b.
2 years ago
Gabriel Luong 5a66fd7824 [fenix] For https://github.com/mozilla-mobile/fenix/issues/23121 - Replace @drawble/ic_desktop with @drawable/mozac_ic_device_desktop 2 years ago
Gabriel Luong e0d4f0b496 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22793 - Rename fx_mobile_icon_color_notice color token to fx_mobile_icon_color_information 3 years ago
Gabriel Luong e7f3dd478a [fenix] For https://github.com/mozilla-mobile/fenix/issues/22701 - Replace whats_new_notification_color with fx_mobile_icon_color_notice color token 3 years ago
Sebastian Kaspari d9ca412bec [fenix] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0). 3 years ago
mcarare 90eb9cfad5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/17117: Use proper custom tab session for custom tab toolbar menu. 3 years ago
Christian Sadilek de8ef956c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11290: Refactor ToolbarMenu to use browser store 4 years ago
ekager 74b4866e3d [fenix] Fixes existing lint errors 4 years ago
Kainalu Hagiwara 6bdb31ddd8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12926 - Add back button to menu. 4 years ago
Jeff Boek 42582369aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/2681 - Adds ability to bypass cache when reloading 4 years ago
Kainalu Hagiwara 9d3f8a7e0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1048 - Add ability to view tab history by long-pressing the back or forward button. 4 years ago
ValentinTimisica c0de686fc6 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9205: Changes add-ons and 'Open links in apps' icons from menus 4 years ago
Roger Yang d26bd5ab45 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10906: Add Open in app option in custom tab (https://github.com/mozilla-mobile/fenix/pull/10929) 4 years ago
mcarare fca63c72d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9698: Use extension to ensure fallback to English and avoid crash 4 years ago
Tiger Oakes 85526e4fa7 [fenix] Clean up toolbar menu class 4 years ago
Tiger Oakes 2cf4af1c39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7431: Remove extra share button 4 years ago
mcarare fd06352b8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/7155 Align custom tabs overflow menu to original mocks
Reverse menu items order when toolbar position is top
4 years ago
Tiger Oakes cd4f41aa6a [fenix] For https://github.com/mozilla-mobile/fenix/issues/6830 - Fix "Open in" text size for custom tab (https://github.com/mozilla-mobile/fenix/pull/7010) 5 years ago
Severin Rudie 2e76d82c9a [fenix] 4281 remove qab (https://github.com/mozilla-mobile/fenix/pull/6310)
* For https://github.com/mozilla-mobile/fenix/issues/4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
5 years ago
Tiger Oakes 41e1c322a6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6153 - Add powered by notification 5 years ago
Tiger Oakes cf9ace2cc1 [fenix] Move classes out of top-level package 5 years ago
Tiger Oakes 8d3020ebcf [fenix] No issue: Normalize license header comment (https://github.com/mozilla-mobile/fenix/pull/3909) 5 years ago
Emily Kager 298be38e35 [fenix] For https://github.com/mozilla-mobile/fenix/issues/203 - Adds find in page and request desktop site to custom tab menu (https://github.com/mozilla-mobile/fenix/pull/3835) 5 years ago
Emily Kager 46e5afb0af [fenix] For https://github.com/mozilla-mobile/fenix/issues/3087 - Adds disabled color attr (https://github.com/mozilla-mobile/fenix/pull/3192)
* For https://github.com/mozilla-mobile/fenix/issues/3087 - Adds disabled color attr

* Change alpha to 40%
5 years ago
Jeff Boek 708aa16d1c [fenix] For https://github.com/mozilla-mobile/fenix/issues/2723 - Fixes theme manager 5 years ago
jhugman 1d4e9fc212 [fenix] Fixes 1689 - Add sessionManager and sessionId to custom tabs menu and toolbar. (https://github.com/mozilla-mobile/fenix/pull/2229) 5 years ago
Emily Kager 438461a75e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2172 - Tint Share Icon in Custom Tab Menu 5 years ago
Sawyer Blatz 31a9dbea4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/1092: Fixes ordering of custom tab menu items (https://github.com/mozilla-mobile/fenix/pull/2072) 5 years ago
Emily Kager 07fbeaeeba [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/1914 - Removes incomplete actions from Custom Tab Menu 5 years ago
Sawyer Blatz cd56129a63 [fenix] For https://github.com/mozilla-mobile/fenix/issues/668: Restyles custom tabs 5 years ago