iceraven-browser

Commit Graph

Author	SHA1	Message	Date
Severin Rudie	aa8642f534	#4596 migrate collections (#5911 ) * For #4596: move code from CollectionCreationComponent to CollectionCreationStore Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable. * For 4596: update CollectionCreateStore to libstate * For 4596: copied CollectionCreationUIView into CollectionCreationView Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable. * For 4596: update CollectionCreationView to LibState Note that the minimal changes possible to enable migration were made. Refactoring will happen in a later commit. * For 4596: updated CollectionCreationTabListAdapter to work with the new View * For 4596: updated SaveCollectionListAdapter to work with the new View * For 4596: implemented CollectionCreationController For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer * For 4596: copied over previous reducer code No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer * For 4596: update reducer code param names Otherwise, no changes at this time * For 4596: add arguments to CreateCollectionFragment in nav_graph These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture. * For 4596: pass arguments to collection via transaction instead of VM The VM will be removed in a later commit * For 4596: update BrowserToolbarController to share state to collection via its Direction * For 4596: removed CreateCollectionViewModel * For 4596: test tab retrieval in CreateCollectionFragment * For 4596: fix crashing CreateCollectionFragmentTest * For 4596: removed classes create collection classes used by old architecture * For 4596: collection interactor rename + kdoc * For 4596: moved collection interactor interface * For 4596: renamed CreateCollectionFragment All related classes followed the pattern of CollectionCreationX * For 4596: kdoc CollectionCreationController There's no effective difference between these calls and their interactor equivalent, so I linked to them * For 4596: fix bug that caused rename to not work * For 4596: removed unused collection actions These were unused before the LibState refactor * For 4596: kdoc StepChanged * For 4596: removed todos about moving logic to the reducer saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here stepBack: called by handleBackPress. See above * For 4596: wrote tests for CollectionCreationController#stepback * For 4596: fixed tests broken by changes to collections * For 4596: small readability refactor for CollectionController#stepBack No change to functionality (see tests) * For 4596: broke apart CollectionView#update There's probably a lot more that could be done here, but smaller changes were made to reduce scope * For 4596: remove unnecessary todos It looks like we don't follow the suggested pattern in this project * For 4596: test CollectionCreationController#normalSessionSize * For 4596: updated naming in CollectionCreationController per review	5 years ago
Tiger Oakes	ac6c1ec2ee	Closes #2690 - Clean up CreateCollection viewmodel (#4731 )	5 years ago
Tiger Oakes	6da6ddb095	Use StateListDrawable & resources w/ TabCollection	5 years ago
Tiger Oakes	ef8d9604ae	No issue: Normalize license header comment (#3909 )	5 years ago
Tiger Oakes	8cd1a0cb38	Move adapter Job setup code to helper class (#3407 )	5 years ago
Tiger Oakes	4994554576	No issue: Adds lint exception for when statement (#3685 )	5 years ago
Tiger Oakes	30930cdc88	Import variables referred to by path	5 years ago
Sawyer Blatz	decacbfc97	For #3323 Runs PublicSuffixList synchronously	5 years ago
Sawyer Blatz	45c509fbce	For #2648 : Updates trimming of url hostname (#3191 ) * For #2648: Updates trimming of url hostname * For #2648: Fix nits	5 years ago
Emily Kager	0327b1146b	For #2977 - Update add new collections flow (#2991 ) * For #2977 - Update add new collections flow * Rename shared elements to be more general * Make tab list not clickable in other modes * For #2577 - Stop Flickering in List * Add extensions function for next step with collections list size	5 years ago
Sawyer Blatz	549292d06e	For #2732 : Removes view model usage from collection creation	5 years ago
Sawyer Blatz	7861a80715	For #2205 : Truncates tab collection titles	5 years ago
Sawyer Blatz	4e6f9b9ef1	For #1574 : Displays previous tab collections when creating	5 years ago

13 Commits (aa8642f534b6acf63c3e2c74364ea8b406070fea)