Commit Graph

21 Commits (aa49ab1dfb495fb4e2b5595bb76ceecc18c70b61)

Author SHA1 Message Date
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
5 years ago
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
5 years ago
ValentinTimisica 1e13e70cd0 Fixes #5917: Show snackbar when URL is copied (#6210)
Show a snackbar to the user for him to know that the URL was copied to
clipboard.
5 years ago
Sebastian Kaspari 9543f38978 Use new toolbar API of AC 18.0.0. 5 years ago
Emily Kager f9afd97a68 For #1901 - Get rid of black flash when leaving GV Engine 5 years ago
Mihai Adrian 236f702bbe For#5468 Changed info source for url clipboard copy from view to session (#5514) 5 years ago
Sawyer Blatz 2db2d9ceae For #1744: Adds tests for clipboard 5 years ago
Sawyer Blatz fd1fcd8b89 For #4155: Adds paste & go for search terms 5 years ago
Sawyer Blatz e961a9d63d For #1744: Adds clipboard provider to search engine screen 5 years ago
Sawyer Blatz 42b31f0088 For #4155: Adds elevation to copy/paste menu 5 years ago
Sawyer Blatz 5586b18c3e For #4155: Handle custom tabs & fix test 5 years ago
Sawyer Blatz 9d30d7bb03 For #4155: Restyle to custom menu 5 years ago
Sawyer Blatz 52fd327bc0 For #4155: Adds tests for browser toolbar popup menu 5 years ago
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 5 years ago
Sebastian Kaspari ac32a88d45 Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action. 5 years ago
Tiger Oakes c475bc87cf Move classes out of top-level package 5 years ago
Mihai Adrian df3e1bf9d3 Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode (#4810)
RequestDesktopStateProvider was taken from private instead of desktopMode
5 years ago
Colin Lee d1aed157dd
For #4686: Fix potential security issue (#4764) 5 years ago
Emily Kager 0b98d43c23 Closes #4602 - Add back transitions 5 years ago
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
Sawyer Blatz 6fa022c2f8
For #4124: Migrate BrowserToolbar to Libstate (#4279)
* For #4124: Migrate BrowserToolbar to Libstate

* Restores QuickActionSheetReducer

* Improve tests

* Make QuickActionSheetController

* Finalize tests

* Breaks out QuickActionSheetState

* Fix comments

* Adds BrowserStoreTest
5 years ago