11 Commits (990bfa7e6dd5894d61473a41da6129e6947974e2)

Author	SHA1	Message	Date
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Arturo Mejia	869c99afaa	For #15372 Optimize the order and messages of onboarding cards	3 years ago
Elise Richards	433a20db50	Update string for FxA signin onboarding header (#14132)	4 years ago
Elise Richards	feae7fff2f	FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317) ... * Replace strings, add learn more, hook up button * Constrain learn more and icon to the text * View holder tests * Lint * Update homescreen ui test	4 years ago
Tiger Oakes	d4bb432e24	Add helper for underlining text (#12520)	4 years ago
Elise Richards	665fb8d60c	#10824: Onboarding telemetry (#11867) ... * Onboarding events and tracking * Rename metrics for consistency * Add reference to PR for the data review * Add default values to onboarding events	4 years ago
Tiger Oakes	f7b4f1c959	Cache findViewById calls in session control (#10575)	4 years ago
Jeff Boek	4cbb9aebaf	Cleans up nav_graph.xml (#9829) ... * For #9751 - Cleans up homeFragment directions * For #9751 - Uses global actions for fragments not owned by homeFragment * For #9751 - Cleans up SearchFragment directions * For #9751 - Removes settings action from DeleteBrowsingDataFragment * For #9751 - Removes browser action from SettingsFragment * For #9751 - Adds ManagePhoneFeature global action * For #9751 - Clean up unused deletebrowsingfragment actions * For #9751 - Cleans Up HistoryFragment actions * For #9751 - Removes Home -> Search action * For #9751 - Removes the Bookmark -> Browser action * For #9751 - Cleans up bookmark fragment actions * For #9751 - Cleans up actions from ShareController * For #9751 - Removes defaultBrowserFragment to browserFragment action * For #9751 - Removes about -> browser action * For #9751 - Adds global action to TrackingProtectionFragment * For #9751 - Removes exception -> browser action * For #9751 - Removes login -> browser action * For #9751 - Fixes LoginFragment directions * For #9751 - Removes ExternalAppBrowser directions * for #9751 - Cleans up actions * For #9751 - Fixes unit tests * For #9751 - Addresses nits in PR	4 years ago
Patrick Martin	71880705df	For #5711 - Onboarding colours have contrast issues	4 years ago
ekager	015922ddd2	No issue: Fix Crash lower API by setting gradient drawables in onBind	5 years ago
Grisha Kruglov	ae33234bbc	Closes #2593: FxA automatic sign-in integration	5 years ago