13 Commits (990bfa7e6dd5894d61473a41da6129e6947974e2)

Author	SHA1	Message	Date
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Elise Richards	761d6babb9	For #18806: Show sync tabs or sync account sign in based on feature flag (#18859) ... * Show sync tabs or sync account sign in based on feature flag. Sign in navigates to account settings on click. * lint and nits	3 years ago
Arturo Mejia	db9b3676d3	For #18608 Add experiment for set default browser MenuItem.	3 years ago
Elise Richards	ca33aef036	For #17770: New tab three-dot menu reorder (#18427) ... * Create new menu order for new tab * Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent. * Lint Lint and refactoring tests * Tests for default toolbar menu * Feature flag for request desktop site Add todos for UI test issue 17979 Add todos for UI tests	3 years ago
Mihai Adrian Carare	5c7a01ba6f	For #17971: Add Reader view appearance controls in three-dot main menu. (#18340)	3 years ago
Christian Sadilek	c9b8f57f96	Refactor BrowserToolbarMenuController to use browser store	3 years ago
Elise Richards	d0fd3e82c5	For #17771: three-dot menu reorder (#17838) ... * Feature flag for toolbar menu redesign. Add new items to menu and reorder. * Handle toolbar items in menu controller * Menu controller tests * Make icons invisible * Lint * UI tests reflect design change * Refactor test names * Lint fixes * UI tests	3 years ago
Sebastian Kaspari	788a8309c2	Issue #16435: Open custom tab in Fenix: Force launch outside of and remove current task.	4 years ago
mcarare	9748c65c71	For #15413: Use proper url when bookmarking a page.	4 years ago
mcarare	21a67de947	For #15379: Use proper url when sharing.	4 years ago
ekager	9a2103a9a7	For #13934 - Make TabHistory work on PWA/Custom Tabs	4 years ago
Gabriel Luong	6d133c8d0c	For #14529 - Show a dialog when the top sites limit has been reached	4 years ago
Tiger Oakes	ace6b99c89	Split toolbar controller into two classes (#13854)	4 years ago