Commit Graph

21 Commits (978871c8590373dd2633f0f94e52b9f334f1c949)

Author SHA1 Message Date
Gabriel Luong 978871c859 Bug 1848527 - Part 1: Enable OutdatedDocumentation detekt rule in Fenix 8 months ago
BFadairo 0f596b22d5 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/27854: Remove unnecessary Theme.getTheme() calls from FirefoxTheme usages 2 years ago
Noah Bond 9640057475 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26520 - Color homepage cards via wallpaper card colors 2 years ago
mcarare 932823c871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26844: Fix ktlint issues and remove them from baseline. 2 years ago
Mugurell 58e6ebb9b8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26830 - Allow the Pocket stories to scroll to the edges of the screen
Restore using LazyRow's "contentPadding" property to add padding to just the
items while the entire section is allowed to extend to the edges of the screen
and so have enough room to draw items shadows without them being clipped.
2 years ago
mcarare 8e99bc1852 [fenix] For https://github.com/mozilla-mobile/fenix/issues/26444: Replace SectionHeader with HomeSectionHeader for home sections. 2 years ago
Alexandru2909 ae62eb26cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/24528 - Remove isPrivate conditional in getTheme in favor of inComposePreview 2 years ago
Mugurell 0c972d3ae9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25401 - Record Pocket sponsored stories telemetry 2 years ago
MatthewTighe 374ce89abb [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/25545: wait to draw Pocket until after first frame 2 years ago
Mugurell 300de19e05 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Improve stories impressions recording.
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
2 years ago
Mugurell 364842f946 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25281 - Pace and rotate sponsored stories
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2 years ago
Mugurell 4c02271ae0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Old imports cleanup.
Importing `R.string` does allow to avoid the `R` when using a String from
Resources but seems like a small gain to break app consistency.
2 years ago
Mugurell f28fbf3240 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Use the `PocketStory` supertype
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2 years ago
Mugurell 15677b59b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/25025 - Hardcode showing at max 8 Pocket stories
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2 years ago
Gabriel Luong 08931906b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24519 - Add Private theme to FirefoxTheme 2 years ago
Gabriel Luong fa71851b96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/24114 - Refactor HomeFragmentStore parameters to AppStore 2 years ago
Mugurell 33772a15aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/24342 - Actually log when Pocket stories are shown
Based on this we'll send telemetry and rotate the stories shown to prioritize
fresh ones instead of the ones already shown.
2 years ago
sunil9211 1971f8984c [fenix] For https://github.com/mozilla-mobile/fenix/issues/23551 - Change the spacing between Pocket header and content to 16dp 2 years ago
Mugurell 795683c6ef [fenix] For https://github.com/mozilla-mobile/fenix/issues/21854 - Split the big ComposeView in 3 smaller ones
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
mcarare e297e494c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/22383: Propagate ViewTreeLifecycleOwner to composable view holders. 2 years ago
Gabriel Luong 2c4ccea6cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/21753 - Refactor Pocket out of sessioncontrol 3 years ago