12 Commits (9654b4dfb122b54b04369fe80a2f9c95811478e8)

Author	SHA1	Message	Date
Gabriel Luong	9654b4dfb1	For #27667 - Remove import-ordering from the list of disabled ktlint rules	2 years ago
mcarare	ffcef5ff2e	For #26844: Fix ktlint issues and remove them from baseline.	2 years ago
Mugurell	bc59ede073	For #22722 - Reacting to the crashed flag ... Whenever the ".crashed" property of the currently displayed TabSessionState -> EngineState is true we will show an in-app crash reporter with the usual close tab / restore tab options and also the option to report all current non-fatal crashes to Mozilla if the setting for sending the crash reports is enabled in app settings. This closely mimics the previous crash reporter UI but there might be some subtle differences stemming from migrating to using a ComposeView. Whenever the ".crashed" property of the currently displayed TabSessionState -> EngineState is false we will set the in-app crash reporter to have a View.GONE visibility effectively removing it from the layout. The functionality for receiving the non-fatal crashes from the AC CrashReporter through an Intent is still kept and these crashes will be persisted in memory until the user closes / restores a tab and so also makes a decision about sending or not these crashes. Currently more tabs can crash following just one since more share the same process and as such there is no way to differentiate between them or link a certain Crash to a certain tab. They will all be acted upon at once from any tab the user chooses to close or restore.	2 years ago
Elise Richards	4f55f16bd7	For #21313: Remove expiring/unused metrics for December (#21789) ... * Remove crash reporter metrics * Remove tab counter menu item probe Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>	3 years ago
Roger Yang	74c1cc82fb	Closes #19921: Update appcompat and fragment dependencies to 1.3.x	3 years ago
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Christian Sadilek	f96fdc34eb	Refactor CrashReporterFragment to use browser store	3 years ago
Mihai Eduard Badea	02bd0cc203	For issue #8648	4 years ago
Jeff Boek	4cbb9aebaf	Cleans up nav_graph.xml (#9829) ... * For #9751 - Cleans up homeFragment directions * For #9751 - Uses global actions for fragments not owned by homeFragment * For #9751 - Cleans up SearchFragment directions * For #9751 - Removes settings action from DeleteBrowsingDataFragment * For #9751 - Removes browser action from SettingsFragment * For #9751 - Adds ManagePhoneFeature global action * For #9751 - Clean up unused deletebrowsingfragment actions * For #9751 - Cleans Up HistoryFragment actions * For #9751 - Removes Home -> Search action * For #9751 - Removes the Bookmark -> Browser action * For #9751 - Cleans up bookmark fragment actions * For #9751 - Cleans up actions from ShareController * For #9751 - Removes defaultBrowserFragment to browserFragment action * For #9751 - Removes about -> browser action * For #9751 - Adds global action to TrackingProtectionFragment * For #9751 - Removes exception -> browser action * For #9751 - Removes login -> browser action * For #9751 - Fixes LoginFragment directions * For #9751 - Removes ExternalAppBrowser directions * for #9751 - Cleans up actions * For #9751 - Fixes unit tests * For #9751 - Addresses nits in PR	4 years ago
Tiger Oakes	ea486d7c66	Split out CustomTabToolbarIntegration (#7107)	5 years ago
Roger Yang	e9760fb185	Closes #5847: Use IO thread when submitting crash report	5 years ago
Tiger Oakes	172a9cf06c	Extract and test crash reporter code	5 years ago