Commit Graph

12 Commits (9654b4dfb122b54b04369fe80a2f9c95811478e8)

Author SHA1 Message Date
Gabriel Luong 9654b4dfb1 For #27667 - Remove import-ordering from the list of disabled ktlint rules 2 years ago
mcarare ffcef5ff2e For #26844: Fix ktlint issues and remove them from baseline. 2 years ago
mcarare dbc329f8b6 For #24210: Remove wrapper from copy url event. 2 years ago
Grigory Kruglov cbd0c07c6f For #23697: Allow pasting plain text in toolbar long press 2 years ago
Grigory Kruglov 5daa06f7dc For #23697: Avoid NPEs while pasting URLs from the clipboard
It's possible for clipboard contents to have changed in the time between we've constructed
the onClick listeners and when they're actually invoked. Code before assumed that 'text'
will be not-null, and would crash otherwise. With this change, we're capturing contents of
the clipboard before constructing onClick handlers (while also asserting correct behaviour
of 'ClipboardHandler').

With this change, we'll log an error if we were told that clipboard contains a URL, but immediately
after that check 'text' was actually null. This would indicate one of two things:
- issues within the ClipboardHandler
- changing contents of the ClipboardHandler within a tiny time window between our check and querying
2 years ago
Arturo Mejia 94a543a403 For #22271 Improve URL accessing from the clipboard for Android 12 and above. 3 years ago
Mugurell 621c388c12 For #17917 - Finish migrating all synthetics usages 3 years ago
Roger Yang a8c53c6bf1
Closes #17791: Use updated URL with custom tabs when copying to clipboard (#18590) 3 years ago
Christian Sadilek 2d87307144 Remove remaining usages of Session[Manager] in BrowserFragment 3 years ago
mcarare 01db5160ee For #16827: Add copy url from long press metrics. 4 years ago
ekager 0f0aee5e97 For #6846 - Don't show ToolbarPopupWindow if nothing to show 4 years ago
ekager e5e62fa79a For #6846: Added quick actions for nav bar in home 4 years ago