958474f9fb
For #13157 : Filter out folder being edited from 'select folder' dialog
4 years ago
fe288edb5d
Rename 'visitedAddBookmark' arg to a less confusing name
4 years ago
24de85f805
Remove unused nav arg from 'select folder'
4 years ago
410980fe27
For #11425 : Improve editing bookmarks flow.
4 years ago
1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
4 years ago
ee62297b4c
For #7854 - Update the views only if the bookmark node has changed
...
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.
Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
4 years ago
02bd0cc203
For issue #8648
4 years ago
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
4 years ago
b8fba63be4
For #9890 - Do not display full screen snackbar with toolbar padding
4 years ago
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
4 years ago
e318cd7d15
fix #8135 - remove getColorFromAttr
4 years ago
c0d7bc5bd5
Use navArgs helper in fragments
4 years ago
5e9b753acb
For #7473 , delay inflation of toolbar
...
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
4 years ago
e291c6905c
For #3813 - Create a save button for bookmark editing
4 years ago
9cbc3f7a4a
7410 remove rxjava ( #7426 )
...
* For #7410 : rewrite updateBookmarkFromObservableInput with coroutines
* For 7410: remove RxJava from project. :(
* For 7410: converted updateBookmarkFromTextChanges to Flow per review
4 years ago
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
4 years ago
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
4 years ago
8d68317388
4844 fix url elision ( #6588 )
...
* For #4844 : add test cases for url elision
* For 4844: implement toShortUrl to pass test cases
* For 4844: update plumbing to use toShortUrl
* For 4844: adds/handles suggested url elision test case
5 years ago
432d5fbff4
For #5848 Wrong toolbar colour - edit bookmark fragment ( #6047 )
...
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
5 years ago
4e3a3665d6
For #3366 - Use one layout for edit/add bookmark ( #5900 )
5 years ago
d5c3433041
Use the new fragment constructor
5 years ago
d028c97112
For #5213 - Use support library attributes
5 years ago
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
5 years ago
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
5 years ago
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
5 years ago
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
5 years ago
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
5 years ago
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
5 years ago
671727c3e8
For #4341 use camelCase for views referenced from code
5 years ago
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
5 years ago
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
5 years ago
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
5 years ago
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
5 years ago
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
5 years ago
30930cdc88
Import variables referred to by path
5 years ago
d01bb8c442
Use lifecycleScope for collections fragments
5 years ago
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
5 years ago
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
5 years ago
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
5 years ago
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
5 years ago
7c00c2983b
No issue: Fix crash on bookmark folder selection and Snackbar color
5 years ago
849764d23a
For #974 : Telemetry for Bookmarks
5 years ago
5d6112da05
No issue: Missing clear button in edit bookmarks UI
5 years ago
29832c5e84
For #724 : Consolidates colors
5 years ago
d7272d29de
For #1408 - Set Toolbar titles in code (vs in navgraph)
5 years ago
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
5 years ago
Grisha Kruglov
mcarare
Tiger Oakes
Juan Goncalves
Mihai Eduard Badea
ekager
Sawyer Blatz
Harshal Lele
Emma Malysz
Kaaira Gupta
Severin Rudie
Mihai Branescu
Colin Lee
Suraj Shah
Nikit Bhandari
Andrei Teslovan