14 Commits (7dbfca2d2e6e28080c47028cb12e72bb8f0dc5ee)

Author	SHA1	Message	Date
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Michael Comella	a86b4ef1bd	For 17920: add ThreadPenaltyDeathWithIgnoresListener, tests, helpers.	3 years ago
Michael Comella	94bbf90f3c	No issue: move TestStrictModeManager to perf sub package.	4 years ago
Michael Comella	e8bf955893	No issue: move StrictModeManager to perf package. ... While StrictMode is not exclusively used for performance purposes, it's primarily used for perf purposes so let's move it to the perf package and code owner it.	4 years ago
Michael Comella	439dfc5cb1	For #15644: add comment for why we set the app theme in test.	4 years ago
ekager	2c7789b1a8	Sets theme in FenixRobolectricTestApplication onCreate	4 years ago
Michael Comella	7c0d00c800	No issue: fix tests related to inline change. ... The difficulty in mocking StrictMode.resetAfter is concerning. I'm starting to second-guess whether or not making strict mode manager a class was a good idea.	4 years ago
Tiger Oakes	c9f8986d2b	Don't init glean in unit tests (#13100)	4 years ago
Tiger Oakes	0e3acfcd94	Move config to robolectric.properties	4 years ago
Tiger Oakes	a7e74e308b	Migrate some SessionManager usage to BrowserStore (#10789)	4 years ago
Michael Comella	51a76651d6	For #9605 - review: clarify comments in new test runner.	4 years ago
Michael Comella	efef8eaba0	For #9605: TestApplication -> FenixRobolectricTestApplication. ... This disambiguates it from the FirefoxTestApplication used in on-device tests.	4 years ago
Michael Comella	8df49473c0	For #9605: move TestApplication to the helpers package. ... The helpers/ package is created to separate the test support code from the code under test.	4 years ago
Michael Comella	b0cfa3ee5c	For #9605: add FenixRobolectricTestRunner. ... This class will help us reduce duplication by specifying the configuration within the test runner rather than each test needing to specify it itself. This class is adapted from Firefox for Fire TV: https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt	4 years ago