3135062936
For #22770 - Use String.toShortUrl from A-C
2 years ago
70e740f23e
Updating the code to work with application-services v95.0.0
...
This required updating the code to handle the new app-services error
hierarchy.
2 years ago
d9d01db7cc
For #25980 : Replace deprecated setHasOptionsMenu with MenuProvider.
2 years ago
ffcef5ff2e
For #26844 : Fix ktlint issues and remove them from baseline.
2 years ago
0a5b8c49a0
For #24214 - Remove Event.wrapper for BookmarksManagement metrics
2 years ago
9817be4fd0
For #24252 - Rename foundation attribute to layer1
2 years ago
f1e7b49425
For #24252 - Rename primaryText attribute to textPrimary
2 years ago
7e1edc828e
For #23719 - Replace preference framework strings with string resources
2 years ago
c3a2c355a2
For #23769 - Replace @color/destructive_normal_theme with @color/fx_mobile_text_color_warning
2 years ago
088339c4de
changes to fix up issues with places uniffication
2 years ago
959a142c92
For #21973 - Use destructive_normal_theme in place of R.color.design_color
3 years ago
621c388c12
For #17917 - Finish migrating all synthetics usages
3 years ago
c0e01373e1
No issue: Update stable androidx and material versions
4 years ago
bd2c407943
For #4652 - Remove activityViewModels workarounds
4 years ago
f514f6099a
For #15508 : Show error when trying to save empty or invalid bookmark URL ( #15674 )
4 years ago
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
f51b570654
For #15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
078843675b
For #15211 : Make sure bookmarks are moved to the end of folders
4 years ago
027c1f9ea7
Closes #15206 : Only track 'move' event if bookmark parent was changed
4 years ago
b5b32ba6ea
For #11502 : Make sure to always process root titles for parent folders during edit
...
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
958474f9fb
For #13157 : Filter out folder being edited from 'select folder' dialog
4 years ago
fe288edb5d
Rename 'visitedAddBookmark' arg to a less confusing name
4 years ago
24de85f805
Remove unused nav arg from 'select folder'
4 years ago
410980fe27
For #11425 : Improve editing bookmarks flow.
4 years ago
1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
4 years ago
ee62297b4c
For #7854 - Update the views only if the bookmark node has changed
...
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.
Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
4 years ago
02bd0cc203
For issue #8648
4 years ago
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
4 years ago
b8fba63be4
For #9890 - Do not display full screen snackbar with toolbar padding
4 years ago
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
4 years ago
e318cd7d15
fix #8135 - remove getColorFromAttr
4 years ago
c0d7bc5bd5
Use navArgs helper in fragments
4 years ago
5e9b753acb
For #7473 , delay inflation of toolbar
...
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
4 years ago
e291c6905c
For #3813 - Create a save button for bookmark editing
4 years ago
9cbc3f7a4a
7410 remove rxjava ( #7426 )
...
* For #7410 : rewrite updateBookmarkFromObservableInput with coroutines
* For 7410: remove RxJava from project. :(
* For 7410: converted updateBookmarkFromTextChanges to Flow per review
4 years ago
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
5 years ago
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
5 years ago
8d68317388
4844 fix url elision ( #6588 )
...
* For #4844 : add test cases for url elision
* For 4844: implement toShortUrl to pass test cases
* For 4844: update plumbing to use toShortUrl
* For 4844: adds/handles suggested url elision test case
5 years ago
432d5fbff4
For #5848 Wrong toolbar colour - edit bookmark fragment ( #6047 )
...
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
5 years ago
4e3a3665d6
For #3366 - Use one layout for edit/add bookmark ( #5900 )
5 years ago
d5c3433041
Use the new fragment constructor
5 years ago
d028c97112
For #5213 - Use support library attributes
5 years ago
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
5 years ago
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
5 years ago
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
5 years ago
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
5 years ago
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
5 years ago
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
5 years ago
671727c3e8
For #4341 use camelCase for views referenced from code
5 years ago
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
5 years ago
Alexandru2909
Ben Dean-Kawamura
mcarare
Alexandru2909
Gabriel Luong
Sammy Khamis
Mugurell
ekager
Jocelyne Abi Haidar
Grisha Kruglov
Tiger Oakes
Juan Goncalves
Mihai Eduard Badea
ekager
Sawyer Blatz
Harshal Lele
Emma Malysz
Kaaira Gupta
Severin Rudie
Mihai Branescu
Colin Lee
Suraj Shah
Nikit Bhandari