Commit Graph

20 Commits (782e8980b04226991582988266fd28ecc1b81b77)

Author SHA1 Message Date
BFadairo 71bc9eb4f7 Closes #27854: Remove unnecessary Theme.getTheme() calls from FirefoxTheme usages 2 years ago
Noah Bond f4e7471aea For #26520 - Color homepage cards via wallpaper card colors 2 years ago
mcarare ffcef5ff2e For #26844: Fix ktlint issues and remove them from baseline. 2 years ago
Mugurell e51ec147c5 For #26830 - Allow the Pocket stories to scroll to the edges of the screen
Restore using LazyRow's "contentPadding" property to add padding to just the
items while the entire section is allowed to extend to the edges of the screen
and so have enough room to draw items shadows without them being clipped.
2 years ago
mcarare 02be7600e8 For #26444: Replace SectionHeader with HomeSectionHeader for home sections. 2 years ago
Alexandru2909 b6f140a76f For #24528 - Remove isPrivate conditional in getTheme in favor of inComposePreview 2 years ago
Mugurell d4dd62341a For #25401 - Record Pocket sponsored stories telemetry 2 years ago
MatthewTighe d6952cb2aa Fixes #25545: wait to draw Pocket until after first frame 2 years ago
Mugurell 12070cb7b8 For #25281 - Improve stories impressions recording.
This fixes the following two scenarios resulting in improper recordings:
- sponsored stories were recorded as shown as part of the impressions recording
for all the stories (both recommended and sponsored). Separated the two.
- sponsored stories were not recorded as shown if the user doesn't scroll.
This could happen if just toggling categories which would result in a new list
of stories to show. Will recheck after the time to settle if the composable is
shown.
2 years ago
Mugurell dfa5281b23 For #25281 - Pace and rotate sponsored stories
A new way to be able to reliably record actual impressions of sponsored stories
was needed and based on this data we can ensure we are promoting fresh stories
(with fewer impressions) or the ones with a higher priority.
2 years ago
Mugurell 75a2ed8c30 For #25025 - Old imports cleanup.
Importing `R.string` does allow to avoid the `R` when using a String from
Resources but seems like a small gain to break app consistency.
2 years ago
Mugurell 1c7e788bae For #25025 - Use the `PocketStory` supertype
This prepares extending support from just `PocketRecommendedStory` to
`PocketSponsoredStory` also.
2 years ago
Mugurell abff68a31b For #25025 - Hardcode showing at max 8 Pocket stories
The default was already 8. This is now being moved closer to the source from
where the stories to be shown are emitted.
With the addition of sponsored stories at fixed positions having to support a
variable number of stories being returned from AppState#getFilteredStories
means increased complexity with no benefit.
2 years ago
Gabriel Luong 8652ff5bcf For #24519 - Add Private theme to FirefoxTheme 2 years ago
Gabriel Luong aaa3d7b977 For #24114 - Refactor HomeFragmentStore parameters to AppStore 2 years ago
Mugurell 81604e8612 For #24342 - Actually log when Pocket stories are shown
Based on this we'll send telemetry and rotate the stories shown to prioritize
fresh ones instead of the ones already shown.
2 years ago
sunil9211 de4ea0a086 For #23551 - Change the spacing between Pocket header and content to 16dp 2 years ago
Mugurell 5bd6f1cb8c For #21854 - Split the big ComposeView in 3 smaller ones
This would shorten the time needed to layout all Pocket recommended stories
content in one go, though it may lead to shorten hiccups over a bigger period
of time.
2 years ago
mcarare 58a6fafabc For #22383: Propagate ViewTreeLifecycleOwner to composable view holders. 2 years ago
Gabriel Luong 07a6a386f8 For #21753 - Refactor Pocket out of sessioncontrol 3 years ago