10 Commits (74c1cc82fb4975f63c20a718f09367149bcc3c70)

Author	SHA1	Message	Date
Roger Yang	74c1cc82fb	Closes #19921: Update appcompat and fragment dependencies to 1.3.x	3 years ago
Jonathan Almeida	dc11c334b6	Issue #19112: Remove old tab tray code	3 years ago
Mugurell	3fb40e1f40	For #19475 - Introduce a DefaultTabsTrayInteractor ... Refactored the TabsTrayFragment to not implement the TabsTrayInteractor which among other advantages allowed for easier testing.	3 years ago
Mugurell	dc26272381	For #19475 - Cleanup - respect naming scheme in TabsTrayController ... In our current MVI implementation the View Interactors are first called in response to a direct user action and contain methods following the "onXXHappened" naming scheme and then delegate other Interactors / Controllers for specific actions. Controllers contain the business logic for actually updating the app's state and offer methods following the "handleXXAction" naming scheme.	3 years ago
Jonathan Almeida	392ace67d6	Issue #19175: Fix SyncTabs list not updating on changes ... The main cause for this is that the `LifecycleProvider` needs to be set to `State.RESUMED` to avoid the account manager's internal `ObserverRegistry` from putting the UI observers into the paused state. The rest of the changes is to rely the internal (safe) logic to correctly sync and then update the tabs list.	3 years ago
Roger Yang	8246f81c97	Closes #18948: Update tabstray telemetry (#19004)	3 years ago
MarcLeclair	990bfa7e6d	16900 make navgraph inflation asynchronous (#18889) ... * For #16900: implement async navgraph inflation For #16900: removed nav graph from xml For #16900: inflate navGraph programatically For #16900: Made NavGraph inflation asynchronous For #16900: Changed to block with runBlocking For #16900: Refactored blocking call into a function For 16900: NavGraph inflation is now async We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController). This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key. If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph to the navcontroller (and the inflation of the latter too) For 16900: rebased upstream master For 16900: Rebase on master For #16900: Fixed Async Navgraph navigation per review comments. 1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher 2)The Job is tracked through a WeakHashMap from Controller --> NavGraph 3)The Coroutine scope doesn't use MainScope() anymore 4)The Coroutine is cancelled if the Activity is destroyed 5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup() For #16900: inflateNavGraphAsync now takes navController For #16900: Pass lifecycleScope to NavGraphProvider For #16900: removed unused mock For #16900: Added linter rules for navigate calls We need linting rules to make sure no one calls the NavController.navigate() methods For #16900: Added TestRule to help abstract the mocks in the code For 16900: Fix linting problems For #16900: Cleaned duplicated code in tests For #16900: cleaned up NavGraphTestRule for finished test For #16900: had to revert an accidentally edited file For #16900: rebased master * For #16900: Review nits for async navgraph This is composed of squash commits, the original messages can be found below: -> DisableNavGraphProviderAssertionRule + kdoc. Use test rule in RobolectricApplication. Fix failing CrashReporterControllerTest Fix blame by -> navigate in tests. This commit was generated by the following commands only: ``` find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \; find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \; git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker ``` Fix various blame This is expected to be squashed into the first commit so, if so, it'd fix the blame. Move test rule to helpers pkg. add missing license header Add import change I missed fix unused imports Replace robolectricTestrunner with test rule. Improve navGraphProvider docs Remove unnecessary rule as defined by robolectric. add clarifying comment to robolectric remove unnecessary space * For #16900: nit fixes for MozillaNavigateCheck and lint fixes 3 squash commits: *Changed violation message and fixed the lint rule for MozillaNavigateCheck *Added suppression to NavController.kt *Fixed detekt violations * For 16900: Fixed failing tests Co-authored-by: Michael Comella <michael.l.comella@gmail.com>	3 years ago
Jonathan Almeida	1944a5ef6b	Issue #18885: Dismiss FAB icon when tabs tray is closed	3 years ago
codrut.topliceanu	9219a1b35b	For #18515 - Added Icon and sync functionality ... Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>	3 years ago
codrut.topliceanu	d961d7ba38	For #18515 - Adds FAB to TabsTray rewrite	3 years ago