When deleting bookmarks, we do not instantly remove them due to
having the possibility of undoing the deletion. Because of this,
when the bookmarks are pending to delete, they can still be displayed
when pulling down to refresh and then acted on. This patch aims to
fix this issue by subtracting the pending to delete bookmarks
when they are refreshed by pulling down.
(cherry picked from commit b98eea7fdc7901b1df91dcf796635a25cbe22900)
Co-authored-by: DreVla <vlad.dreghici@gmail.com>
Before, the orientation was taken from the application context which
didn't update during orientation change. Which caused to load the wrong
wallpaper when the phone was rotated. With these changes we can send
the correct orientation taken from the HomeActivity context.
The goal of this bug is to get a very basic initial `translate`
interaction using the default determined page language and default
determined user language and begin starting `Controller` and `Interactor`
files.
This bug also sets up `sessionId` as a navigation parameter for
translations.
Before, "More to consider" was not read separately as a heading
title when TalkBack was used but the whole card could be
traveled as a heading and it's content was all read at once.
Now "More to consider" heading is read separately from the rest
of the content.
This patch aims to improve a11y experience when accessing links
present in bodies of text. When we have a link text element, we
now indicate that there are links present in it and upon double
tapping, a dialog is open from where the user can access any of
the links present in the text. This behavior tries to follow the
default Talkback a11y one where the user can access links from a
text in case they are annotated as URLs.
This solution allows multiple links in one body of text and also
improves accessibility for lower version devices.
Fenix currently reports AMP and Wikipedia impressions and clicks in the
`fx-suggest` ping, which intentionally omits the `client_id`. This
complicates experiment analysis, because our tooling relies on the
`client_id`.
This commit adds separate events for impressions and clicks on
sponsored and non-sponsored suggestions to the `events` ping.
* The new `awesomebar.{non_}sponsored_suggestion_clicked` events are
collected the same way as the existing `fx-suggest` ping, and in line
with the other `awesomebar.*_suggestion_clicked` events.
* The new `awesomebar.{non_}sponsored_suggestion_impressed` events are
collected for engaged and abandoned search sessions. In constrast,
the `fx-suggest` ping is only sent for engaged search sessions.
mergify[bot]
Titouan Thibaud
RebecaTudor
iorgamgabriel
Noah Bond
Matthew Tighe
rahulsainani
t-p-white
Roger Yang
ohall-m
Gabriel Luong
mcarare
DreVla
jackyzy823
alexandra.virvara
mike a
Lina Butler
William Durand