Commit Graph

904 Commits (48ea10cd9d62ae924757a528656265f5805019f1)

Author SHA1 Message Date
Elise Richards feae7fff2f
FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317)
* Replace strings, add learn more, hook up button

* Constrain learn more and icon to the text

* View holder tests

* Lint

* Update homescreen ui test
4 years ago
Jonathan Almeida 99fab556f4 For #12287: Address review comments 4 years ago
Jonathan Almeida b54b743d83 For #12287: Show devices with no tabs in Synced Tabs list 4 years ago
Jonathan Almeida f614c0b18d For #12287: Add Synced Tabs to Tabs Tray 4 years ago
Kate Glazko f83372b67c For #349: View Downloads 4 years ago
Kainalu Hagiwara d49ca515f4 For #13330 - Remove feature flag for swipe to switch tabs. 4 years ago
Gilbert Gilb's 2743c37b40 Add custom Activity to show libraries licenses.
As Google's library for showing licences isn't open-source, this commit
reimplements its main Activity. This is in prevision to having an OSS
flavor of fenix.

We chose to not introduce dependencies to third-party libraries
such as AboutLibraries for now, and we'll stick to using Google's gradle
plugin for the dependencies extraction.

Fixes #7584

See also #162
4 years ago
codrut.topliceanu 4a20607f8b For #8625 - Label for search engine radio buttons 4 years ago
Kainalu Hagiwara d796dac145 For #13149 - Add end padding to tab history title and url views. 4 years ago
Jeff Boek 06ba8a0200 For #13053 - Handles common dismiss interactions 4 years ago
Jeff Boek c4d32bd75c For #13325 - Positions toolbar according to user preference 4 years ago
liuche 1e7f078907
Changed name_collection_dialog.xml's EditText's input type from "text… (#13367)
Co-authored-by: Karol Wąsowski <wasowski02@gmail.com>
4 years ago
Jeff Boek 6492773fc7
Progress on new search experience with Toolbar and Awesomebar placeholders (#13314)
* For #13272 - Adds the ToolbarView to the SearchDialogFragment

* For #13273 - Replaces container dependency with context in AwesomebarView

* For #13276 - Hacks together the awesomebar and toolbar in the new search experience
4 years ago
Jeff Boek 495341a945 For #13052 - Creates new dialog fragment for search and puts it behind a feature flag 4 years ago
Kainalu Hagiwara e1653f629e For #13127 - Make sure tabPreview is added after browserLayout. 4 years ago
Tiger Oakes 1d28f63737
Closes #12522: Reuse exceptions code (#13047) 4 years ago
Mihai Branescu ff50dae8e9 For #11498 - removed SignIn ViewHolder and unified with the Error one 4 years ago
Mihai Branescu bfc955cd40 For #11498 - add Sync tabs error view (including sign-in CTA) 4 years ago
Tiger Oakes 5ddf8beea7 Fix suggestions, extract layout for tab history 4 years ago
Tiger Oakes d8ff6179fe
For #7992: Use favicon style from AC (#12608) 4 years ago
Mihai Adrian Carare ac870634ff
For #12533: Align main settings categories according to specs. (#12534) 4 years ago
Kainalu Hagiwara bef98698cb For #12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment.
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
4 years ago
Leonardo Murça 0c8c87e56d For #12755 - Replace @+id by @id when referencing already declared ids
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
4 years ago
amkcpu af020d0af1 For #12706 - Add vertical scrollbar to bookmarks screen 4 years ago
amkcpu 791eac50f3 For #12704 - Add vertical scrollbar to history screen 4 years ago
amkcpu 210f1ab898 For #12707 - Add vertical scrollbar to search suggestions 4 years ago
Jonathan Almeida 239e3de5e9 For #12856: Add save to collections button to Tabs Tray
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
4 years ago
ekager 0657bf41d3 For #12991 - Set height to recommended touch target size for collect button 4 years ago
Elise Richards b7325a3833
For #12571: Rename shortcuts to search engine on search screen (#12839)
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
4 years ago
Tiger Oakes 57ac6fc36d Extract navigation subgraphs 4 years ago
Mihai Branescu 1cbc4eec52 For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y
Added a margin top of 20dp as well on the buttons so as not to change UI
4 years ago
Hakkı Kaan Çalışkan b3b7566fcf For #12804: Set min height for search engine radio button 4 years ago
ekager 46511d6f8e For #10163 - Adds tab multiselect mode 4 years ago
Jonathan Almeida d15b8381a6 For #10925: Fix breaking APIs in tabs tray 4 years ago
Kainalu Hagiwara 58ccc64386 Fix UI tests.
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
4 years ago
Kainalu Hagiwara e7dc5580b2 For #3481 - Implement swipe on toolbar to switch tabs. 4 years ago
Kainalu Hagiwara 921b16233b For #1048 - Add ability to view tab history by long-pressing the back or forward button. 4 years ago
Hakkı Kaan Çalışkan 2a0a11f740 For #12571: Rename 'Shortcuts' to 'Search engines'
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
4 years ago
Jonathan Almeida 99354174a9 For #12797: Use measured height/width for loading a thumbnail
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
mcarare 8826f99ef7 For #9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
4 years ago
Sawyer Blatz 284ec7b58f For #12461: Add tab count to tab tray 4 years ago
Tiger Oakes f73411b924
For #5499 - Unify CFR drawables and dimens (#12749) 4 years ago
Hakkı Kaan Çalışkan aeabd3e91b
For #12532: Quick fix for radio button alignment (#12691) 4 years ago
Kainalu Hagiwara cd2532349d For #12551 - Implement swipe to delete for bookmarks. 4 years ago
Kainalu Hagiwara 1121d844e6 For #12730 - Fix ripple for font size setting. 4 years ago
Tiger Oakes 499f185fc0
Fix lint issues (#12683) 4 years ago
Elise Richards 37af9df3ad
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (#12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Hakkı Kaan Çalışkan aa7655f4d6 For #12509: Set height of remove add on button to 36dp 4 years ago
ekager e358f95eed For #12364 - Only show PWA prompt the third time a user visits installable site 4 years ago
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
4 years ago
Hakkı Kaan Çalışkan b997fba953 No issue: Move dp's to dimens.xml 4 years ago
Hakkı Kaan Çalışkan cdd5d206fd For #12105: Follow ux mock on Settings --> Accessibility screen 4 years ago
ekager 9ed85510ae For #7094 - Adds save login exceptions 4 years ago
Hakkı Kaan Çalışkan f424656575 For #12107: Follow ux mock on Settings --> Account screen 4 years ago
Hakkı Kaan Çalışkan ca30fef579 For #12106: Follow ux mock on Settings --> Logins screen 4 years ago
ekager ad265be672 For #11303 - Change copy login origin to open in browser 4 years ago
Emily Kager 63eb7b3e4e
For #12010: Follow ux mock on Settings --> ETP --> Info screen (#12429)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
amkcpu fab64229a5 Closes #11873 - Add scrollbar in tabs tray 4 years ago
Hakkı Kaan Çalışkan 426a1ba57d For #12078: Follow ux mock on Settings --> Language screen 4 years ago
mcarare 9bc4f443f5 For #9775: Increase touch target of elements in add search engine screen 4 years ago
ekager 170ae1aa33 For #12263 - Adds end margin to synced tabs header 4 years ago
Hakkı Kaan Çalışkan 331090d1e6 For #12007: Fix add search engine items using wrap content for height 4 years ago
Emily Kager 90f43bf350
For #12086: Follow ux mock on Settings --> Customize screen (#12324)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
liuche ad8e28ae02
For #12007: Follow ux mock on Settings --> Search screen (#12177)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Tiger Oakes 50c3c9a9dd
Fix ignored XML lint issues (#12094) 4 years ago
Mihai Eduard Badea e0fa1c0db4 For issue #11835 - Update text fonts
Updated the fonts and colors for several texts throughout the application.
4 years ago
Michael Comella 5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014)
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
4 years ago
Jonathan Almeida f89b157c23
For #12002: Show default tab background when thumbnail not available (#12041) 4 years ago
Hakkı Kaan Çalışkan 2cbd969e34 For #11641: Update synced tabs view 4 years ago
mcarare 64947a8686 For #10285: Swap TextView for a LinkTextView to improve links a11y 4 years ago
mcarare 0626384baf For #10285: Swap TextView for a LinkTextView to improve a11y. 4 years ago
person808 ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 4 years ago
David Walsh 77ed670558 For #11860 - Conditionally show add to collection button on Home screen 4 years ago
mcarare 7b20bb9976 For #11562: Align overflow menu button with close buttons. 4 years ago
Jeff Boek 2c39d3ebca For #11430 - Gives enough padding to the tab tray give adequate space for the fab 4 years ago
Tiger Oakes ce31a620d5 Minify XML path 4 years ago
Jeff Boek 2861421312 For #11112 - Adds save tabs to collection button to the no collections message 4 years ago
ekager 761d253f59 For #8649 - Fixes overlapping bookmark sign in button 4 years ago
Hakkı Kaan Çalışkan c8d36ddc36 For #8649: No bookmarks here strings are close to the top 4 years ago
mcarare 00862708ae For #10551: Increase touch target for link. 4 years ago
ValentinTimisica 0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 4 years ago
Sachin 988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 4 years ago
ValentinTimisica 3ad7795a2d Fixes #11134: Removes margin to allow collection title to expand 4 years ago
mcarare e7bc266578 For #11665: Adjust visual design for delete browsing data screens. 4 years ago
Mihai Eduard Badea 0ce4aa1e60 For issue #10764 - Onboarding toggle color
- Removed the theme from the toggle so that the default colors from the themes are used instead
4 years ago
MarcLeclair 5f7bb68a51
For #11666: TopSites layout from Constraint to Linear (#11669) 4 years ago
Hakkı Kaan Çalışkan 56b00d0625 For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 4 years ago
Kainalu Hagiwara 291a29b334
For #11651 - Fix top site favicon size and dark theme border color. (#11652) 4 years ago
ekager 37ccc52d35 For #11558 - Fix double click required for tabs tray 4 years ago
Sören Hentzschel 396cd61efa For #9712 - show "AC: " before AC version on "About" screen 4 years ago
Jonathan Almeida e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 4 years ago
David Walsh 149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 4 years ago
David Walsh 063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 4 years ago
mcarare 724ca2fca9 For #10281: Reduce logo margin to compensate top site padding increase. 4 years ago
mcarare 852720f8c6 For #10281: Change margin with padding to allow flexbox to stretch. 4 years ago
Jeff Boek 1639b1d3a1 For #11342 - Fixes missing space for the FAB 4 years ago
person808 d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 4 years ago
Mugurell f163861b47 For #11177 - Load all share targets in the horizontal share menu
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.

As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.

The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
4 years ago
person808 3ff20c0b25 For #11081 - Add dark theme colors for top sites. 4 years ago
Elise Richards 137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
4 years ago