Commit Graph

203 Commits (48ea10cd9d62ae924757a528656265f5805019f1)

Author SHA1 Message Date
Tiger Oakes c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 (#11014) 4 years ago
Tiger Oakes 8e8e5aea36
Extract radio group logic into helper (#11493) 4 years ago
Kate Glazko 2ac8496315 For #12025: Set Search Shortcuts Off By Default 4 years ago
Sawyer Blatz 8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 4 years ago
mcarare 216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 4 years ago
Mihai Branescu 632b64971f For #10467 - removed unused tests and resources related to blue dot notification 4 years ago
mcarare 4bebc56c50 For #9229: Remember options for delete browsing data. 4 years ago
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
4 years ago
mcarare 886c1882c5 For #11230: Set default to false for allow screenshots in private setting 4 years ago
Sawyer Blatz 42f58a1984 For #9488: Add experimentation support 4 years ago
Sawyer Blatz 9302d07d13 For #11118: Add toggle states to metrics ping 4 years ago
ekager 20e358228e For #11015 - Switch Default ETP Setting to Standard 4 years ago
Sawyer Blatz b06be1fcde For #9488 Add telemetry for search widget CFR 4 years ago
Sawyer Blatz 94d741864e For #9488: Add search widget CFR 4 years ago
mcarare 9ec6ebc92a For #10969: Fix and clarify logic for checking showing PWA dialog. 4 years ago
David Walsh 8b843ac9e5 Fix elevation for snackbar and fab 4 years ago
Mugurell d0e2d02b34 For #10948 - Avoid PWA onboarding if user already has them on screen
It is possible that after migration users would already have Firefox PWAs on
their screen.
Since they already know about this functionality, we should not promote it to
them with the one-off `FirstTimePwaFragment`.

To query installed PWAs we'll use an API available only on Android >= 26 which
means that we will probably have half of users with PWAs still see the
onboarding but half which will not.
4 years ago
Sawyer Blatz 011a9e7d96 For #1216: Add voice search 4 years ago
Tiger Oakes cd64647a4d For #9286 - Add isDefault to topsites 4 years ago
ValentinTimisica 24ba9f2fc8 For #9505: Adds possibility to sort saved logins
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
4 years ago
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
4 years ago
mcarare 932fd44823 For #7387: Change ETP onboarding from popup to a dialog.
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
4 years ago
Sawyer Blatz dce16964c0
For #9208: Adds in-product prompt to homescreen (#9836) 4 years ago
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 4 years ago
Michael Comella 4437ddd536 No issue: Move Do and OpenClass to utils pkg.
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
4 years ago
Mihai Eduard Badea d66da53c9a For #2768 - Prevent screenshots in private mode
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.

 This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.

 The setting is by default set to true (screenshots are allowed to be taken)
4 years ago
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 4 years ago
Emily Kager 327009efc4
For #768: Add first time PWA dialog (#9308)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
ekager 96c6401457 For #8125 - Send top sites count with metrics ping 4 years ago
Grisha Kruglov 54b7fd8834 Make sure reconnect item is displayed in HomeMenu in case of account problems
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
4 years ago
Grisha Kruglov be1fa8df7d Pre: introduce a RunWhenReadyQueue
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.

This ability to either execute or queue a task will be useful later on in the
commit series.
4 years ago
Edouard Oger 394f386ac3 Add secret debug menu to override FxA servers 4 years ago
Severin Rudie 35a132d7ff
8017 advanced autoplay controls. (#8978)
* For #8017: add advanced autoplay controls
4 years ago
Severin Rudie 1381444a52 For #8800: clear menu highlights on use 4 years ago
Harshal Lele e318cd7d15 fix #8135 - remove getColorFromAttr 4 years ago
Sawyer Blatz e96732604b For #167: Improves home to browser animation 4 years ago
Mihai Adrian 9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 4 years ago
Severin Rudie c87c837865
For #8752: fix invalid AutoplayAction crash 4 years ago
Sawyer Blatz 13c9c39658 For #4383: Add feature flag 4 years ago
Severin Rudie 69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 4 years ago
mcarare ae13f4b44f For #8354 Remove unsetting open links in private if not default browser 4 years ago
mcarare bba563b5f9 For #6479: Add granular ETP settings 4 years ago
Jeff Boek 7aeb5f072d For #7295 - Adds more documentation for the installation metrics 4 years ago
codrut.topliceanu d6ae3d4abe For #7295 - Adds new custom ping: 'installation' 4 years ago
ekager b72550c28a For #8126 - Adds default top sites 4 years ago
Mugurell ad1144c722 For #6577 - Remove the `total_uri_count` Glean StringMetricType
This was added as a duplicate to an already existing `total_uri_count`
CounterMetricType in #4456.
4 years ago
Jeff Boek ef6913ec25 For #5905 - Combine theme and toolbar settings 4 years ago
MarcLeclair 834d7e13cd
Remove Tracking protection popup for visual testing (#8226)
* For #6903: allow override TP popup for performanceTest

* For #6903: refactored the code
4 years ago
Jeff Boek 9f3faa43fe For #4674 - Adds marketing data as a collection choice 4 years ago
Sawyer Blatz 0a6881d470
For #255: Removes autoplay media feature flag (#8198) 4 years ago
Tiger Oakes 5faa22d611
Use createBlendModeColorFilterCompat (#8129) 4 years ago
Emily Kager 604ac83d0c For #7999 - Change fxa leanplum metrics to false by default 4 years ago
Sawyer Blatz 1372ed5837 For #7970: Updates snackbars for accessibility 4 years ago
ekager 0777fb3bbe For #5545 For #5542 Closes #6696 Integrate logins API, adds Settings for Autofilling/Saving Logins 4 years ago
Sawyer Blatz a58decd708 For #6304 & #7577: Persist private mode between app launches 4 years ago
Sawyer Blatz 718c211a86
For #1718: Sets accessibility users to top toolbar by default (#7486) 4 years ago
Will Hawkins 9c28cb632c Issue #7425 (et al): Cache the list of installed browsers
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
4 years ago
Roger Yang f6e286fd9c
Closes #7346: Enable dynamic app links in Fenix (#7361) 4 years ago
Emma Malysz 13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (#7246)
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
4 years ago
Roger Yang dd1433733a
Closes #7156: Update app links feature usage to include app links interceptor (#7275) 5 years ago
David Walsh e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221)
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
5 years ago
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
5 years ago
mcarare 1d36098878 For #1019 Add onboarding search suggestion hint panel 5 years ago
mcarare 5543f3272d For #1019 Add option to enable search suggestions in private mode 5 years ago
Patrick Martin 5eb5cdf361 For #1695 - Detect HTML mime type for clipboard URL (#6612)
* For #1695 - Detect HTML mime type for clipboard URL
5 years ago
MozLando 204ead0827 Merge #6513
6513: For #5295 [A11y] Unable to tap snackbar r=kglazko a=kglazko



Co-authored-by: Kate Glazko <katglazko@gmail.com>
5 years ago
Emily Kager c43f96096e For #5074 - Sync Logins, Uses KeySharedPreferences for Passwords Encryption Key 5 years ago
Kate Glazko e038e0c41d 5 years ago
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
5 years ago
Emily Kager d9615108ee For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 5 years ago
Emily Kager 3e2b88cc91 For #5547 - Add top level auth when accessing passwords 5 years ago
Sawyer Blatz 8549b80272 For #4456: Adds total_uri_count to metrics core ping (#6003) 5 years ago
Jeff Boek d1643b785e For #2477 - Adds accessibility setting to force enable zoom 5 years ago
Severin Rudie 411ccc8f1f For 4780: add DefaultBrowsingModeManager tests 5 years ago
Severin Rudie c9e68bda31 For 4780: remove Settings#usePrivateMode and tests 5 years ago
Emily Kager 2b19b28d25 For #5651 - Set up Standard vs Strict Tracking Protection Experiment 5 years ago
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
5 years ago
Severin Rudie 3be06953d6 For #4780 switch off private mode (#5614)
* Do not launch in Private Mode

When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.

* Issue #4780: add comments to use private mode

* For #4780: write tests for clear private mode on create app

* For #4780: clear private mode when privacy notification is removed
5 years ago
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
5 years ago
Sawyer Blatz 2896b36d14
No issue: Updates naming of launch links privately var (#5701)
The previous name was pretty confusing
5 years ago
Sawyer Blatz c8af16bd47
For #5679: Hides autoplay behind feature flag (#5685) 5 years ago
Sawyer Blatz 7f328a6dc4
For #1298: Adds adjustCampaignId to core ping (#5579) 5 years ago
Sawyer Blatz b6e6e36ccd For #561: Fix stutter of search icon & text when animating 5 years ago
Sawyer Blatz 75a25c9bd0 For #561: Fix linting issue 5 years ago
Jeff Boek c592a69aad For #561 - Fixes snackbar placement on homeview 5 years ago
Emily Kager 25e2a7abfc For #2765 - Run places maintenance daily (#5466) 5 years ago
Tiger Oakes 6c30a94081 Move settings classes to packages 5 years ago
Sawyer Blatz 6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 5 years ago
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 5 years ago
Sawyer Blatz 2db2d9ceae For #1744: Adds tests for clipboard 5 years ago
Sawyer Blatz e961a9d63d For #1744: Adds clipboard provider to search engine screen 5 years ago
Tiger Oakes 1777b5a830 Use enum to simplify delete on quit code 5 years ago
Tiger Oakes 42bb3e1410 Change deleteAndQuit to take an activity 5 years ago
Emily Kager da37dedba3 For #5279 - Don't use runBlocking in delete and quit 5 years ago
Emily Kager e3209dcc84 For #3700 - Add Setting to Delete Data on "Quit" menu action 5 years ago
Emily Kager 418b1ba890 For #1749 - Use Strict ETP by default, use Feature Flag for Settings 5 years ago
Yeon Taek Jeong 2e2bac4ccd
For #419: Create launch icon for private browsing (#4948) 5 years ago
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 5 years ago
Tiger Oakes 3c07cacf4d Use A-C preferences property delegates 5 years ago
Sawyer Blatz 2653b5966e
For #964: Adds ability to disable each suggestion provider (#5096)
* For #964: Adds ability to disable each suggestion provider

* Fix nit
5 years ago