Three new settings and one for which this patch just pre-lands the strings.
The behavior for the "Swipe toolbar up to open tabs" is to be added as part of
a later ticket.
Apply https://gitlab.com/relan/fennecbuild/-/blob/master/fenix-liberate.patch
at edac9bd4083644ae0b8ae04e6af719892f05ee3a
License sign-off from author "relan" in
https://gitlab.com/relan/fennecbuild/-/issues/4#note_404430753
"Note that fenix-liberate.patch is a copypaste from various projects under
Apache 2.0 and MPL 2.0. I've made only trivial changes and it makes sense to
distribute them under MPL 2.0 or Apache 2.0, not AGPL.
I think I need to add license headers to all new files added by the patch."
We can pick up additional license headers if and when they're added by relan.
Almost all the code is trivial, probably-uncopyrightable stubs.
We might be supposed to put more info in the licenses screen in the app, which
I'm keeping, for some of these, but I'm not sure how.
For "closeTabsAfterOneMonth", use the correct summary string of
"close_tabs_after_one_month" instead of "close_tabs_after_one_week".
This fixes the Settings page "Close tabs" summary showing the wrong
tab duration when "Close tabs" is set to "After one month".
Closes#14642
* Add notifications pref in top level settings to route to Android app and notification settings
* Make pref visible on Oreo and higher
* Only show notifications pref when Oreo and above
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
* For #11171 - Removes feature flag for the new tab tray
* For #11171 - Removes all tab references from homeFragment
* For #11171 - Fixes unit tests
* For #11171 - Gets UI tests to compile and HomeScreenTest to pass
* For #11171 - Fixes `deleteMultipleSelectionTest`
* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`
* For #11171 - Fixes `openHistoryInPrivateTabTest`
* For #11171 - Fixes `openHistoryInNewTabTest`
* For #11171 - Fixes `openNewPrivateTabTest`
* For #11171 - Fixes tabbedBrowsingTests
* For #11171 - Fixes SettingsPrivacyTest
* For #11171 - Fixes TopSitesTest
* For #11171 - Fixes lint errors
* Ignore
Abhijit Valluri
Jeff Boek
Adam Novak
Mugurell
Gabriel Luong
mcarare
Shane Synan
ekager
Tiger Oakes
Elise Richards
Jonathan Almeida
Sawyer Blatz
Hakkı Kaan Çalışkan
Kate Glazko
Mihai Branescu