ec96d134ff
No issue: Fix breaking AccountObserver API
5 years ago
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
5 years ago
c342a680d8
Fix crash for bookmarks
5 years ago
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
5 years ago
ccae66c08a
Issue #2379 - Use LibraryPageView in history
5 years ago
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
5 years ago
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
5 years ago
af449c84d5
For #4137 - Fixes HistoryInteractorTest
5 years ago
4494e40dbc
For #4137 - Adds pagination to the history view
5 years ago
2467588c4a
Create shared custom view for library items
5 years ago
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
5 years ago
88c05a5f43
Use glide-like image loading function
5 years ago
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
5 years ago
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
5 years ago
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
5 years ago
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
5 years ago
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
5 years ago
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
5 years ago
ae3d187909
For #3987 - Convert History to Lib-State and add tests
5 years ago
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
5 years ago
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
5 years ago
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
5 years ago
52d4c43916
Merge some library UIView code for toolbar
5 years ago
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
5 years ago
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
5 years ago
fe51bbcf7b
Update FxA integration to new APIs
5 years ago
9e7282cf18
For #1949 - Fixes bookmark separator appearance, removes menu ( #3957 )
5 years ago
21c75ca1bb
For #3478 - Add Tab sent snackbar confirmation for device sharing
5 years ago
9901514766
Replace deprecated pxToDp ( #3932 )
5 years ago
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
5 years ago
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
5 years ago
dbe29ebbda
For #3174 : Adds telemetry for bookmarks ( #3724 )
5 years ago
50052c9b9b
For #3551 : Tapping a bookmark/history from Library should open new tab ( #3832 )
5 years ago
8cd1a0cb38
Move adapter Job setup code to helper class ( #3407 )
5 years ago
7473126f7c
For #3784 : Crash loading bookmarks while detached ( #3787 )
5 years ago
386a3f3acc
For #3785 : Crash onDestroy of BookmarkFragment when detached ( #3786 )
5 years ago
9142e2279c
For #1968 - Adds menu option to add new folder in BookmarkFragment menu
5 years ago
606e66219c
No issue: Use chains for bookmark items ( #3696 )
...
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
c9962a7ad0
Closes #3701 - When deleted use bookmark title if url is null in snackbar ( #3716 )
5 years ago
77edb7afe1
For #2960 Closes #3671 - Fixes bookmark deletion with undo, wraps list
5 years ago
4994554576
No issue: Adds lint exception for when statement ( #3685 )
5 years ago
30930cdc88
Import variables referred to by path
5 years ago
d01bb8c442
Use lifecycleScope for collections fragments
5 years ago
6bf8d6be34
Use @JvmOverloads instead of multiple constructors
5 years ago
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
5 years ago
e244aae104
For #3214 - History multi-selection aborted, the same item can't be selected again ( #3607 )
5 years ago
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
5 years ago
22bcd70edc
For #3213 : Fix multi-select bookmarks on return to fragment ( #3413 )
5 years ago
e458d8b6a1
Fixes #3365 - Set selectedFolder to null if it's already selected ( #3415 )
5 years ago
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
5 years ago
b498f5559b
For #3333 : Only show desktop bookmarks if logged in ( #3356 )
5 years ago
decacbfc97
For #3323 Runs PublicSuffixList synchronously
5 years ago
5df726715f
Revert "For #3008 , For #2162 Add Simple Logic for Menu Orientation" ( #3310 )
...
#3114
5 years ago
82d2a0661b
Remove deprecatd support-ktx methods ( #3305 )
5 years ago
45c509fbce
For #2648 : Updates trimming of url hostname ( #3191 )
...
* For #2648 : Updates trimming of url hostname
* For #2648 : Fix nits
5 years ago
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
5 years ago
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
5 years ago
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
5 years ago
dc0d153580
For #3008 , For #2162 Add Simple Logic for Menu Orientation ( #3114 )
...
* For #3008 - Adjust orientation of collections menu based on view location
* For #2162 - Add simple menu orientation logic to bookmark menu
5 years ago
d5a9627273
For #2941 - Remove Delete Dialog, Theme Dialogs ( #3052 )
5 years ago
a7d5cdcb9d
For #2723 - Fixes theme manager
5 years ago
cd19f36b96
For #2227 : Fixes issue with bookmark selection ( #3021 )
5 years ago
b8c04e02e9
For #2327 : Fixes nits
5 years ago
fe50e88fc8
For #2327 : Adds error state syncing
5 years ago
5f42a65c2a
No issue: improve allowUndo
...
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on
New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
5 years ago
3920cda693
For #2419 - Adds a deletion state to the history component
5 years ago
39df4c8522
For #747 . Improve `HistoryFragment` readability.
5 years ago
13f144f212
For #747 . Fix coroutines leaks in `HistoryFragment`.
5 years ago
9e7269214c
Closes #2835 : Do not assume bookmarks fragment is attached while processing operations
...
This is mostly necessary when we're running stuff in a coroutine, so the patch likely goes
overboard a bit with the nullability checks... but it shouldn't hurt.
5 years ago
3da6cfd98a
For #2886 : Fix sending multiple tabs to another device ( #2923 )
...
* For #2886 : Fix sending multiple tabs to another device
* Update share methods to use new API
5 years ago
bfc0fa36b1
For #2133 - Add destructive text color to delete history button
5 years ago
7d65e21b83
For #2941 - Creates delete dialog style
5 years ago
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
5 years ago
2ad3a72f6f
Closes #2252 : Show "Desktop Bookmarks" in the Bookmarks library ( #2797 )
...
This patch adds in a virtual "Desktop Bookmarks" folder to the top
of the mobile root child list, and makes sure to change internal
bookmark root names to user friendly labels.
5 years ago
eb7646f073
Add custom share sheet and send tab support ( #2757 )
...
* Closes #2751 : Add custom app share sheet
* Closes #2753 : Add send tab devices to share sheet
* Closes #2752 : Add build flag for send tab
* Replace Context.share with ShareFragment
5 years ago
04e28096b2
fixed wrongly named variable
5 years ago
56dec1ebfb
fixed linting issues
5 years ago
cc03aeb9f0
For #2435 - adds URL to bookmarks in library
5 years ago
851f066a2a
For #2377 - Added ability to share multiple history items
5 years ago
40f8e3b6af
No issue: Use ExcludeTypes instead of filtering after retrieving
5 years ago
291df48c4e
Install the "icons" WebExtension to automatically load icons for every visited website.
5 years ago
c334c77bbe
For #976 : Adds telemetry for library
5 years ago
028c6cad70
For #2025 - Create and theme Dialog for deleting all history
5 years ago
fd4de3509d
For #1249 - Create Empty History State
5 years ago
72d29c2a43
For #2205 & #1578 : Integrates tab collection storage ( #2478 )
...
* For #2205 : Adds TabCollectionStorage
* For #1578 : Adds delete to TabCollection
5 years ago
334868c283
For #2224 : Removes select bookmark and fixes crash
5 years ago
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
5 years ago
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
43a4b1b77c
For #563 : Restyles history favicons ( #2455 )
5 years ago
fd56b1fef3
Closes #2340 . Set navigation icon color on library screen. ( #2415 )
...
Applying color filter to `toolbar.navigationIcon`.
5 years ago
e1cdeffe8c
For #563 : Restyles history management ( #2378 )
5 years ago
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
5 years ago
96b68948b5
For #1710 : Create scaffolding for Robolectric tests ( #2282 )
5 years ago
030912bfc5
For #1966 : back button from multi-selection toolbar should cancel ( #2207 )
5 years ago
548c3be51e
For #1702 : Multiple selection toolbar replaced with "fragment_home' ( #2204 )
5 years ago
a60d2c071c
For #1967 : Multi-selection toolbar should disappear after deleting ( #2202 )
5 years ago
a4c201f2ee
For #1870 : Copy bookmark folder does nothing ( #2193 )
5 years ago
eb0a10078c
No issue: refresh after undoing bookmark deletion ( #2198 )
5 years ago
c151c4b97b
For #1862 : deleting a bookmark item not hiding it immediately ( #2188 )
5 years ago
41bbc1ad2b
Closes #2163 - Check if bookmark title is null or blank
5 years ago
70486039c0
Closes #2147 : Refactors usage of openToBrowserAndLoad
5 years ago
f1050eaff5
For #1951 : Bookmarks library pane displays everything from root down ( #2135 )
5 years ago
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
5 years ago
688cae33c3
For #1877 : Crash on edit or delete the default bookmark folders
5 years ago
ff08d0dbb0
For #1843 - Passes selected tabs through the MVI loop
5 years ago
2162e74f76
Closes #1948 - Shows bookmark url if title is null
5 years ago
05b9df34d8
For #1922 - Open bookmark in new tab menu should open and show new tab
5 years ago
df6230182c
Closes #469 - Changes Library String
5 years ago
78abd43b3e
For #1923 : Title of bookmarks folder is not displayed
5 years ago
41e8acf05f
For #724 : Adds contrastText color for buttons using accent backgrounds
5 years ago
b54a1c9c57
Fixes #1886 : Applies theme to toolbar onResume of library fragment ( #1888 )
5 years ago
23e2b51db2
For #1759 - Try to change copy URL to plainText ( #1850 )
5 years ago
7c00c2983b
No issue: Fix crash on bookmark folder selection and Snackbar color
5 years ago
080dadcb7e
For #1817 : Multi-select toolbar changes when minimized
5 years ago
0f367a018a
For #724 : Corrects colors for all themes
5 years ago
85245d7b40
Closes #1717 : Removes search button from library
5 years ago
9e2164720e
For #1596 : Bookmarks get the last used folder as parent
5 years ago
12614e0142
For #1555 : Bookmark Overflow menu tap area should be larger
5 years ago
d5557b0db3
For #1598 : Auto-select new created folder for moving bookmarks
5 years ago
b88eea2f53
For #1701 , #1703 : Bookmark multi-select icons wrong color after deselect
5 years ago
849764d23a
For #974 : Telemetry for Bookmarks
5 years ago
29f83a0c0f
For #1698 - Removes unimplemented library sections for the beta
5 years ago
3b3d4c3de5
Fixes #1646 : Changes bookmarks toolbar color ( #1651 )
5 years ago
6bff472276
No issue: Add Bookmark multi-select edit button
5 years ago
5d6112da05
No issue: Missing clear button in edit bookmarks UI
5 years ago
29832c5e84
For #724 : Consolidates colors
5 years ago
9b1c1b5f4d
For #1571 : Make bookmark deletion undoable
5 years ago
bc1b7e0b43
For #1539 : Add bookmark multi-select features
5 years ago
abb76b4bd4
Fix #1531 - Remember HistoryState.Mode to choose the right HistoryAction.Delete
5 years ago
9c492f801d
For #1397 - Updates changelog
5 years ago
5ec86b34e9
Fixes history visual bugs
5 years ago
4a32ef8ed8
Fixes #1397 - Adds the delete button back to the history recyclerview
5 years ago
d7272d29de
For #1408 - Set Toolbar titles in code (vs in navgraph)
5 years ago
65235d5cf3
For #1459 - Try more ways to get title for history item
5 years ago
61e99ea476
Fixes #1496 : Crash adding bookmark folder
5 years ago
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
5 years ago
395d6f20d5
Fixes #1361 : Adds new tab when selecting history or bookmark items ( #1363 )
5 years ago
65a210ec64
Prevent RecyclerView from loading everything
...
Fixes #1360
Fixes #1303
Fixes #1280
5 years ago
0bcad0d364
History UI limits: visit type & time
...
These are temporary limitations to make History UI somewhat functional,
until we get relevant UI and API changes in place.
5 years ago
a2200b6335
For #208 - Dark/Night Theme
5 years ago
31bfba3bd8
No issue - update to A-C 50
5 years ago
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
5 years ago
00ad9d3f6f
For #356 - Gives a user the ability to delete their history
5 years ago
6249b9eb89
Closes #1231 : Changes all use of favorites to bookmarks
5 years ago
78ff152ad7
For #1104 - Sections history items
5 years ago
bd9b7d8d8d
Group history by date
5 years ago
df40ec970e
Simplify ItsNotBrokenSnack() and make resilient
...
Co-authored by: Emily Kager <ekager@mozilla.com>
5 years ago
4963f7ccdb
Add Snackbar to link testers to Github issue for features
5 years ago
5a839167fc
No issue: Tune Home and Library UI from Updated Mocks
5 years ago
fd4acf6e92
Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443 ( #958 )
...
* Upgrade AC dependency to 0.47.0-SNAPSHOT and GV to 67.0.20190312095443
* Fix compliation errors
5 years ago
d1219a26f5
Closes #749 : Adds coloring to destructive history option
5 years ago
5b8d40e6e0
Closes #655 - Show/Hide toolbar in onResume
5 years ago
53f391de60
Closes #537 : Refactors private sessions ( #629 )
5 years ago
5cf61c95db
Fixes #589 : Add sample unit tests for a component
5 years ago
291f21aa8e
Handle listener state bugs as onViewCreated isn't always called
5 years ago
6d71faa44d
Fixes #541 : Crash on Home Screen
...
The Android Lifecycle Architecture component does not have fine-grained enough lifecycle event callbacks to safely manage Rx subscriptions in Fragment lifecycles. Added autodispose to simplify.
5 years ago
927c1bdc85
For #357 - Uses synthetic imports
5 years ago
d3c0aa20c1
For #357 - Removes unneeded if statement
5 years ago
007cefa281
For #357 - Adds some descriptive comments for temporary values
5 years ago
4263f8ab3e
For #357 - Adds menu to delete a single item
5 years ago
434c839b73
For #357 - Emits action on delete
5 years ago
a65bd9b245
For #357 - Changes delete text depending on the number of items selected
5 years ago
1f276ec9fc
For #357 - Display number of selected items in the delete button
5 years ago
20944ae1be
For #357 - Adds a button to delete history
5 years ago
2cfc1bfc6a
For #357 - Handles back press in edit mode
5 years ago
a6e38165cb
For #357 - Dont set the checkbox if it already contains the right value
5 years ago
0cc44d1ee2
For #357 - Adds ability to toggle checkbox by selecting item
5 years ago
b7c7fd3100
For #357 - Adds selected items to the history component state
5 years ago
0cbcd93208
For #357 - Adds an editing mode to the history component
5 years ago
e5fe80f928
Closes #347 : Adds private browsing logic ( #506 )
...
* For #347 : Adds private browsing logic
* For #347 : Adds private session explainer
* Adds persistence
5 years ago
a4a9222a94
For #490 - Fixes navigation when selecting a history item
5 years ago
06403f3b3f
For #490 - Properly closes the library when launched from the home view
5 years ago
5addcca524
For #456 - Adds popover menu to menu button
5 years ago
b6ab865e44
For #355 - Fixes the default context
5 years ago
a0ac6bfb37
For #355 - Uses the generated Navigation directions
5 years ago
d8845dc524
For #355 - Adds history section header
5 years ago
29227e6f90
For #355 - Fixes coroutine scope
5 years ago
b9171cd99a
For #355 - Navigat back to brows when you tap a history item
5 years ago
aac39f97f2
For #355 - Creates ViewHolder for HistoryItem
5 years ago
64e96495cc
For #355 - Adds history to the recyclerview
5 years ago
22ab6ac934
For #355 - Creates the history component
5 years ago
0b147d8956
For #355 - Adds the history fragment and the ability to navigate to it
5 years ago
77883c0f30
Closes #403 Use Fragments for Navigation, Add Toolbar to HomeActivity
5 years ago
4f3c0ee8ad
Closes #378 - Creates Library Fragment UI and adds resources
5 years ago
Jonathan Almeida
Colin Lee
Tiger Oakes
Emily Kager
Jeff Boek
ekager
James Hugman
Christian Sadilek
ValentinTimisica
Sawyer Blatz
Grisha Kruglov
Tiger Oakes
royang51
Andrei Teslovan
Arturo Mejia
Denys M
Harsh Shandilya
Sören Hentzschel
Sebastian Kaspari
Mugurell