Commit Graph

86 Commits (4566bd6fba6078a6feb47dafbe988e116b9f0a88)

Author SHA1 Message Date
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 5 years ago
ValentinTimisica 59c60ef189 Fixes #4354: Updated SearchFragment state after returning from SearchEngineFragment.
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
5 years ago
Yeon Taek Jeong 6f962d3376
For #1744: Open search shortcuts when entering search mode (#4536) 5 years ago
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 5 years ago
Yeon Taek Jeong 83ceec6289 For #201: Search Widget 5 years ago
Amaan Marfatia 4c13f45e9e Fixes #4192: Private keyboard in private browsing (#4345)
Sets compliant keyboards to private mode when in private browsing.
5 years ago
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 5 years ago
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
5 years ago
Sawyer Blatz 28eb5c541a
For #1944 & #1750: Updates private & night mode colors (#4232) 5 years ago
Tiger Oakes edb0a3ed08 For #3633 - Update StoreProvider to use a callback
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
5 years ago
Christian Sadilek c04dcec03f Closes #4096: IllegalStateException in SearchFragment (#4131) 5 years ago
Jeff Boek ec099a6e11
For #3633 - Creates generic store provider (#4060) 5 years ago
Christian Sadilek e91a2e61a2 For #3633: Add unit tests for SearchStore 5 years ago
Jeff Boek e4ff70c542
For #3633 - Refactors the search screen to use lib-state
* For #3633 - Adds SearchStore

* For #3633 - Refactors AwesomeBarUIView

* For #3633 - Refactors ToolbarUIView to use lib-state

* For #3633 - Fixes a couple of state bugs

* For #3633 - Moves all user interaction to SearchInteractor

* For #3633 - Adds kdocs to SearchStore and SearchInteractor

* For #3633 - Adds documentation for the properties on SearchState
Also removes uneccessary property

* For #3633 - Creates `StateViewModel` to handle state restoration

* For #3633 - Adds a test for onTextChanged

* For #3633 - Adds tests for SearchInteractor

* For #3633 - Fixes bugs and adds documentation
5 years ago
Emily Kager 867067537a For #3568 - Use correct styling for QR and Share Alert Dialogs 5 years ago
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 5 years ago
Jeff Boek f323c38be0 For #981 - Adds missing Leanplum events 5 years ago
Colin Lee d5c5587a0c
For #3209: Disable shared element animations for crash temporarily (#3482) 5 years ago
Emily Kager 5eb2bc6d55 For #3138 - Sets height of toolbar in SearchFragment to match_parent (#3400) 5 years ago
Colin Lee 66a836cf3a
For #3314: Toolbar and QAB unresponsive after Android 6 perms check (#3373) 5 years ago
Sawyer Blatz 86aac3e313 For #3176: Hides camera options on devices without cameras (#3273) 5 years ago
Jonathan Almeida f7bd39da77 For #3138: Fix white background on search bar 5 years ago
Denys M 605a552f16 For #1366. Update toolbar search state when typing. (#2908) 5 years ago
Emily Kager 8dbed67f7f No issue: Simplify and speed up shared element transitions 5 years ago
Emily Kager 43a961fe73 For #1973 - Toggle QR button on deny permissions, fix engineView crashes 5 years ago
Emily Kager 8181705b58 Init Toolbar in edit mode so we don't see the flash 5 years ago
ekager dee3c059dc Adds Shared Transition between Home and Search 5 years ago
Emily Kager a80053547e For #2806 - navigate up from SearchFragment instead of activity back press (#2812) 5 years ago
Emily Kager e534dad199 For #2028 - Pass Session ID for Custom Tab Prompts, Theme Dialogs 5 years ago
Emily Kager 028c6cad70 For #2025 - Create and theme Dialog for deleting all history 5 years ago
Sawyer Blatz 9e50b55340 For #1857: Adds telemetry for QR scanner 5 years ago
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
5 years ago
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 5 years ago
Emily Kager e4b4934f53 For #2393 - SearchTermsTapped even on URL should search (#2398) 5 years ago
Sawyer Blatz 70486039c0 Closes #2147: Refactors usage of openToBrowserAndLoad 5 years ago
Colin Lee 5b7e297adf
For #1955: Add prompt before loading QR code (#2096) 5 years ago
Emily Kager 97e4f43fda No issue: null check context on permission granted (#2104) 5 years ago
Sawyer Blatz 29238d6e5f For #1954: Hides keyboard when requesting camera permission 5 years ago
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 5 years ago
Sawyer Blatz 4945805e37
For #1954: Resolves QR scanner back press and keyboard issues (#2036) 5 years ago
Jeff Boek 31494a4341 Sets the search engine to the default if no shortcut is used 5 years ago
Sawyer Blatz 8a4995099f For #1205: Adds search term to EditToolbar 5 years ago
Colin Lee 6199d31924 For #1851: QR code scanner doesn't load right after permission grant 5 years ago
Colin Lee d1fd5ec879 For #113: QR Scan 5 years ago
Jeff Boek cb7ad32b62 For #1158 - Add search counts 5 years ago
Sawyer Blatz f48e2b072e No issue: Cleans up SearchShortcut changes 5 years ago
Sawyer Blatz 471b08d97a Closes #1194: Adds shortcut telemetry 5 years ago
Sawyer Blatz 36af5107c6
Closes #875: Adds search shortcuts (#882)
* Closes #875: Adds shortcuts

* Refactor and clean up

* Remove TODO

* Removes local

* Fix nits

* Refactors to add ShortcutEngineManager
5 years ago
Jeff Boek edb197d10b Adds search engine icon to the toolbar 5 years ago
Jeff Boek 32f8e06e98 For #959 - Adds search related telemetry 5 years ago